All of lore.kernel.org
 help / color / mirror / Atom feed
From: paul.gortmaker@windriver.com (Paul Gortmaker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: versatile: fix build failure in pci.c
Date: Wed, 4 Apr 2012 09:53:08 -0400	[thread overview]
Message-ID: <4F7C5244.4040700@windriver.com> (raw)
In-Reply-To: <20120404090754.GR24211@n2100.arm.linux.org.uk>

On 12-04-04 05:07 AM, Russell King - ARM Linux wrote:
> On Tue, Apr 03, 2012 at 09:47:13AM -0400, Paul Gortmaker wrote:
>> As a side note, the fact that struct pci_sys_data is ARM specific
>> does make one think it would be nice if the name somehow did
>> reflect that...  wonder if it is worth changing.  Anyway, that is
>> a separate topic.
> 
> And what's wrong with the existing name when it's limited to only
> ARM specific files?

Just in the context of Arnd's original comment, he thought I
screwed up by feeding an ARM specific struct into generic
PCI code, because I wasn't aware it was ARM specific.

That wasn't the case, but he's right that something like that
could happen  A minor nit, sure, but if it was something like
pci_arm_data, the name itself would convey it was arm specific,
even in reduced context scenarios (like grep output etc).

P.

  reply	other threads:[~2012-04-04 13:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 23:48 [PATCH] ARM: versatile: fix build failure in pci.c Paul Gortmaker
2012-04-03  0:03 ` Fabio Estevam
2012-04-03  1:01   ` Paul Gortmaker
2012-04-03  1:57     ` Fabio Estevam
2012-04-03  8:19       ` Arnd Bergmann
2012-04-03 13:47         ` Paul Gortmaker
2012-04-03 14:26           ` Arnd Bergmann
2012-04-03 16:44             ` Bjorn Helgaas
2012-04-03 19:09               ` Paul Gortmaker
2012-04-03 19:40                 ` Arnd Bergmann
2012-04-04  9:08             ` Russell King - ARM Linux
2012-04-04  9:07           ` Russell King - ARM Linux
2012-04-04 13:53             ` Paul Gortmaker [this message]
2012-04-04 14:26               ` Russell King - ARM Linux
2012-04-03  4:58 ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7C5244.4040700@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.