From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] gpio: Device tree support for LPC32xx
Date: Wed, 4 Apr 2012 08:48:38 +0000 [thread overview]
Message-ID: <201204040848.39376.arnd@arndb.de> (raw)
In-Reply-To: <1333497518-25838-1-git-send-email-stigge@antcom.de>
On Tuesday 03 April 2012, Roland Stigge wrote:
> This patch adds device tree support for gpio-lpc32xx.c
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Just one more comment:
> +#ifdef CONFIG_OF
> +static struct of_device_id lpc32xx_gpio_of_match[] __devinitdata = {
> + { .compatible = "nxp,lpc32xx-gpio", },
> + { },
> +};
> +#endif
> +
> +static struct platform_driver lpc32xx_gpio_driver = {
> + .driver = {
> + .name = "lpc32xx-gpio",
> + .owner = THIS_MODULE,
> + .of_match_table = lpc32xx_gpio_of_match,
> + },
> + .probe = lpc32xx_gpio_probe,
> +};
The #ifdef above is not helpful, it will cause a build error in the
of_match_table= assignment. Since the plan for this driver is to
be devicetree-only, it would be appropriate to just remove the
#ifdef, but adding of_match_ptr() is ok too.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Roland Stigge <stigge@antcom.de>
Cc: grant.likely@secretlab.ca, arm@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linus.walleij@stericsson.com
Subject: Re: [PATCH v2] gpio: Device tree support for LPC32xx
Date: Wed, 4 Apr 2012 08:48:38 +0000 [thread overview]
Message-ID: <201204040848.39376.arnd@arndb.de> (raw)
In-Reply-To: <1333497518-25838-1-git-send-email-stigge@antcom.de>
On Tuesday 03 April 2012, Roland Stigge wrote:
> This patch adds device tree support for gpio-lpc32xx.c
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Just one more comment:
> +#ifdef CONFIG_OF
> +static struct of_device_id lpc32xx_gpio_of_match[] __devinitdata = {
> + { .compatible = "nxp,lpc32xx-gpio", },
> + { },
> +};
> +#endif
> +
> +static struct platform_driver lpc32xx_gpio_driver = {
> + .driver = {
> + .name = "lpc32xx-gpio",
> + .owner = THIS_MODULE,
> + .of_match_table = lpc32xx_gpio_of_match,
> + },
> + .probe = lpc32xx_gpio_probe,
> +};
The #ifdef above is not helpful, it will cause a build error in the
of_match_table= assignment. Since the plan for this driver is to
be devicetree-only, it would be appropriate to just remove the
#ifdef, but adding of_match_ptr() is ok too.
Arnd
next prev parent reply other threads:[~2012-04-04 8:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 23:58 [PATCH v2] gpio: Device tree support for LPC32xx Roland Stigge
2012-04-03 23:58 ` Roland Stigge
2012-04-04 8:48 ` Arnd Bergmann [this message]
2012-04-04 8:48 ` Arnd Bergmann
2012-04-04 11:08 ` Roland Stigge
2012-04-04 11:08 ` Roland Stigge
2012-04-07 3:53 ` Grant Likely
2012-04-07 3:53 ` Grant Likely
2012-04-07 13:50 ` Roland Stigge
2012-04-07 13:50 ` Roland Stigge
2012-04-07 14:19 ` Roland Stigge
2012-04-07 14:19 ` Roland Stigge
2012-04-07 17:17 ` jonsmirl at gmail.com
2012-04-07 17:17 ` jonsmirl
2012-04-07 17:45 ` Roland Stigge
2012-04-07 17:45 ` Roland Stigge
2012-04-07 18:54 ` jonsmirl at gmail.com
2012-04-07 18:54 ` jonsmirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204040848.39376.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.