All of lore.kernel.org
 help / color / mirror / Atom feed
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] gpio: Device tree support for LPC32xx
Date: Sat, 07 Apr 2012 16:19:04 +0200	[thread overview]
Message-ID: <4F804CD8.70803@antcom.de> (raw)
In-Reply-To: <4F80460E.50605@antcom.de>

On 07/04/12 15:50, Roland Stigge wrote:
> Hi Grant,
...

> Please consider how the groups are specified in
> drivers/gpio/gpio-lpc32xx.c. They each have different numbers of lines
> and GPIO / GPI / GPO functionality. So they also have different callback
> sets, and we need to do separate gpiochip_add()s which leads to the
> separate gpio-bank specifications in the dtsi file. Separate enabling of
> those banks via OF are a nice by-product.

And BTW: This also corresponds nicely with how the LPC32xx hardware
calls its GPIOs, e.g. GPO 3 for GPO #3 in the gpo group.

Thanks for considering,

Roland

WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: arm@kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linus.walleij@stericsson.com
Subject: Re: [PATCH v2] gpio: Device tree support for LPC32xx
Date: Sat, 07 Apr 2012 16:19:04 +0200	[thread overview]
Message-ID: <4F804CD8.70803@antcom.de> (raw)
In-Reply-To: <4F80460E.50605@antcom.de>

On 07/04/12 15:50, Roland Stigge wrote:
> Hi Grant,
...

> Please consider how the groups are specified in
> drivers/gpio/gpio-lpc32xx.c. They each have different numbers of lines
> and GPIO / GPI / GPO functionality. So they also have different callback
> sets, and we need to do separate gpiochip_add()s which leads to the
> separate gpio-bank specifications in the dtsi file. Separate enabling of
> those banks via OF are a nice by-product.

And BTW: This also corresponds nicely with how the LPC32xx hardware
calls its GPIOs, e.g. GPO 3 for GPO #3 in the gpo group.

Thanks for considering,

Roland

  reply	other threads:[~2012-04-07 14:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-03 23:58 [PATCH v2] gpio: Device tree support for LPC32xx Roland Stigge
2012-04-03 23:58 ` Roland Stigge
2012-04-04  8:48 ` Arnd Bergmann
2012-04-04  8:48   ` Arnd Bergmann
2012-04-04 11:08   ` Roland Stigge
2012-04-04 11:08     ` Roland Stigge
2012-04-07  3:53 ` Grant Likely
2012-04-07  3:53   ` Grant Likely
2012-04-07 13:50   ` Roland Stigge
2012-04-07 13:50     ` Roland Stigge
2012-04-07 14:19     ` Roland Stigge [this message]
2012-04-07 14:19       ` Roland Stigge
2012-04-07 17:17     ` jonsmirl at gmail.com
2012-04-07 17:17       ` jonsmirl
2012-04-07 17:45       ` Roland Stigge
2012-04-07 17:45         ` Roland Stigge
2012-04-07 18:54         ` jonsmirl at gmail.com
2012-04-07 18:54           ` jonsmirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F804CD8.70803@antcom.de \
    --to=stigge@antcom.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.