All of lore.kernel.org
 help / color / mirror / Atom feed
From: aisheng.dong@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: imx6q: switch to use pinctrl driver
Date: Mon, 16 Apr 2012 11:35:20 +0800	[thread overview]
Message-ID: <20120416033519.GA17173@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120415073751.GF24997@S2101-09.ap.freescale.net>

On Sun, Apr 15, 2012 at 03:37:54PM +0800, Shawn Guo wrote:
> On Sun, Apr 15, 2012 at 12:03:16PM +0800, Dong Aisheng wrote:
> ...
> > For MX3 and MX5, before their pinctrl driver are available, user may
> > need to define a dummy in dt to avoid such an error.
> > 
> That is insane, and will not work.
> 
> 1) We do not have device tree support for MX3 yet.
> 2) It's not practical to add dummy entries in dt to avoid the error.
> 3) There are still so many non-dt board files support in the tree.
> How will they work with that?
> 
> My suggestion is to not make it an error but a dev_dbg, assuming that
> the pins are already set up by platform code if we do not find the
> entry from pinctrl system.  We can take it as a transition solution,
> and turn the dev_dbg back to error when all the users of the device
> driver are converted to device tree.
> 
My thinking is let pinctrl core handle dummy state as regulator subsystem
and does not depend on dt.
Linus, Stephen, any comment?

Regards
Dong Aisheng

WARNING: multiple messages have this Message-ID (diff)
From: Dong Aisheng <aisheng.dong@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Dong Aisheng <dongas86@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linus.walleij@stericsson.com,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: imx6q: switch to use pinctrl driver
Date: Mon, 16 Apr 2012 11:35:20 +0800	[thread overview]
Message-ID: <20120416033519.GA17173@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120415073751.GF24997@S2101-09.ap.freescale.net>

On Sun, Apr 15, 2012 at 03:37:54PM +0800, Shawn Guo wrote:
> On Sun, Apr 15, 2012 at 12:03:16PM +0800, Dong Aisheng wrote:
> ...
> > For MX3 and MX5, before their pinctrl driver are available, user may
> > need to define a dummy in dt to avoid such an error.
> > 
> That is insane, and will not work.
> 
> 1) We do not have device tree support for MX3 yet.
> 2) It's not practical to add dummy entries in dt to avoid the error.
> 3) There are still so many non-dt board files support in the tree.
> How will they work with that?
> 
> My suggestion is to not make it an error but a dev_dbg, assuming that
> the pins are already set up by platform code if we do not find the
> entry from pinctrl system.  We can take it as a transition solution,
> and turn the dev_dbg back to error when all the users of the device
> driver are converted to device tree.
> 
My thinking is let pinctrl core handle dummy state as regulator subsystem
and does not depend on dt.
Linus, Stephen, any comment?

Regards
Dong Aisheng

WARNING: multiple messages have this Message-ID (diff)
From: Dong Aisheng <aisheng.dong@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Dong Aisheng <dongas86@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	<linus.walleij@stericsson.com>,
	<devicetree-discuss@lists.ozlabs.org>,
	<linux-kernel@vger.kernel.org>, <rob.herring@calxeda.com>,
	<kernel@pengutronix.de>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] ARM: imx6q: switch to use pinctrl driver
Date: Mon, 16 Apr 2012 11:35:20 +0800	[thread overview]
Message-ID: <20120416033519.GA17173@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120415073751.GF24997@S2101-09.ap.freescale.net>

On Sun, Apr 15, 2012 at 03:37:54PM +0800, Shawn Guo wrote:
> On Sun, Apr 15, 2012 at 12:03:16PM +0800, Dong Aisheng wrote:
> ...
> > For MX3 and MX5, before their pinctrl driver are available, user may
> > need to define a dummy in dt to avoid such an error.
> > 
> That is insane, and will not work.
> 
> 1) We do not have device tree support for MX3 yet.
> 2) It's not practical to add dummy entries in dt to avoid the error.
> 3) There are still so many non-dt board files support in the tree.
> How will they work with that?
> 
> My suggestion is to not make it an error but a dev_dbg, assuming that
> the pins are already set up by platform code if we do not find the
> entry from pinctrl system.  We can take it as a transition solution,
> and turn the dev_dbg back to error when all the users of the device
> driver are converted to device tree.
> 
My thinking is let pinctrl core handle dummy state as regulator subsystem
and does not depend on dt.
Linus, Stephen, any comment?

Regards
Dong Aisheng


  reply	other threads:[~2012-04-16  3:35 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 16:18 [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Dong Aisheng
2012-04-13 16:18 ` Dong Aisheng
2012-04-13 16:18 ` Dong Aisheng
2012-04-13 16:18 ` [PATCH 2/3] pinctrl: pinctrl-imx: add imx6q pinctrl driver Dong Aisheng
2012-04-13 16:18   ` Dong Aisheng
2012-04-17 20:12   ` Stephen Warren
2012-04-17 20:12     ` Stephen Warren
2012-04-18  3:40     ` Dong Aisheng
2012-04-18  3:40       ` Dong Aisheng
2012-04-13 16:18 ` [PATCH 3/3] ARM: imx6q: switch to use " Dong Aisheng
2012-04-13 16:18   ` Dong Aisheng
2012-04-13 16:18   ` Dong Aisheng
2012-04-14 13:53   ` Sascha Hauer
2012-04-14 13:53     ` Sascha Hauer
2012-04-15  4:03     ` Dong Aisheng
2012-04-15  4:03       ` Dong Aisheng
2012-04-15  7:37       ` Shawn Guo
2012-04-15  7:37         ` Shawn Guo
2012-04-15  7:37         ` Shawn Guo
2012-04-16  3:35         ` Dong Aisheng [this message]
2012-04-16  3:35           ` Dong Aisheng
2012-04-16  3:35           ` Dong Aisheng
2012-04-20  1:08           ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-20  1:08             ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-20  1:08             ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-24  8:23           ` Linus Walleij
2012-04-24  8:23             ` Linus Walleij
2012-04-24  8:46             ` Dong Aisheng
2012-04-24  8:46               ` Dong Aisheng
2012-04-24  8:46               ` Dong Aisheng
2012-04-17 20:23   ` Stephen Warren
2012-04-17 20:23     ` Stephen Warren
2012-04-13 18:17 ` [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Dong Aisheng
2012-04-13 18:17   ` Dong Aisheng
2012-04-14 13:48 ` Sascha Hauer
2012-04-14 13:48   ` Sascha Hauer
2012-04-14 13:48   ` Sascha Hauer
2012-04-15  3:49   ` Dong Aisheng
2012-04-15  3:49     ` Dong Aisheng
2012-04-15 14:17     ` Shawn Guo
2012-04-15 14:17       ` Shawn Guo
2012-04-15 14:45       ` Sascha Hauer
2012-04-15 14:45         ` Sascha Hauer
2012-04-15 17:29       ` Sascha Hauer
2012-04-15 17:29         ` Sascha Hauer
2012-04-16  1:47         ` Shawn Guo
2012-04-16  1:47           ` Shawn Guo
2012-04-16  1:47           ` Shawn Guo
2012-04-16 18:01           ` Stephen Warren
2012-04-16 18:01             ` Stephen Warren
2012-04-16  3:47       ` Dong Aisheng
2012-04-16  3:47         ` Dong Aisheng
2012-04-16  3:47         ` Dong Aisheng
2012-04-16  3:46         ` Shawn Guo
2012-04-16  3:46           ` Shawn Guo
2012-04-17  9:57           ` Dong Aisheng
2012-04-17  9:57             ` Dong Aisheng
2012-04-17 12:30             ` Sascha Hauer
2012-04-17 12:30               ` Sascha Hauer
2012-04-18  3:38               ` Dong Aisheng
2012-04-18  3:38                 ` Dong Aisheng
2012-04-17 20:58 ` Stephen Warren
2012-04-17 20:58   ` Stephen Warren
2012-04-18  7:19   ` Dong Aisheng
2012-04-18  7:19     ` Dong Aisheng
2012-04-18 18:06     ` Stephen Warren
2012-04-18 18:06       ` Stephen Warren
2012-04-19 15:28 ` Shawn Guo
2012-04-19 15:28   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120416033519.GA17173@shlinux2.ap.freescale.net \
    --to=aisheng.dong@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.