From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
"cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>,
Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH v1 0/7] memcg remove pre_destroy
Date: Mon, 16 Apr 2012 15:41:18 -0700 [thread overview]
Message-ID: <20120416224118.GG12421@google.com> (raw)
In-Reply-To: <4F86B9BE.8000105-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Hello, KAMEZAWA.
On Thu, Apr 12, 2012 at 08:17:18PM +0900, KAMEZAWA Hiroyuki wrote:
> In recent discussion, Tejun Heo, cgroup maintainer, has a plan to remove
> ->pre_destroy(). And now, in cgroup tree, pre_destroy() failure cause WARNING.
I did a pretty shallow review of the patchset and other than the
unnecessary async destruction, my complaints are mostly trivial. Ooh,
and the patchset doesn't apply cleanly on top of cgroup/for-3.5.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-3.5
Thank you!
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Glauber Costa <glommer@parallels.com>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 0/7] memcg remove pre_destroy
Date: Mon, 16 Apr 2012 15:41:18 -0700 [thread overview]
Message-ID: <20120416224118.GG12421@google.com> (raw)
In-Reply-To: <4F86B9BE.8000105@jp.fujitsu.com>
Hello, KAMEZAWA.
On Thu, Apr 12, 2012 at 08:17:18PM +0900, KAMEZAWA Hiroyuki wrote:
> In recent discussion, Tejun Heo, cgroup maintainer, has a plan to remove
> ->pre_destroy(). And now, in cgroup tree, pre_destroy() failure cause WARNING.
I did a pretty shallow review of the patchset and other than the
unnecessary async destruction, my complaints are mostly trivial. Ooh,
and the patchset doesn't apply cleanly on top of cgroup/for-3.5.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-3.5
Thank you!
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-16 22:41 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 11:17 [PATCH v1 0/7] memcg remove pre_destroy KAMEZAWA Hiroyuki
[not found] ` <4F86B9BE.8000105-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-12 11:20 ` [PATCH 1/7] res_counter: add a function res_counter_move_parent() KAMEZAWA Hiroyuki
2012-04-12 11:20 ` KAMEZAWA Hiroyuki
2012-04-12 13:22 ` Glauber Costa
2012-04-12 14:30 ` Frederic Weisbecker
[not found] ` <CAFTL4hyKOkoTv=717MkYx4QB0j3B6xA0ZPp1jg6HkrtTkAu7nQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-13 0:57 ` KAMEZAWA Hiroyuki
2012-04-13 0:57 ` KAMEZAWA Hiroyuki
[not found] ` <4F8779DF.3080307-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-13 1:04 ` Frederic Weisbecker
2012-04-13 1:04 ` Frederic Weisbecker
2012-04-13 1:05 ` KAMEZAWA Hiroyuki
[not found] ` <4F86BA66.2010503-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-16 22:19 ` Tejun Heo
2012-04-16 22:19 ` Tejun Heo
[not found] ` <20120416221924.GB12421-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-18 6:59 ` KAMEZAWA Hiroyuki
2012-04-18 6:59 ` KAMEZAWA Hiroyuki
2012-04-16 22:31 ` Tejun Heo
[not found] ` <20120416223157.GE12421-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-18 7:04 ` KAMEZAWA Hiroyuki
2012-04-18 7:04 ` KAMEZAWA Hiroyuki
[not found] ` <4F8E678A.8000805-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-18 17:03 ` Tejun Heo
2012-04-18 17:03 ` Tejun Heo
2012-04-12 11:21 ` [PATCH 2/7] memcg: move charge to parent only when necessary KAMEZAWA Hiroyuki
2012-04-12 11:21 ` KAMEZAWA Hiroyuki
[not found] ` <4F86BAB0.5030809-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-16 22:21 ` Tejun Heo
2012-04-16 22:21 ` Tejun Heo
[not found] ` <20120416222119.GC12421-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-18 7:01 ` KAMEZAWA Hiroyuki
2012-04-18 7:01 ` KAMEZAWA Hiroyuki
2012-04-12 11:22 ` [PATCH 3/7] memcg: move charges to root at rmdir() KAMEZAWA Hiroyuki
2012-04-12 11:22 ` KAMEZAWA Hiroyuki
[not found] ` <4F86BB02.2060607-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-16 22:30 ` Tejun Heo
2012-04-16 22:30 ` Tejun Heo
2012-04-18 7:02 ` KAMEZAWA Hiroyuki
2012-04-12 11:24 ` [PATCH 4/7] memcg: remove 'uncharge' argument from mem_cgroup_move_account() KAMEZAWA Hiroyuki
2012-04-12 11:24 ` KAMEZAWA Hiroyuki
2012-04-12 13:27 ` Glauber Costa
2012-04-13 1:01 ` KAMEZAWA Hiroyuki
2012-04-12 11:28 ` [PATCH 5/7] memcg: divide force_empty into 2 functions, avoid memory reclaim at rmdir KAMEZAWA Hiroyuki
2012-04-12 11:28 ` KAMEZAWA Hiroyuki
2012-04-12 13:33 ` Glauber Costa
2012-04-17 17:29 ` Ying Han
[not found] ` <CALWz4iwYX4r5dJmcKFuc+zj_rjMB76dtpbvArdzySF+dyxMohg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-18 7:14 ` KAMEZAWA Hiroyuki
2012-04-18 7:14 ` KAMEZAWA Hiroyuki
2012-04-12 11:30 ` [PATCH 6/7] memcg: remove pre_destroy() KAMEZAWA Hiroyuki
2012-04-12 11:30 ` KAMEZAWA Hiroyuki
2012-04-16 22:38 ` Tejun Heo
[not found] ` <20120416223800.GF12421-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-18 7:12 ` KAMEZAWA Hiroyuki
2012-04-18 7:12 ` KAMEZAWA Hiroyuki
[not found] ` <4F86BCCE.5050802-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-17 17:47 ` Ying Han
2012-04-17 17:47 ` Ying Han
2012-04-12 11:31 ` [PATCH 7/7] memcg: remove drain_all_stock_sync KAMEZAWA Hiroyuki
2012-04-12 11:31 ` KAMEZAWA Hiroyuki
[not found] ` <4F86BD18.4010505-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-12 13:35 ` Glauber Costa
2012-04-12 13:35 ` Glauber Costa
2012-04-12 13:20 ` [PATCH v1 0/7] memcg remove pre_destroy Glauber Costa
2012-04-12 13:20 ` Glauber Costa
2012-04-12 16:06 ` Tejun Heo
2012-04-12 16:06 ` Tejun Heo
[not found] ` <20120412160642.GA13069-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-12 18:57 ` Aneesh Kumar K.V
2012-04-12 18:57 ` Aneesh Kumar K.V
2012-04-12 23:59 ` KAMEZAWA Hiroyuki
[not found] ` <4F876C70.7060600-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-13 8:50 ` Michal Hocko
2012-04-13 8:50 ` Michal Hocko
[not found] ` <20120413085014.GA9205-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-04-13 22:19 ` Aneesh Kumar K.V
2012-04-13 22:19 ` Aneesh Kumar K.V
2012-04-16 22:41 ` Tejun Heo [this message]
2012-04-16 22:41 ` Tejun Heo
2012-04-17 17:35 ` Ying Han
[not found] ` <CALWz4izGo4aCyC7xbWyL+yfNiaUmZXPwD8bLgJVpqtcAGfyJ9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-18 7:15 ` KAMEZAWA Hiroyuki
2012-04-18 7:15 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416224118.GG12421@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.