From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: lrg <lrg@ti.com>, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM
Date: Tue, 17 Apr 2012 14:43:52 +0100 [thread overview]
Message-ID: <20120417134351.GD6652@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334666046.32225.8.camel@matrix>
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
On Tue, Apr 17, 2012 at 06:04:06PM +0530, Ashish Chavan wrote:
> + /* Search pll div array for correct divisors */
> + for (cnt = 0; cnt < ARRAY_SIZE(da7210_pll_div); cnt++) {
> + /* check fref */
> + if (fref == da7210_pll_div[cnt].fref) {
> + /* check mode */
> + if (da7210->master == da7210_pll_div[cnt].mode) {
> + /* check fout */
> + if (fout == da7210_pll_div[cnt].fout) {
I've applied but this would be a lot clearer if it were writen as a
single if statement with &&s.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-17 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 12:34 [PATCH v2] ASoC: da7210: Add support for PLL and SRM Ashish Chavan
2012-04-17 13:43 ` Mark Brown [this message]
2012-04-17 14:21 ` Ashish Chavan
2012-04-17 14:11 ` Mark Brown
2012-04-17 14:11 ` [alsa-devel] " Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-01-23 10:07 Ashish Chavan
2012-01-23 11:21 ` [alsa-devel] " Mark Brown
2012-01-23 12:09 ` Ashish Chavan
2012-01-23 12:03 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417134351.GD6652@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.