From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
alsa-devel <alsa-devel@alsa-project.org>, lrg <lrg@ti.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH v2] ASoC: da7210: Add support for PLL and SRM
Date: Mon, 23 Jan 2012 12:03:14 +0000 [thread overview]
Message-ID: <20120123120313.GC29465@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1327320561.31594.23.camel@matrix>
On Mon, Jan 23, 2012 at 05:39:21PM +0530, Ashish Chavan wrote:
> On Mon, 2012-01-23 at 11:21 +0000, Mark Brown wrote:
> > On Mon, Jan 23, 2012 at 03:37:21PM +0530, Ashish Chavan wrote:
> > ...this code is shared between both branches (as well as the SRM case)
> > and should be factored out between them.
> We are picking values from three different tables in three cases. Even
> if we factor out this code, we will need a switch or if-else to identify
> correct table. As we are already checking those conditions, I put the
> code there. Can you please elaborate a bit, in case if I misunderstood
> your point?
The only difference between these relatively large chunks of code is the
table that's being referenced. Either use a single table or factor
things out so that you're sharing all the code that doesn't pick the
table.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: lrg <lrg@ti.com>, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM
Date: Mon, 23 Jan 2012 12:03:14 +0000 [thread overview]
Message-ID: <20120123120313.GC29465@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1327320561.31594.23.camel@matrix>
On Mon, Jan 23, 2012 at 05:39:21PM +0530, Ashish Chavan wrote:
> On Mon, 2012-01-23 at 11:21 +0000, Mark Brown wrote:
> > On Mon, Jan 23, 2012 at 03:37:21PM +0530, Ashish Chavan wrote:
> > ...this code is shared between both branches (as well as the SRM case)
> > and should be factored out between them.
> We are picking values from three different tables in three cases. Even
> if we factor out this code, we will need a switch or if-else to identify
> correct table. As we are already checking those conditions, I put the
> code there. Can you please elaborate a bit, in case if I misunderstood
> your point?
The only difference between these relatively large chunks of code is the
table that's being referenced. Either use a single table or factor
things out so that you're sharing all the code that doesn't pick the
table.
next prev parent reply other threads:[~2012-01-23 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 10:07 [PATCH v2] ASoC: da7210: Add support for PLL and SRM Ashish Chavan
2012-01-23 11:21 ` [alsa-devel] " Mark Brown
2012-01-23 12:09 ` Ashish Chavan
2012-01-23 12:03 ` Mark Brown [this message]
2012-01-23 12:03 ` [alsa-devel] " Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-04-17 12:34 Ashish Chavan
2012-04-17 13:43 ` [alsa-devel] " Mark Brown
2012-04-17 14:21 ` Ashish Chavan
2012-04-17 14:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123120313.GC29465@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.