From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
alsa-devel <alsa-devel@alsa-project.org>, lrg <lrg@ti.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH v2] ASoC: da7210: Add support for PLL and SRM
Date: Tue, 17 Apr 2012 15:11:28 +0100 [thread overview]
Message-ID: <20120417141128.GG6652@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334672460.13279.3.camel@matrix>
[-- Attachment #1.1: Type: text/plain, Size: 595 bytes --]
On Tue, Apr 17, 2012 at 07:51:00PM +0530, Ashish Chavan wrote:
> On Tue, 2012-04-17 at 14:43 +0100, Mark Brown wrote:
> > I've applied but this would be a lot clearer if it were writen as a
> > single if statement with &&s.
> Actually I implemented it like that first. But then realized that
> because of the 80 chars limit and long conditions, readability was
> hampered. Let me submit a patch to convert it to single if, if that is
> preferred way of doing it.
Hrm? The major problem with multiple if statements is that it introduces
massive levels of indentation which are hard to parse.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: lrg <lrg@ti.com>, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM
Date: Tue, 17 Apr 2012 15:11:28 +0100 [thread overview]
Message-ID: <20120417141128.GG6652@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334672460.13279.3.camel@matrix>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Tue, Apr 17, 2012 at 07:51:00PM +0530, Ashish Chavan wrote:
> On Tue, 2012-04-17 at 14:43 +0100, Mark Brown wrote:
> > I've applied but this would be a lot clearer if it were writen as a
> > single if statement with &&s.
> Actually I implemented it like that first. But then realized that
> because of the 80 chars limit and long conditions, readability was
> hampered. Let me submit a patch to convert it to single if, if that is
> preferred way of doing it.
Hrm? The major problem with multiple if statements is that it introduces
massive levels of indentation which are hard to parse.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-17 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 12:34 [PATCH v2] ASoC: da7210: Add support for PLL and SRM Ashish Chavan
2012-04-17 13:43 ` [alsa-devel] " Mark Brown
2012-04-17 14:21 ` Ashish Chavan
2012-04-17 14:11 ` Mark Brown [this message]
2012-04-17 14:11 ` [alsa-devel] " Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-01-23 10:07 Ashish Chavan
2012-01-23 11:21 ` [alsa-devel] " Mark Brown
2012-01-23 12:09 ` Ashish Chavan
2012-01-23 12:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417141128.GG6652@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.