From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/12] leds-atmel-pwm.c: Make pwmled_probe() __devinit
Date: Fri, 20 Apr 2012 14:34:27 -0700 [thread overview]
Message-ID: <20120420143427.97c08ee5.akpm@linux-foundation.org> (raw)
In-Reply-To: <23f8dba8a3e1ae21a5953747b63dc0a21fcba868.1334567594.git.nicolas.ferre@atmel.com>
On Mon, 16 Apr 2012 11:20:54 +0200
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> Commit 892a884 (leds: convert led platform drivers to module_platform_driver)
> is omitting the section mismatch error: so change annotation of the probe
> function to __devinit instead of __init.
>
> ...
>
> --- a/drivers/leds/leds-atmel-pwm.c
> +++ b/drivers/leds/leds-atmel-pwm.c
> @@ -35,7 +35,7 @@ static void pwmled_brightness(struct led_classdev *cdev, enum led_brightness b)
> * NOTE: we reuse the platform_data structure of GPIO leds,
> * but repurpose its "gpio" number as a PWM channel number.
> */
> -static int __init pwmled_probe(struct platform_device *pdev)
> +static int __devinit pwmled_probe(struct platform_device *pdev)
> {
> const struct gpio_led_platform_data *pdata;
> struct pwmled *leds;
This is theoretically oopsable and the patch is probably needed in 3.4
and 3.3.x.
But you've applied it to linu-next via your own tree so I won't be
merging it.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
olof@lixom.net, plagnioj@jcrosoft.com,
ludovic.desroches@atmel.com, linux-kernel@vger.kernel.org,
Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [PATCH 10/12] leds-atmel-pwm.c: Make pwmled_probe() __devinit
Date: Fri, 20 Apr 2012 14:34:27 -0700 [thread overview]
Message-ID: <20120420143427.97c08ee5.akpm@linux-foundation.org> (raw)
In-Reply-To: <23f8dba8a3e1ae21a5953747b63dc0a21fcba868.1334567594.git.nicolas.ferre@atmel.com>
On Mon, 16 Apr 2012 11:20:54 +0200
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> Commit 892a884 (leds: convert led platform drivers to module_platform_driver)
> is omitting the section mismatch error: so change annotation of the probe
> function to __devinit instead of __init.
>
> ...
>
> --- a/drivers/leds/leds-atmel-pwm.c
> +++ b/drivers/leds/leds-atmel-pwm.c
> @@ -35,7 +35,7 @@ static void pwmled_brightness(struct led_classdev *cdev, enum led_brightness b)
> * NOTE: we reuse the platform_data structure of GPIO leds,
> * but repurpose its "gpio" number as a PWM channel number.
> */
> -static int __init pwmled_probe(struct platform_device *pdev)
> +static int __devinit pwmled_probe(struct platform_device *pdev)
> {
> const struct gpio_led_platform_data *pdata;
> struct pwmled *leds;
This is theoretically oopsable and the patch is probably needed in 3.4
and 3.3.x.
But you've applied it to linu-next via your own tree so I won't be
merging it.
next prev parent reply other threads:[~2012-04-20 21:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 9:20 [PATCH 00/12] at91: 3.4-rc3 fixes Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 01/12] ARM: at91: Export at91_st_base Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 02/12] ARM: at91: Export at91_ramc_base Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 03/12] ARM: at91: Export at91_pmc_base Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 04/12] ARM: at91: Export at91_matrix_base Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 05/12] ARM: at91: fix typo in at91_pmc_base assembly declaration Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 06/12] ARM: at91: remove empty at91_init_serial function Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 07/12] ARM: at91: fix rm9200ek flash size Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 08/12] ARM: at91: fix at91sam9261ek Ethernet dm9000 irq Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 09/12] ARM: at91/atmel-mci: remove unused setup_dma_addr() macro Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 10/12] leds-atmel-pwm.c: Make pwmled_probe() __devinit Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-20 21:34 ` Andrew Morton [this message]
2012-04-20 21:34 ` Andrew Morton
2012-04-23 8:21 ` Nicolas Ferre
2012-04-23 8:21 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 11/12] USB: ohci-at91: change annotations for probe/remove functions Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-17 12:41 ` Nicolas Ferre
2012-04-17 12:41 ` Nicolas Ferre
2012-04-17 14:24 ` Alan Stern
2012-04-17 14:24 ` Alan Stern
2012-04-16 9:20 ` [PATCH 12/12] USB: gadget/at91_udc: add gpio_to_irq() function to vbus interrupt Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:22 ` Felipe Balbi
2012-04-16 9:22 ` Felipe Balbi
2012-04-16 10:46 ` [PATCH 13/13] dmaengine: Kconfig: fix Atmel at_hdmac entry Nicolas Ferre
2012-04-16 10:46 ` Nicolas Ferre
2012-04-16 15:40 ` [PATCH 00/12] at91: 3.4-rc3 fixes Arnd Bergmann
2012-04-16 15:40 ` Arnd Bergmann
2012-04-16 15:52 ` Nicolas Ferre
2012-04-16 15:52 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420143427.97c08ee5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.