From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/12] at91: 3.4-rc3 fixes
Date: Mon, 16 Apr 2012 17:52:19 +0200 [thread overview]
Message-ID: <4F8C4033.2050600@atmel.com> (raw)
In-Reply-To: <201204161540.08389.arnd@arndb.de>
On 04/16/2012 05:40 PM, Arnd Bergmann :
> On Monday 16 April 2012, Nicolas Ferre wrote:
>> Here is another fixes series for AT91 that will go on top of 3.4-rc3.
>> We experienced some issues while compiling some drivers as modules: Joachim has
>> corrected several of them. We may reduce this number of exported values by
>> reworking some drivers, in the future.
>> Some drivers are also modified here, I would like to keep them in the series
>> as the modifications are really related with our recent move to irqdomains or
>> simply related with compiler annotations.
>
> I looked at all the patches, they look good to me, but patch 9 does not
> seem to be an actual bug-fix rather than a cleanup, so you might want
> to put that into a different series.
Yes, it is dead code that can go in a cleanup series for 3.5...
I can remove it and build a "pull request" tomorrow.
Thanks for this review Arnd.
Cheers,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: olof@lixom.net, ludovic.desroches@atmel.com,
plagnioj@jcrosoft.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/12] at91: 3.4-rc3 fixes
Date: Mon, 16 Apr 2012 17:52:19 +0200 [thread overview]
Message-ID: <4F8C4033.2050600@atmel.com> (raw)
In-Reply-To: <201204161540.08389.arnd@arndb.de>
On 04/16/2012 05:40 PM, Arnd Bergmann :
> On Monday 16 April 2012, Nicolas Ferre wrote:
>> Here is another fixes series for AT91 that will go on top of 3.4-rc3.
>> We experienced some issues while compiling some drivers as modules: Joachim has
>> corrected several of them. We may reduce this number of exported values by
>> reworking some drivers, in the future.
>> Some drivers are also modified here, I would like to keep them in the series
>> as the modifications are really related with our recent move to irqdomains or
>> simply related with compiler annotations.
>
> I looked at all the patches, they look good to me, but patch 9 does not
> seem to be an actual bug-fix rather than a cleanup, so you might want
> to put that into a different series.
Yes, it is dead code that can go in a cleanup series for 3.5...
I can remove it and build a "pull request" tomorrow.
Thanks for this review Arnd.
Cheers,
--
Nicolas Ferre
next prev parent reply other threads:[~2012-04-16 15:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 9:20 [PATCH 00/12] at91: 3.4-rc3 fixes Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 01/12] ARM: at91: Export at91_st_base Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 02/12] ARM: at91: Export at91_ramc_base Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 03/12] ARM: at91: Export at91_pmc_base Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 04/12] ARM: at91: Export at91_matrix_base Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 05/12] ARM: at91: fix typo in at91_pmc_base assembly declaration Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 06/12] ARM: at91: remove empty at91_init_serial function Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 07/12] ARM: at91: fix rm9200ek flash size Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 08/12] ARM: at91: fix at91sam9261ek Ethernet dm9000 irq Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 09/12] ARM: at91/atmel-mci: remove unused setup_dma_addr() macro Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 10/12] leds-atmel-pwm.c: Make pwmled_probe() __devinit Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-20 21:34 ` Andrew Morton
2012-04-20 21:34 ` Andrew Morton
2012-04-23 8:21 ` Nicolas Ferre
2012-04-23 8:21 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 11/12] USB: ohci-at91: change annotations for probe/remove functions Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-17 12:41 ` Nicolas Ferre
2012-04-17 12:41 ` Nicolas Ferre
2012-04-17 14:24 ` Alan Stern
2012-04-17 14:24 ` Alan Stern
2012-04-16 9:20 ` [PATCH 12/12] USB: gadget/at91_udc: add gpio_to_irq() function to vbus interrupt Nicolas Ferre
2012-04-16 9:20 ` Nicolas Ferre
2012-04-16 9:22 ` Felipe Balbi
2012-04-16 9:22 ` Felipe Balbi
2012-04-16 10:46 ` [PATCH 13/13] dmaengine: Kconfig: fix Atmel at_hdmac entry Nicolas Ferre
2012-04-16 10:46 ` Nicolas Ferre
2012-04-16 15:40 ` [PATCH 00/12] at91: 3.4-rc3 fixes Arnd Bergmann
2012-04-16 15:40 ` Arnd Bergmann
2012-04-16 15:52 ` Nicolas Ferre [this message]
2012-04-16 15:52 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8C4033.2050600@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.