All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: R Sricharan <r.sricharan@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	santosh.shilimkar@ti.com, b-cousson@ti.com
Subject: Re: [PATCH 12/13] ARM: OMAP5: Add the build support
Date: Fri, 4 May 2012 15:58:58 -0700	[thread overview]
Message-ID: <20120504225857.GB5613@atomide.com> (raw)
In-Reply-To: <1336029982-31898-13-git-send-email-r.sricharan@ti.com>

* R Sricharan <r.sricharan@ti.com> [120503 00:30]:
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -9,7 +9,7 @@ config ARCH_OMAP2PLUS_TYPICAL
>  	select REGULATOR
>  	select PM_RUNTIME
>  	select VFP
> -	select NEON if ARCH_OMAP3 || ARCH_OMAP4
> +	select NEON if ARCH_OMAP3 || ARCH_OMAP4 || ARCH_OMAP5
>  	select SERIAL_OMAP
>  	select SERIAL_OMAP_CONSOLE
>  	select I2C

If we add CONFIG_SOC_OMAP3PLUS and CONFIG_SOC_OMAP4PLUS, then
this becomes more future proof with select NEON if SOC_OMAP3PLUS.

> @@ -55,6 +55,13 @@ config ARCH_OMAP4
>  	select USB_ARCH_HAS_EHCI if USB_SUPPORT
>  	select ARM_CPU_SUSPEND if PM
>  
> +config ARCH_OMAP5
> +	bool "TI OMAP5"
> +	depends on ARCH_OMAP2PLUS
> +	select CPU_V7
> +	select ARM_GIC
> +	select HAVE_SMP

No need to have depends on ARCH_OMAP2PLUS, it's all inside
if ARCH_OMAP2PLUS anyways. I removed those already once, but that
had to be reverted because the patch was doing other things too
that did not work out too well..

> @@ -343,6 +350,10 @@ config MACH_OMAP4_PANDA
>  	select OMAP_PACKAGE_CBS
>  	select REGULATOR_FIXED_VOLTAGE if REGULATOR
>  
> +config MACH_OMAP5_SEVM
> +	bool "OMAP5 sevm Board"
> +	depends on ARCH_OMAP5
> +
>  config OMAP3_EMU
>  	bool "OMAP3 debugging peripherals"
>  	depends on ARCH_OMAP3

No need for it here either. Actually, I think this whole chunk
can be now left out since it's DT based?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 12/13] ARM: OMAP5: Add the build support
Date: Fri, 4 May 2012 15:58:58 -0700	[thread overview]
Message-ID: <20120504225857.GB5613@atomide.com> (raw)
In-Reply-To: <1336029982-31898-13-git-send-email-r.sricharan@ti.com>

* R Sricharan <r.sricharan@ti.com> [120503 00:30]:
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -9,7 +9,7 @@ config ARCH_OMAP2PLUS_TYPICAL
>  	select REGULATOR
>  	select PM_RUNTIME
>  	select VFP
> -	select NEON if ARCH_OMAP3 || ARCH_OMAP4
> +	select NEON if ARCH_OMAP3 || ARCH_OMAP4 || ARCH_OMAP5
>  	select SERIAL_OMAP
>  	select SERIAL_OMAP_CONSOLE
>  	select I2C

If we add CONFIG_SOC_OMAP3PLUS and CONFIG_SOC_OMAP4PLUS, then
this becomes more future proof with select NEON if SOC_OMAP3PLUS.

> @@ -55,6 +55,13 @@ config ARCH_OMAP4
>  	select USB_ARCH_HAS_EHCI if USB_SUPPORT
>  	select ARM_CPU_SUSPEND if PM
>  
> +config ARCH_OMAP5
> +	bool "TI OMAP5"
> +	depends on ARCH_OMAP2PLUS
> +	select CPU_V7
> +	select ARM_GIC
> +	select HAVE_SMP

No need to have depends on ARCH_OMAP2PLUS, it's all inside
if ARCH_OMAP2PLUS anyways. I removed those already once, but that
had to be reverted because the patch was doing other things too
that did not work out too well..

> @@ -343,6 +350,10 @@ config MACH_OMAP4_PANDA
>  	select OMAP_PACKAGE_CBS
>  	select REGULATOR_FIXED_VOLTAGE if REGULATOR
>  
> +config MACH_OMAP5_SEVM
> +	bool "OMAP5 sevm Board"
> +	depends on ARCH_OMAP5
> +
>  config OMAP3_EMU
>  	bool "OMAP3 debugging peripherals"
>  	depends on ARCH_OMAP3

No need for it here either. Actually, I think this whole chunk
can be now left out since it's DT based?

Regards,

Tony

  reply	other threads:[~2012-05-04 22:59 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03  7:26 [PATCH 00/13] ARM: OMAP5: Add minimal OMAP5 SOC support R Sricharan
2012-05-03  7:26 ` R Sricharan
2012-05-03  7:26 ` [PATCH 01/13] ARM: OMAP5: id: Add cpu id for ES versions R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-10 11:18   ` Roger Quadros
2012-05-10 11:18     ` Roger Quadros
2012-05-10 11:22     ` R, Sricharan
2012-05-10 11:22       ` R, Sricharan
2012-05-10 13:06   ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-10 13:06     ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-10 13:15     ` R, Sricharan
2012-05-10 13:15       ` R, Sricharan
2012-05-03  7:26 ` [PATCH 02/13] ARM: OMAP5: Add minimal support for OMAP5430 SOC R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-04 22:39   ` Tony Lindgren
2012-05-04 22:39     ` Tony Lindgren
2012-05-04 22:47     ` Tony Lindgren
2012-05-04 22:47       ` Tony Lindgren
2012-05-06  7:36     ` R, Sricharan
2012-05-06  7:36       ` R, Sricharan
2012-05-07 17:33       ` Tony Lindgren
2012-05-07 17:33         ` Tony Lindgren
2012-05-09  9:06         ` R, Sricharan
2012-05-09  9:06           ` R, Sricharan
2012-05-09 16:00           ` Tony Lindgren
2012-05-09 16:00             ` Tony Lindgren
2012-05-10  9:49             ` R, Sricharan
2012-05-10  9:49               ` R, Sricharan
2012-05-07 19:07     ` Paul Walmsley
2012-05-07 19:07       ` Paul Walmsley
2012-05-07 19:18       ` Tony Lindgren
2012-05-07 19:18         ` Tony Lindgren
2012-05-07 19:35         ` Tony Lindgren
2012-05-07 19:35           ` Tony Lindgren
2012-05-08  5:32           ` Paul Walmsley
2012-05-08  5:32             ` Paul Walmsley
2012-05-08  5:49           ` Hiremath, Vaibhav
2012-05-08  5:49             ` Hiremath, Vaibhav
2012-05-08 15:48             ` Tony Lindgren
2012-05-08 15:48               ` Tony Lindgren
2012-05-08 17:00               ` Hiremath, Vaibhav
2012-05-08 17:00                 ` Hiremath, Vaibhav
2012-05-08 19:07                 ` Tony Lindgren
2012-05-08 19:07                   ` Tony Lindgren
2012-05-08  5:31         ` Paul Walmsley
2012-05-08  5:31           ` Paul Walmsley
2012-05-08 15:47           ` Tony Lindgren
2012-05-08 15:47             ` Tony Lindgren
2012-05-10 11:58   ` Roger Quadros
2012-05-10 11:58     ` Roger Quadros
2012-05-03  7:26 ` [PATCH 03/13] TEMP: ARM: OMAP5: Add cpu_is_omap54xx() checks R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-03  7:26 ` [PATCH 04/13] ARM: OMAP5: timer: Add clocksource, clockevent support R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-03  7:26 ` [PATCH 05/13] TEMP: ARM: OMAP5: Update the base address of the 32k-counter R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-03  7:26 ` [PATCH 06/13] ARM: OMAP5: gpmc: Update gpmc_init() R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-03  7:26 ` [PATCH 07/13] ARM: OMAP5: l3: Add l3 error handler support for omap5 R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-04 22:51   ` Tony Lindgren
2012-05-04 22:51     ` Tony Lindgren
2012-05-06  7:38     ` R, Sricharan
2012-05-06  7:38       ` R, Sricharan
2012-05-07 17:34       ` Tony Lindgren
2012-05-07 17:34         ` Tony Lindgren
2012-05-08  6:04         ` R, Sricharan
2012-05-08  6:04           ` R, Sricharan
2012-05-03  7:26 ` [PATCH 08/13] ARM: OMAP5: Add the WakeupGen IP updates R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-04 22:55   ` Tony Lindgren
2012-05-04 22:55     ` Tony Lindgren
2012-05-07  9:06     ` Santosh Shilimkar
2012-05-07  9:06       ` Santosh Shilimkar
2012-05-10 11:36   ` Roger Quadros
2012-05-10 11:36     ` Roger Quadros
2012-05-10 11:42     ` Shilimkar, Santosh
2012-05-10 11:42       ` Shilimkar, Santosh
2012-05-10 11:48       ` Roger Quadros
2012-05-10 11:48         ` Roger Quadros
2012-05-10 11:52         ` Santosh Shilimkar
2012-05-10 11:52           ` Santosh Shilimkar
2012-05-03  7:26 ` [PATCH 09/13] ARM: OMAP5: Add SMP support R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-08 12:47   ` Will Deacon
2012-05-08 12:47     ` Will Deacon
2012-05-08 13:00     ` Santosh Shilimkar
2012-05-08 13:00       ` Santosh Shilimkar
2012-05-03  7:26 ` [PATCH 10/13] ARM: OMAP5: board-generic: Add device tree support R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-07 13:27   ` Cousson, Benoit
2012-05-07 13:27     ` Cousson, Benoit
2012-05-07 14:08     ` R, Sricharan
2012-05-07 14:08       ` R, Sricharan
2012-05-07 17:35       ` Tony Lindgren
2012-05-07 17:35         ` Tony Lindgren
2012-05-03  7:26 ` [PATCH 11/13] arm/dts: OMAP5: Add omap5 dts files R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-03  7:26 ` [PATCH 12/13] ARM: OMAP5: Add the build support R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-04 22:58   ` Tony Lindgren [this message]
2012-05-04 22:58     ` Tony Lindgren
2012-05-07  3:35     ` R, Sricharan
2012-05-07  3:35       ` R, Sricharan
2012-05-07 17:37       ` Tony Lindgren
2012-05-07 17:37         ` Tony Lindgren
2012-05-08  9:19         ` Cousson, Benoit
2012-05-08  9:19           ` Cousson, Benoit
2012-05-08 15:57           ` Tony Lindgren
2012-05-08 15:57             ` Tony Lindgren
2012-05-03  7:26 ` [PATCH 13/13] ARM: Kconfig update to support additional GPIOs in OMAP5 R Sricharan
2012-05-03  7:26   ` R Sricharan
2012-05-07  9:49 ` [PATCH 00/13] ARM: OMAP5: Add minimal OMAP5 SOC support Santosh Shilimkar
2012-05-07  9:49   ` Santosh Shilimkar
2012-05-07 22:26   ` Tony Lindgren
2012-05-07 22:26     ` Tony Lindgren
2012-05-08  7:24     ` Santosh Shilimkar
2012-05-08  7:24       ` Santosh Shilimkar
2012-05-08 15:58       ` Tony Lindgren
2012-05-08 15:58         ` Tony Lindgren
2012-05-10 17:43 ` Sricharan R
2012-05-10 17:43   ` Sricharan R
2012-05-11 20:11   ` Tony Lindgren
2012-05-11 20:11     ` Tony Lindgren
2012-05-14  4:50     ` R, Sricharan
2012-05-14  4:50       ` R, Sricharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120504225857.GB5613@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=r.sricharan@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.