From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"balbi-l0cyMroinI0@public.gmane.org"
<balbi-l0cyMroinI0@public.gmane.org>,
"grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org"
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
"rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org"
<rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
"ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org"
<ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
"olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org"
<olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
"gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org"
<ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
"linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
"myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
<myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-doc-fy+rA21nqHI@public.gmane.org>
Subject: Re: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
Date: Mon, 7 May 2012 08:59:28 +0000 [thread overview]
Message-ID: <201205070859.29174.arnd@arndb.de> (raw)
In-Reply-To: <20120507.105254.1899925115243585929.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Monday 07 May 2012, Hiroshi Doyu wrote:
> > On Mon, May 07, 2012 at 09:43:45AM +0300, Hiroshi DOYU wrote:
> > > diff --git a/drivers/Makefile b/drivers/Makefile
> > > index 5870322..d97e2e2 100644
> > > --- a/drivers/Makefile
> > > +++ b/drivers/Makefile
> > > @@ -18,7 +18,7 @@ obj-$(CONFIG_SFI) += sfi/
> > > # PnP must come after ACPI since it will eventually need to check if acpi
> > > # was used and do nothing if so
> > > obj-$(CONFIG_PNP) += pnp/
> > > -obj-$(CONFIG_ARM_AMBA) += amba/
> > > +obj-$(CONFIG_ARM) += amba/
> >
> > NAK. This makes amba only buildable for ARM which is not the intention.
> > Other architectures do have Primecells.
>
> What about the following?
>
> +obj-y += amba/
Looks ok to me, but which problem are you trying to solve anyway? Tegra
always enables ARM_AMBA, so AFAICT there is no difference between this
and the original code.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
Date: Mon, 7 May 2012 08:59:28 +0000 [thread overview]
Message-ID: <201205070859.29174.arnd@arndb.de> (raw)
In-Reply-To: <20120507.105254.1899925115243585929.hdoyu@nvidia.com>
On Monday 07 May 2012, Hiroshi Doyu wrote:
> > On Mon, May 07, 2012 at 09:43:45AM +0300, Hiroshi DOYU wrote:
> > > diff --git a/drivers/Makefile b/drivers/Makefile
> > > index 5870322..d97e2e2 100644
> > > --- a/drivers/Makefile
> > > +++ b/drivers/Makefile
> > > @@ -18,7 +18,7 @@ obj-$(CONFIG_SFI) += sfi/
> > > # PnP must come after ACPI since it will eventually need to check if acpi
> > > # was used and do nothing if so
> > > obj-$(CONFIG_PNP) += pnp/
> > > -obj-$(CONFIG_ARM_AMBA) += amba/
> > > +obj-$(CONFIG_ARM) += amba/
> >
> > NAK. This makes amba only buildable for ARM which is not the intention.
> > Other architectures do have Primecells.
>
> What about the following?
>
> +obj-y += amba/
Looks ok to me, but which problem are you trying to solve anyway? Tegra
always enables ARM_AMBA, so AFAICT there is no difference between this
and the original code.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Hiroshi Doyu <hdoyu@nvidia.com>
Cc: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"balbi@ti.com" <balbi@ti.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"rob@landley.net" <rob@landley.net>,
"ccross@android.com" <ccross@android.com>,
"olof@lixom.net" <olof@lixom.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"ohad@wizery.com" <ohad@wizery.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
Date: Mon, 7 May 2012 08:59:28 +0000 [thread overview]
Message-ID: <201205070859.29174.arnd@arndb.de> (raw)
In-Reply-To: <20120507.105254.1899925115243585929.hdoyu@nvidia.com>
On Monday 07 May 2012, Hiroshi Doyu wrote:
> > On Mon, May 07, 2012 at 09:43:45AM +0300, Hiroshi DOYU wrote:
> > > diff --git a/drivers/Makefile b/drivers/Makefile
> > > index 5870322..d97e2e2 100644
> > > --- a/drivers/Makefile
> > > +++ b/drivers/Makefile
> > > @@ -18,7 +18,7 @@ obj-$(CONFIG_SFI) += sfi/
> > > # PnP must come after ACPI since it will eventually need to check if acpi
> > > # was used and do nothing if so
> > > obj-$(CONFIG_PNP) += pnp/
> > > -obj-$(CONFIG_ARM_AMBA) += amba/
> > > +obj-$(CONFIG_ARM) += amba/
> >
> > NAK. This makes amba only buildable for ARM which is not the intention.
> > Other architectures do have Primecells.
>
> What about the following?
>
> +obj-y += amba/
Looks ok to me, but which problem are you trying to solve anyway? Tegra
always enables ARM_AMBA, so AFAICT there is no difference between this
and the original code.
Arnd
next prev parent reply other threads:[~2012-05-07 8:59 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 6:43 [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
[not found] ` <1336373032-16881-1-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-07 6:43 ` [PATCHv5 2/3] ARM: tegra: Add SMMU enabler in AHB Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
2012-05-07 6:43 ` [PATCHv5 3/3] ARM: dt: tegra: Add device tree support for AHB Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
2012-05-07 7:42 ` [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver Russell King - ARM Linux
2012-05-07 7:42 ` Russell King - ARM Linux
2012-05-07 7:42 ` Russell King - ARM Linux
[not found] ` <20120507074228.GK26481-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-05-07 7:52 ` Hiroshi Doyu
2012-05-07 7:52 ` Hiroshi Doyu
2012-05-07 7:52 ` Hiroshi Doyu
[not found] ` <20120507.105254.1899925115243585929.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-07 8:59 ` Arnd Bergmann [this message]
2012-05-07 8:59 ` Arnd Bergmann
2012-05-07 8:59 ` Arnd Bergmann
2012-05-07 9:23 ` Hiroshi Doyu
2012-05-07 9:23 ` Hiroshi Doyu
2012-05-07 9:23 ` Hiroshi Doyu
2012-05-07 10:24 ` Arnd Bergmann
2012-05-07 10:24 ` Arnd Bergmann
2012-05-07 10:24 ` Arnd Bergmann
[not found] ` <201205071024.48958.arnd-r2nGTMty4D4@public.gmane.org>
2012-05-07 11:36 ` Hiroshi Doyu
2012-05-07 11:36 ` Hiroshi Doyu
2012-05-07 11:36 ` Hiroshi Doyu
2012-05-07 11:36 ` Hiroshi Doyu
2012-05-07 15:47 ` Stephen Warren
2012-05-07 15:47 ` Stephen Warren
2012-05-07 15:47 ` Stephen Warren
2012-05-07 18:36 ` gregkh
2012-05-07 18:36 ` gregkh
2012-05-07 18:36 ` gregkh at linuxfoundation.org
2012-05-08 5:12 ` Hiroshi Doyu
2012-05-08 5:12 ` Hiroshi Doyu
2012-05-08 5:12 ` Hiroshi Doyu
[not found] ` <20120507.143647.508182574757518311.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-08 19:45 ` Stephen Warren
2012-05-08 19:45 ` Stephen Warren
2012-05-08 19:45 ` Stephen Warren
2012-05-07 8:04 ` Arnd Bergmann
2012-05-07 8:04 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205070859.29174.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-fy+rA21nqHI@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.