From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Hiroshi Doyu <hdoyu@nvidia.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"balbi@ti.com" <balbi@ti.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"rob@landley.net" <rob@landley.net>,
"ccross@android.com" <ccross@android.com>,
"olof@lixom.net" <olof@lixom.net>,
"ohad@wizery.com" <ohad@wizery.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
linux-kernel@
Subject: Re: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
Date: Mon, 7 May 2012 11:36:11 -0700 [thread overview]
Message-ID: <20120507183611.GA725@kroah.com> (raw)
In-Reply-To: <20120507.143647.508182574757518311.hdoyu@nvidia.com>
On Mon, May 07, 2012 at 01:36:47PM +0200, Hiroshi Doyu wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Subject: Re: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
> Date: Mon, 7 May 2012 12:24:48 +0200
> Message-ID: <201205071024.48958.arnd@arndb.de>
>
> > On Monday 07 May 2012, Hiroshi Doyu wrote:
> > > Tegra doesn't enable ARM_AMBA and Tegra doesn't use the following
> > > "drivers/amba/bus.c" right now. I needed to make this directory
> > > available to ones without ARM_AMBA enabled.
> >
> > Ah, right. I looked at arch/arm/Kconfig earlier to see if
> > tegra enabled ARM_AMBA but was accidentally looking
> > at ARCH_INtegraTOR when grepping for TEGRA ;-)
> >
> > Your proposed solution sounds good then.
>
> Thank you for reviewing patches & ACK. Attached the update one here,
> instead of sending a while series again.
>
> >From 16cc2b0fab00c33cd24bb5c43c45a4cda646ad42 Mon Sep 17 00:00:00 2001
> From: Hiroshi DOYU <hdoyu@nvidia.com>
> Date: Wed, 18 Apr 2012 11:41:56 +0300
> Subject: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
>
> Tegra AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced
> High-performance Bus (AHB) architecture.
>
> The AHB Arbiter controls AHB bus master arbitration. This effectively
> forms a second level of arbitration for access to the memory
> controller through the AHB Slave Memory device. The AHB pre-fetch
> logic can be configured to enhance performance for devices doing
> sequential access. Each AHB master is assigned to either the high or
> low priority bin. Both Tegra20/30 have this AHB bus.
>
> Some of configuration params could be passed from DT too if needed.
>
> Change-Id: I184e0e1ce033e76881353a4bb99234e2850e99c2
What nonsense is this? Please never put that in a patch you want
accepted upstream, as it makes no sense and we just have to edit it out
by hand, making us grumpy...
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (gregkh at linuxfoundation.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
Date: Mon, 7 May 2012 11:36:11 -0700 [thread overview]
Message-ID: <20120507183611.GA725@kroah.com> (raw)
In-Reply-To: <20120507.143647.508182574757518311.hdoyu@nvidia.com>
On Mon, May 07, 2012 at 01:36:47PM +0200, Hiroshi Doyu wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Subject: Re: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
> Date: Mon, 7 May 2012 12:24:48 +0200
> Message-ID: <201205071024.48958.arnd@arndb.de>
>
> > On Monday 07 May 2012, Hiroshi Doyu wrote:
> > > Tegra doesn't enable ARM_AMBA and Tegra doesn't use the following
> > > "drivers/amba/bus.c" right now. I needed to make this directory
> > > available to ones without ARM_AMBA enabled.
> >
> > Ah, right. I looked at arch/arm/Kconfig earlier to see if
> > tegra enabled ARM_AMBA but was accidentally looking
> > at ARCH_INtegraTOR when grepping for TEGRA ;-)
> >
> > Your proposed solution sounds good then.
>
> Thank you for reviewing patches & ACK. Attached the update one here,
> instead of sending a while series again.
>
> >From 16cc2b0fab00c33cd24bb5c43c45a4cda646ad42 Mon Sep 17 00:00:00 2001
> From: Hiroshi DOYU <hdoyu@nvidia.com>
> Date: Wed, 18 Apr 2012 11:41:56 +0300
> Subject: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
>
> Tegra AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced
> High-performance Bus (AHB) architecture.
>
> The AHB Arbiter controls AHB bus master arbitration. This effectively
> forms a second level of arbitration for access to the memory
> controller through the AHB Slave Memory device. The AHB pre-fetch
> logic can be configured to enhance performance for devices doing
> sequential access. Each AHB master is assigned to either the high or
> low priority bin. Both Tegra20/30 have this AHB bus.
>
> Some of configuration params could be passed from DT too if needed.
>
> Change-Id: I184e0e1ce033e76881353a4bb99234e2850e99c2
What nonsense is this? Please never put that in a patch you want
accepted upstream, as it makes no sense and we just have to edit it out
by hand, making us grumpy...
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Hiroshi Doyu <hdoyu@nvidia.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"balbi@ti.com" <balbi@ti.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"rob@landley.net" <rob@landley.net>,
"ccross@android.com" <ccross@android.com>,
"olof@lixom.net" <olof@lixom.net>,
"ohad@wizery.com" <ohad@wizery.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
Date: Mon, 7 May 2012 11:36:11 -0700 [thread overview]
Message-ID: <20120507183611.GA725@kroah.com> (raw)
In-Reply-To: <20120507.143647.508182574757518311.hdoyu@nvidia.com>
On Mon, May 07, 2012 at 01:36:47PM +0200, Hiroshi Doyu wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Subject: Re: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
> Date: Mon, 7 May 2012 12:24:48 +0200
> Message-ID: <201205071024.48958.arnd@arndb.de>
>
> > On Monday 07 May 2012, Hiroshi Doyu wrote:
> > > Tegra doesn't enable ARM_AMBA and Tegra doesn't use the following
> > > "drivers/amba/bus.c" right now. I needed to make this directory
> > > available to ones without ARM_AMBA enabled.
> >
> > Ah, right. I looked at arch/arm/Kconfig earlier to see if
> > tegra enabled ARM_AMBA but was accidentally looking
> > at ARCH_INtegraTOR when grepping for TEGRA ;-)
> >
> > Your proposed solution sounds good then.
>
> Thank you for reviewing patches & ACK. Attached the update one here,
> instead of sending a while series again.
>
> >From 16cc2b0fab00c33cd24bb5c43c45a4cda646ad42 Mon Sep 17 00:00:00 2001
> From: Hiroshi DOYU <hdoyu@nvidia.com>
> Date: Wed, 18 Apr 2012 11:41:56 +0300
> Subject: [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver
>
> Tegra AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced
> High-performance Bus (AHB) architecture.
>
> The AHB Arbiter controls AHB bus master arbitration. This effectively
> forms a second level of arbitration for access to the memory
> controller through the AHB Slave Memory device. The AHB pre-fetch
> logic can be configured to enhance performance for devices doing
> sequential access. Each AHB master is assigned to either the high or
> low priority bin. Both Tegra20/30 have this AHB bus.
>
> Some of configuration params could be passed from DT too if needed.
>
> Change-Id: I184e0e1ce033e76881353a4bb99234e2850e99c2
What nonsense is this? Please never put that in a patch you want
accepted upstream, as it makes no sense and we just have to edit it out
by hand, making us grumpy...
greg k-h
next prev parent reply other threads:[~2012-05-07 18:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 6:43 [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
[not found] ` <1336373032-16881-1-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-07 6:43 ` [PATCHv5 2/3] ARM: tegra: Add SMMU enabler in AHB Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
2012-05-07 6:43 ` [PATCHv5 3/3] ARM: dt: tegra: Add device tree support for AHB Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
2012-05-07 6:43 ` Hiroshi DOYU
2012-05-07 7:42 ` [PATCHv5 1/3] ARM: tegra: Add Tegra AHB driver Russell King - ARM Linux
2012-05-07 7:42 ` Russell King - ARM Linux
2012-05-07 7:42 ` Russell King - ARM Linux
[not found] ` <20120507074228.GK26481-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-05-07 7:52 ` Hiroshi Doyu
2012-05-07 7:52 ` Hiroshi Doyu
2012-05-07 7:52 ` Hiroshi Doyu
[not found] ` <20120507.105254.1899925115243585929.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-07 8:59 ` Arnd Bergmann
2012-05-07 8:59 ` Arnd Bergmann
2012-05-07 8:59 ` Arnd Bergmann
2012-05-07 9:23 ` Hiroshi Doyu
2012-05-07 9:23 ` Hiroshi Doyu
2012-05-07 9:23 ` Hiroshi Doyu
2012-05-07 10:24 ` Arnd Bergmann
2012-05-07 10:24 ` Arnd Bergmann
2012-05-07 10:24 ` Arnd Bergmann
[not found] ` <201205071024.48958.arnd-r2nGTMty4D4@public.gmane.org>
2012-05-07 11:36 ` Hiroshi Doyu
2012-05-07 11:36 ` Hiroshi Doyu
2012-05-07 11:36 ` Hiroshi Doyu
2012-05-07 11:36 ` Hiroshi Doyu
2012-05-07 15:47 ` Stephen Warren
2012-05-07 15:47 ` Stephen Warren
2012-05-07 15:47 ` Stephen Warren
2012-05-07 18:36 ` gregkh [this message]
2012-05-07 18:36 ` gregkh
2012-05-07 18:36 ` gregkh at linuxfoundation.org
2012-05-08 5:12 ` Hiroshi Doyu
2012-05-08 5:12 ` Hiroshi Doyu
2012-05-08 5:12 ` Hiroshi Doyu
[not found] ` <20120507.143647.508182574757518311.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-08 19:45 ` Stephen Warren
2012-05-08 19:45 ` Stephen Warren
2012-05-08 19:45 ` Stephen Warren
2012-05-07 8:04 ` Arnd Bergmann
2012-05-07 8:04 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507183611.GA725@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=ccross@android.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=hdoyu@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linville@tuxdriver.com \
--cc=myungjoo.ham@samsung.com \
--cc=ohad@wizery.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.