From: Marek Vasut <marex@denx.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Chris Ball <cjb@laptop.org>,
Dong Aisheng <dong.aisheng@linaro.org>
Subject: Re: [PATCH 06/10] mmc: mxs-mmc: have dma_channel than dma_res in mxs_mmc_host
Date: Tue, 8 May 2012 01:51:44 +0200 [thread overview]
Message-ID: <201205080151.44883.marex@denx.de> (raw)
In-Reply-To: <1336401793-13753-7-git-send-email-shawn.guo@linaro.org>
Dear Shawn Guo,
> It replaces dma_res with dma_channel in struct mxs_mmc_host, so that
> the device tree support will be a little easier, since dma channel
> can not be retrieved from "struct resource *dma_res".
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Marek Vasut <marex@denx.de>
> ---
> drivers/mmc/host/mxs-mmc.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index 1a8ba314..e905721 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -146,7 +146,7 @@ struct mxs_mmc_host {
> struct mmc_data *data;
>
> void __iomem *base;
> - struct resource *dma_res;
> + int dma_channel;
> struct clk *clk;
> unsigned int clk_rate;
>
> @@ -668,7 +668,7 @@ static bool mxs_mmc_dma_filter(struct dma_chan *chan,
> void *param) if (!mxs_dma_is_apbh(chan))
> return false;
>
> - if (chan->chan_id != host->dma_res->start)
> + if (chan->chan_id != host->dma_channel)
> return false;
>
> chan->private = &host->dma_data;
> @@ -719,7 +719,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
>
> host->devid = pdev->id_entry->driver_data;
> host->mmc = mmc;
> - host->dma_res = dmares;
> + host->dma_channel = dmares->start;
> host->sdio_irq_en = 0;
>
> pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/10] mmc: mxs-mmc: have dma_channel than dma_res in mxs_mmc_host
Date: Tue, 8 May 2012 01:51:44 +0200 [thread overview]
Message-ID: <201205080151.44883.marex@denx.de> (raw)
In-Reply-To: <1336401793-13753-7-git-send-email-shawn.guo@linaro.org>
Dear Shawn Guo,
> It replaces dma_res with dma_channel in struct mxs_mmc_host, so that
> the device tree support will be a little easier, since dma channel
> can not be retrieved from "struct resource *dma_res".
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Marek Vasut <marex@denx.de>
> ---
> drivers/mmc/host/mxs-mmc.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index 1a8ba314..e905721 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -146,7 +146,7 @@ struct mxs_mmc_host {
> struct mmc_data *data;
>
> void __iomem *base;
> - struct resource *dma_res;
> + int dma_channel;
> struct clk *clk;
> unsigned int clk_rate;
>
> @@ -668,7 +668,7 @@ static bool mxs_mmc_dma_filter(struct dma_chan *chan,
> void *param) if (!mxs_dma_is_apbh(chan))
> return false;
>
> - if (chan->chan_id != host->dma_res->start)
> + if (chan->chan_id != host->dma_channel)
> return false;
>
> chan->private = &host->dma_data;
> @@ -719,7 +719,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
>
> host->devid = pdev->id_entry->driver_data;
> host->mmc = mmc;
> - host->dma_res = dmares;
> + host->dma_channel = dmares->start;
> host->sdio_irq_en = 0;
>
> pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-07 23:58 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 14:43 [PATCH 00/10] Add device tree support for mxs-mmc Shawn Guo
2012-05-07 14:43 ` Shawn Guo
2012-05-07 14:43 ` [PATCH 01/10] mmc: mxs-mmc: use global stmp_device functionality Shawn Guo
2012-05-07 14:43 ` Shawn Guo
2012-05-07 23:41 ` Marek Vasut
2012-05-07 23:41 ` Marek Vasut
2012-05-07 14:43 ` [PATCH 02/10] mmc: mxs-mmc: let ssp_is_old take host as parameter Shawn Guo
2012-05-07 14:43 ` Shawn Guo
2012-05-07 23:43 ` Marek Vasut
2012-05-07 23:43 ` Marek Vasut
2012-05-08 14:32 ` Shawn Guo
2012-05-08 14:32 ` Shawn Guo
2012-05-07 14:43 ` [PATCH 03/10] mmc: mxs-mmc: get rid of the use of cpu_is_xxx Shawn Guo
2012-05-07 14:43 ` Shawn Guo
2012-05-07 23:46 ` Marek Vasut
2012-05-07 23:46 ` Marek Vasut
2012-05-08 14:35 ` Shawn Guo
2012-05-08 14:35 ` Shawn Guo
2012-05-07 14:43 ` [PATCH 04/10] mmc: mxs-mmc: move header from mach into linux folder Shawn Guo
2012-05-07 14:43 ` Shawn Guo
2012-05-07 23:47 ` Marek Vasut
2012-05-07 23:47 ` Marek Vasut
2012-05-07 14:43 ` [PATCH 05/10] mmc: mxs-mmc: use devm_* helper to make cleanup simpler Shawn Guo
2012-05-07 14:43 ` Shawn Guo
2012-05-07 23:49 ` Marek Vasut
2012-05-07 23:49 ` Marek Vasut
2012-05-08 14:38 ` Shawn Guo
2012-05-08 14:38 ` Shawn Guo
2012-05-07 14:43 ` [PATCH 06/10] mmc: mxs-mmc: have dma_channel than dma_res in mxs_mmc_host Shawn Guo
2012-05-07 14:43 ` Shawn Guo
2012-05-07 23:51 ` Marek Vasut [this message]
2012-05-07 23:51 ` Marek Vasut
2012-05-07 14:43 ` [PATCH 07/10] mmc: mxs-mmc: copy wp_gpio in struct mxs_mmc_host Shawn Guo
2012-05-07 14:43 ` Shawn Guo
2012-05-07 23:53 ` Marek Vasut
2012-05-07 23:53 ` Marek Vasut
2012-05-08 14:40 ` Shawn Guo
2012-05-08 14:40 ` Shawn Guo
2012-05-07 14:43 ` [PATCH 08/10] mmc: mxs-mmc: add device tree support Shawn Guo
2012-05-07 14:43 ` Shawn Guo
2012-05-07 23:58 ` Marek Vasut
2012-05-07 23:58 ` Marek Vasut
2012-05-08 14:43 ` Shawn Guo
2012-05-08 14:43 ` Shawn Guo
2012-05-12 14:44 ` Chris Ball
2012-05-12 14:44 ` Chris Ball
2012-05-13 0:03 ` Shawn Guo
2012-05-13 0:03 ` Shawn Guo
2012-05-13 0:11 ` Chris Ball
2012-05-13 0:11 ` Chris Ball
2012-05-13 0:21 ` Shawn Guo
2012-05-13 0:21 ` Shawn Guo
2012-05-13 0:29 ` Shawn Guo
2012-05-13 0:29 ` Shawn Guo
2012-05-07 14:43 ` [PATCH 09/10] ARM: dts: enable mmc for imx23-evk Shawn Guo
2012-05-07 14:43 ` Shawn Guo
2012-05-07 14:43 ` [PATCH 10/10] ARM: dts: enable mmc for imx28-evk Shawn Guo
2012-05-07 14:43 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205080151.44883.marex@denx.de \
--to=marex@denx.de \
--cc=cjb@laptop.org \
--cc=dong.aisheng@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.