All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: DT: Add binding for GIC virtualization extentions (VGIC)
Date: Wed, 9 May 2012 20:27:49 +0000	[thread overview]
Message-ID: <201205092027.50059.arnd@arndb.de> (raw)
In-Reply-To: <a226ca6e8dd0370afeeb9aa1d67ddfde@localhost>

On Wednesday 09 May 2012, Marc Zyngier wrote:
> On Wed, 9 May 2012 19:21:42 +0000, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Wednesday 09 May 2012, Marc Zyngier wrote:
> >> 
> >> The GICv2 can have virtualization extension support, consisting
> >> of an additional set of registers and interrupts. Add the necessary
> >> binding to the GIC DT documentation.
> >> 
> >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> > 
> > Would it make sense to add a way to detect whether a GIC is virtual
> > or real? Maybe an optional empty "virtual-gic" property or an additional
> > "compatible" value. Even if we don't need it now, it might come in handy
> > if we require it already.
> 
> I don't really see a need for this. When running on a virtual machine, the
> kernel cannot tell if this is the real thing or not (the virtual CPU
> interface looks exactly like the normal one once mapped into the guest
> address space).
> 
> Or maybe I just didn't get your use case?

Well, one difference seems to be the VGIC maintainance interrupt that may
or may not be present, and another one the additional registers. Of course
you can imply the type of GIC from the presence of this extra data,
but I think it would be better to make it explicit.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
	david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2] ARM: DT: Add binding for GIC virtualization extentions (VGIC)
Date: Wed, 9 May 2012 20:27:49 +0000	[thread overview]
Message-ID: <201205092027.50059.arnd@arndb.de> (raw)
In-Reply-To: <a226ca6e8dd0370afeeb9aa1d67ddfde@localhost>

On Wednesday 09 May 2012, Marc Zyngier wrote:
> On Wed, 9 May 2012 19:21:42 +0000, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> > On Wednesday 09 May 2012, Marc Zyngier wrote:
> >> 
> >> The GICv2 can have virtualization extension support, consisting
> >> of an additional set of registers and interrupts. Add the necessary
> >> binding to the GIC DT documentation.
> >> 
> >> Signed-off-by: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
> > 
> > Would it make sense to add a way to detect whether a GIC is virtual
> > or real? Maybe an optional empty "virtual-gic" property or an additional
> > "compatible" value. Even if we don't need it now, it might come in handy
> > if we require it already.
> 
> I don't really see a need for this. When running on a virtual machine, the
> kernel cannot tell if this is the real thing or not (the virtual CPU
> interface looks exactly like the normal one once mapped into the guest
> address space).
> 
> Or maybe I just didn't get your use case?

Well, one difference seems to be the VGIC maintainance interrupt that may
or may not be present, and another one the additional registers. Of course
you can imply the type of GIC from the presence of this extra data,
but I think it would be better to make it explicit.

	Arnd

  reply	other threads:[~2012-05-09 20:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 17:57 [PATCH v2] ARM: DT: Add binding for GIC virtualization extentions (VGIC) Marc Zyngier
2012-05-09 17:57 ` Marc Zyngier
2012-05-09 19:21 ` Arnd Bergmann
2012-05-09 19:21   ` Arnd Bergmann
2012-05-09 19:36   ` Marc Zyngier
2012-05-09 19:36     ` Marc Zyngier
2012-05-09 20:27     ` Arnd Bergmann [this message]
2012-05-09 20:27       ` Arnd Bergmann
2012-05-09 20:42       ` Marc Zyngier
2012-05-09 20:42         ` Marc Zyngier
2012-05-09 20:47         ` Arnd Bergmann
2012-05-09 20:47           ` Arnd Bergmann
2012-05-09 21:34           ` Marc Zyngier
2012-05-09 21:34             ` Marc Zyngier
2012-05-10 10:53             ` Arnd Bergmann
2012-05-10 10:53               ` Arnd Bergmann
2012-05-10 11:11               ` Marc Zyngier
2012-05-10 11:11                 ` Marc Zyngier
2012-05-11 15:11             ` Grant Likely
2012-05-11 15:11               ` Grant Likely
2012-05-11 15:10           ` Grant Likely
2012-05-11 15:10             ` Grant Likely
2012-05-11 14:14 ` David Vrabel
2012-05-11 14:14   ` David Vrabel
2012-05-11 14:42   ` Marc Zyngier
2012-05-11 14:42     ` Marc Zyngier
2012-05-11 14:43     ` David Vrabel
2012-05-11 14:43       ` David Vrabel
2012-05-11 15:15       ` Grant Likely
2012-05-11 15:15         ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205092027.50059.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.