From: Tony Lindgren <tony@atomide.com>
To: Russ Dill <Russ.Dill@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep
Date: Wed, 09 May 2012 22:14:48 +0000 [thread overview]
Message-ID: <20120509221447.GY5088@atomide.com> (raw)
In-Reply-To: <1336601288-27848-1-git-send-email-Russ.Dill@ti.com>
* Russ Dill <Russ.Dill@ti.com> [120509 15:12]:
> The Beagleboard xM gpio used for TFP410 powerdown is connected through
> an I2C attached chip which means setting the GPIO can sleep. Code that
> calls tfp410_power_on/off holds a mutex, so sleeping should be fine.
What's the error without this patch? Or just no display?
Just wondering if it's safe to merge Tomi's clean up series to
arm-soc tree..
Tony
> Signed-off-by: Russ Dill <Russ.Dill@ti.com>
> ---
> drivers/video/omap2/displays/panel-tfp410.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/panel-tfp410.c b/drivers/video/omap2/displays/panel-tfp410.c
> index 52637fa..1266520 100644
> --- a/drivers/video/omap2/displays/panel-tfp410.c
> +++ b/drivers/video/omap2/displays/panel-tfp410.c
> @@ -68,7 +68,7 @@ static int tfp410_power_on(struct omap_dss_device *dssdev)
> goto err0;
>
> if (gpio_is_valid(ddata->pd_gpio))
> - gpio_set_value(ddata->pd_gpio, 1);
> + gpio_set_value_cansleep(ddata->pd_gpio, 1);
>
> return 0;
> err0:
> @@ -83,7 +83,7 @@ static void tfp410_power_off(struct omap_dss_device *dssdev)
> return;
>
> if (gpio_is_valid(ddata->pd_gpio))
> - gpio_set_value(ddata->pd_gpio, 0);
> + gpio_set_value_cansleep(ddata->pd_gpio, 0);
>
> omapdss_dpi_display_disable(dssdev);
> }
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Russ Dill <Russ.Dill@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep
Date: Wed, 9 May 2012 15:14:48 -0700 [thread overview]
Message-ID: <20120509221447.GY5088@atomide.com> (raw)
In-Reply-To: <1336601288-27848-1-git-send-email-Russ.Dill@ti.com>
* Russ Dill <Russ.Dill@ti.com> [120509 15:12]:
> The Beagleboard xM gpio used for TFP410 powerdown is connected through
> an I2C attached chip which means setting the GPIO can sleep. Code that
> calls tfp410_power_on/off holds a mutex, so sleeping should be fine.
What's the error without this patch? Or just no display?
Just wondering if it's safe to merge Tomi's clean up series to
arm-soc tree..
Tony
> Signed-off-by: Russ Dill <Russ.Dill@ti.com>
> ---
> drivers/video/omap2/displays/panel-tfp410.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/panel-tfp410.c b/drivers/video/omap2/displays/panel-tfp410.c
> index 52637fa..1266520 100644
> --- a/drivers/video/omap2/displays/panel-tfp410.c
> +++ b/drivers/video/omap2/displays/panel-tfp410.c
> @@ -68,7 +68,7 @@ static int tfp410_power_on(struct omap_dss_device *dssdev)
> goto err0;
>
> if (gpio_is_valid(ddata->pd_gpio))
> - gpio_set_value(ddata->pd_gpio, 1);
> + gpio_set_value_cansleep(ddata->pd_gpio, 1);
>
> return 0;
> err0:
> @@ -83,7 +83,7 @@ static void tfp410_power_off(struct omap_dss_device *dssdev)
> return;
>
> if (gpio_is_valid(ddata->pd_gpio))
> - gpio_set_value(ddata->pd_gpio, 0);
> + gpio_set_value_cansleep(ddata->pd_gpio, 0);
>
> omapdss_dpi_display_disable(dssdev);
> }
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-05-09 22:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 22:08 [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep Russ Dill
2012-05-09 22:08 ` Russ Dill
2012-05-09 22:14 ` Tony Lindgren [this message]
2012-05-09 22:14 ` Tony Lindgren
2012-05-09 22:50 ` Russ Dill
2012-05-09 22:50 ` Russ Dill
2012-05-09 23:37 ` Tony Lindgren
2012-05-09 23:37 ` Tony Lindgren
2012-05-10 6:53 ` Tomi Valkeinen
2012-05-10 6:53 ` Tomi Valkeinen
2012-05-10 16:16 ` Tony Lindgren
2012-05-10 16:16 ` Tony Lindgren
2012-05-10 6:54 ` Tomi Valkeinen
2012-05-10 6:54 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509221447.GY5088@atomide.com \
--to=tony@atomide.com \
--cc=Russ.Dill@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.