* [PATCH] spi/topcliff: use correct __devexit_p annotation
@ 2012-05-09 22:35 ` mathieu.poirier
0 siblings, 0 replies; 4+ messages in thread
From: mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A @ 2012-05-09 22:35 UTC (permalink / raw)
To: grant.likely-s3s/WqlpOiPyB63q8FvJNQ
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, arnd-r2nGTMty4D4
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
__devexit functions are discarded when CONFIG_HOTPLUG
is not set, so the symbol needs to be referenced carefully.
Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Signed-off-by: Mathieu Poirier <mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
drivers/spi/spi-topcliff-pch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index ec47d3b..77c4562 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1779,7 +1779,7 @@ static struct pci_driver pch_spi_pcidev_driver = {
.name = "pch_spi",
.id_table = pch_spi_pcidev_id,
.probe = pch_spi_probe,
- .remove = pch_spi_remove,
+ .remove = __devexit_p(pch_spi_remove),
.suspend = pch_spi_suspend,
.resume = pch_spi_resume,
};
--
1.7.5.4
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] spi/topcliff: use correct __devexit_p annotation
@ 2012-05-09 22:35 ` mathieu.poirier
0 siblings, 0 replies; 4+ messages in thread
From: mathieu.poirier @ 2012-05-09 22:35 UTC (permalink / raw)
To: grant.likely; +Cc: spi-devel-general, linux-kernel, arnd, mathieu.poirier
From: Arnd Bergmann <arnd@arndb.de>
__devexit functions are discarded when CONFIG_HOTPLUG
is not set, so the symbol needs to be referenced carefully.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/spi/spi-topcliff-pch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index ec47d3b..77c4562 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1779,7 +1779,7 @@ static struct pci_driver pch_spi_pcidev_driver = {
.name = "pch_spi",
.id_table = pch_spi_pcidev_id,
.probe = pch_spi_probe,
- .remove = pch_spi_remove,
+ .remove = __devexit_p(pch_spi_remove),
.suspend = pch_spi_suspend,
.resume = pch_spi_resume,
};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1336602923-5724-1-git-send-email-mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]
* Re: [PATCH] spi/topcliff: use correct __devexit_p annotation
2012-05-09 22:35 ` mathieu.poirier
@ 2012-05-10 0:25 ` Grant Likely
-1 siblings, 0 replies; 4+ messages in thread
From: Grant Likely @ 2012-05-10 0:25 UTC (permalink / raw)
To: mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, arnd-r2nGTMty4D4
On Wed, 9 May 2012 16:35:23 -0600, mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote:
> From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
>
> __devexit functions are discarded when CONFIG_HOTPLUG
> is not set, so the symbol needs to be referenced carefully.
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Signed-off-by: Mathieu Poirier <mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Applied, thanks.
g.
> ---
> drivers/spi/spi-topcliff-pch.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> index ec47d3b..77c4562 100644
> --- a/drivers/spi/spi-topcliff-pch.c
> +++ b/drivers/spi/spi-topcliff-pch.c
> @@ -1779,7 +1779,7 @@ static struct pci_driver pch_spi_pcidev_driver = {
> .name = "pch_spi",
> .id_table = pch_spi_pcidev_id,
> .probe = pch_spi_probe,
> - .remove = pch_spi_remove,
> + .remove = __devexit_p(pch_spi_remove),
> .suspend = pch_spi_suspend,
> .resume = pch_spi_resume,
> };
> --
> 1.7.5.4
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] spi/topcliff: use correct __devexit_p annotation
@ 2012-05-10 0:25 ` Grant Likely
0 siblings, 0 replies; 4+ messages in thread
From: Grant Likely @ 2012-05-10 0:25 UTC (permalink / raw)
To: mathieu.poirier; +Cc: spi-devel-general, linux-kernel, arnd, mathieu.poirier
On Wed, 9 May 2012 16:35:23 -0600, mathieu.poirier@linaro.org wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> __devexit functions are discarded when CONFIG_HOTPLUG
> is not set, so the symbol needs to be referenced carefully.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Applied, thanks.
g.
> ---
> drivers/spi/spi-topcliff-pch.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> index ec47d3b..77c4562 100644
> --- a/drivers/spi/spi-topcliff-pch.c
> +++ b/drivers/spi/spi-topcliff-pch.c
> @@ -1779,7 +1779,7 @@ static struct pci_driver pch_spi_pcidev_driver = {
> .name = "pch_spi",
> .id_table = pch_spi_pcidev_id,
> .probe = pch_spi_probe,
> - .remove = pch_spi_remove,
> + .remove = __devexit_p(pch_spi_remove),
> .suspend = pch_spi_suspend,
> .resume = pch_spi_resume,
> };
> --
> 1.7.5.4
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-10 0:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-09 22:35 [PATCH] spi/topcliff: use correct __devexit_p annotation mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A
2012-05-09 22:35 ` mathieu.poirier
[not found] ` <1336602923-5724-1-git-send-email-mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-05-10 0:25 ` Grant Likely
2012-05-10 0:25 ` Grant Likely
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.