From: Mel Gorman <mgorman@suse.de>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, Trond.Myklebust@netapp.com,
neilb@suse.de, hch@infradead.org, a.p.zijlstra@chello.nl,
michaelc@cs.wisc.edu, emunson@mgebm.net
Subject: Re: [PATCH 01/12] netvm: Prevent a stream-specific deadlock
Date: Mon, 14 May 2012 11:56:04 +0100 [thread overview]
Message-ID: <20120514105604.GB29102@suse.de> (raw)
In-Reply-To: <20120511.011034.557833140906762226.davem@davemloft.net>
On Fri, May 11, 2012 at 01:10:34AM -0400, David Miller wrote:
> From: Mel Gorman <mgorman@suse.de>
> Date: Thu, 10 May 2012 14:54:14 +0100
>
> > It could happen that all !SOCK_MEMALLOC sockets have buffered so
> > much data that we're over the global rmem limit. This will prevent
> > SOCK_MEMALLOC buffers from receiving data, which will prevent userspace
> > from running, which is needed to reduce the buffered data.
> >
> > Fix this by exempting the SOCK_MEMALLOC sockets from the rmem limit.
> >
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Signed-off-by: Mel Gorman <mgorman@suse.de>
>
> This introduces an invariant which I am not so sure is enforced.
>
> With this change it is absolutely required that once a socket
> becomes SOCK_MEMALLOC it must never _ever_ lose that attribute.
>
This is effectively true. In the NFS case, the flag is cleared on
swapoff after all the entries have been paged in. In the NBD case,
SOCK_MEMALLOC is left set until the socket is destroyed. I'll update the
changelog.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, Trond.Myklebust@netapp.com,
neilb@suse.de, hch@infradead.org, a.p.zijlstra@chello.nl,
michaelc@cs.wisc.edu, emunson@mgebm.net
Subject: Re: [PATCH 01/12] netvm: Prevent a stream-specific deadlock
Date: Mon, 14 May 2012 11:56:04 +0100 [thread overview]
Message-ID: <20120514105604.GB29102@suse.de> (raw)
In-Reply-To: <20120511.011034.557833140906762226.davem@davemloft.net>
On Fri, May 11, 2012 at 01:10:34AM -0400, David Miller wrote:
> From: Mel Gorman <mgorman@suse.de>
> Date: Thu, 10 May 2012 14:54:14 +0100
>
> > It could happen that all !SOCK_MEMALLOC sockets have buffered so
> > much data that we're over the global rmem limit. This will prevent
> > SOCK_MEMALLOC buffers from receiving data, which will prevent userspace
> > from running, which is needed to reduce the buffered data.
> >
> > Fix this by exempting the SOCK_MEMALLOC sockets from the rmem limit.
> >
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Signed-off-by: Mel Gorman <mgorman@suse.de>
>
> This introduces an invariant which I am not so sure is enforced.
>
> With this change it is absolutely required that once a socket
> becomes SOCK_MEMALLOC it must never _ever_ lose that attribute.
>
This is effectively true. In the NFS case, the flag is cleared on
swapoff after all the entries have been paged in. In the NBD case,
SOCK_MEMALLOC is left set until the socket is destroyed. I'll update the
changelog.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-14 10:56 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 13:54 [PATCH 00/12] Swap-over-NFS without deadlocking V4 Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 01/12] netvm: Prevent a stream-specific deadlock Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-11 5:10 ` David Miller
2012-05-11 5:10 ` David Miller
2012-05-14 10:56 ` Mel Gorman [this message]
2012-05-14 10:56 ` Mel Gorman
2012-05-14 20:26 ` David Miller
2012-05-14 20:26 ` David Miller
2012-05-15 9:14 ` Mel Gorman
2012-05-15 9:14 ` Mel Gorman
2012-05-15 9:14 ` Mel Gorman
2012-05-15 9:47 ` Peter Zijlstra
2012-05-15 9:47 ` Peter Zijlstra
2012-05-15 10:08 ` Mel Gorman
2012-05-15 10:08 ` Mel Gorman
2012-05-15 10:08 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 02/12] selinux: tag avc cache alloc as non-critical Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 14:14 ` Casey Schaufler
2012-05-10 14:14 ` Casey Schaufler
2012-05-10 14:14 ` Casey Schaufler
2012-05-10 14:25 ` Eric Paris
2012-05-10 14:25 ` Eric Paris
2012-05-10 13:54 ` [PATCH 03/12] mm: Methods for teaching filesystems about PG_swapcache pages Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 04/12] mm: Add support for a filesystem to activate swap files and use direct_IO for writing swap pages Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 05/12] mm: swap: Implement generic handler for swap_activate Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 06/12] mm: Add get_kernel_page[s] for pinning of kernel addresses for I/O Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 07/12] mm: Add support for direct_IO to highmem pages Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 08/12] nfs: teach the NFS client how to treat PG_swapcache pages Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 09/12] nfs: disable data cache revalidation for swapfiles Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 10/12] nfs: enable swap on NFS Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 11/12] nfs: Prevent page allocator recursions with swap over NFS Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 12/12] Avoid dereferencing bd_disk during swap_entry_free for network storage Mel Gorman
2012-05-10 13:54 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2012-05-17 14:51 [PATCH 00/12] Swap-over-NFS without deadlocking V5 Mel Gorman
2012-05-17 14:51 ` [PATCH 01/12] netvm: Prevent a stream-specific deadlock Mel Gorman
2012-05-17 14:51 ` Mel Gorman
2012-05-17 20:14 ` David Miller
2012-05-17 20:14 ` David Miller
2012-06-20 9:37 [PATCH 00/12] Swap-over-NFS without deadlocking V6 Mel Gorman
2012-06-20 9:37 ` [PATCH 01/12] netvm: Prevent a stream-specific deadlock Mel Gorman
2012-06-20 9:37 ` Mel Gorman
2012-06-20 14:21 ` Mel Gorman
2012-06-20 14:21 ` Mel Gorman
2012-06-20 15:22 ` Rik van Riel
2012-06-20 15:22 ` Rik van Riel
2012-06-22 14:30 [PATCH 00/12] Swap-over-NFS without deadlocking V7 Mel Gorman
2012-06-22 14:30 ` [PATCH 01/12] netvm: Prevent a stream-specific deadlock Mel Gorman
2012-06-22 14:30 ` Mel Gorman
2012-06-29 13:33 [PATCH 00/12] Swap-over-NFS without deadlocking V8 Mel Gorman
2012-06-29 13:33 ` [PATCH 01/12] netvm: Prevent a stream-specific deadlock Mel Gorman
2012-06-29 13:33 ` Mel Gorman
2012-07-12 6:40 [PATCH 00/12] Swap-over-NFS without deadlocking V9 Mel Gorman
2012-07-12 6:40 ` [PATCH 01/12] netvm: Prevent a stream-specific deadlock Mel Gorman
2012-07-12 6:40 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514105604.GB29102@suse.de \
--to=mgorman@suse.de \
--cc=Trond.Myklebust@netapp.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=emunson@mgebm.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.