From: Casey Schaufler <casey@schaufler-ca.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
Linux-Netdev <netdev@vger.kernel.org>,
Linux-NFS <linux-nfs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Neil Brown <neilb@suse.de>, Christoph Hellwig <hch@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mike Christie <michaelc@cs.wisc.edu>,
Eric B Munson <emunson@mgebm.net>,
LSM <linux-security-module@vger.kernel.org>,
SE Linux <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 02/12] selinux: tag avc cache alloc as non-critical
Date: Thu, 10 May 2012 07:14:45 -0700 [thread overview]
Message-ID: <4FABCD55.9000504@schaufler-ca.com> (raw)
In-Reply-To: <1336658065-24851-3-git-send-email-mgorman@suse.de>
On 5/10/2012 6:54 AM, Mel Gorman wrote:
> Failing to allocate a cache entry will only harm performance not
> correctness. Do not consume valuable reserve pages for something
> like that.
Copying to the LSM and SELinux lists.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> ---
> security/selinux/avc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/avc.c b/security/selinux/avc.c
> index 8ee42b2..75c2977 100644
> --- a/security/selinux/avc.c
> +++ b/security/selinux/avc.c
> @@ -280,7 +280,7 @@ static struct avc_node *avc_alloc_node(void)
> {
> struct avc_node *node;
>
> - node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC);
> + node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC);
> if (!node)
> goto out;
>
WARNING: multiple messages have this Message-ID (diff)
From: Casey Schaufler <casey@schaufler-ca.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
Linux-Netdev <netdev@vger.kernel.org>,
Linux-NFS <linux-nfs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Neil Brown <neilb@suse.de>, Christoph Hellwig <hch@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mike Christie <michaelc@cs.wisc.edu>,
Eric B Munson <emunson@mgebm.net>,
LSM <linux-security-module@vger.kernel.org>,
SE Linux <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 02/12] selinux: tag avc cache alloc as non-critical
Date: Thu, 10 May 2012 07:14:45 -0700 [thread overview]
Message-ID: <4FABCD55.9000504@schaufler-ca.com> (raw)
In-Reply-To: <1336658065-24851-3-git-send-email-mgorman@suse.de>
On 5/10/2012 6:54 AM, Mel Gorman wrote:
> Failing to allocate a cache entry will only harm performance not
> correctness. Do not consume valuable reserve pages for something
> like that.
Copying to the LSM and SELinux lists.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> ---
> security/selinux/avc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/avc.c b/security/selinux/avc.c
> index 8ee42b2..75c2977 100644
> --- a/security/selinux/avc.c
> +++ b/security/selinux/avc.c
> @@ -280,7 +280,7 @@ static struct avc_node *avc_alloc_node(void)
> {
> struct avc_node *node;
>
> - node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC);
> + node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC);
> if (!node)
> goto out;
>
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
WARNING: multiple messages have this Message-ID (diff)
From: Casey Schaufler <casey@schaufler-ca.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
Linux-Netdev <netdev@vger.kernel.org>,
Linux-NFS <linux-nfs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Neil Brown <neilb@suse.de>, Christoph Hellwig <hch@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mike Christie <michaelc@cs.wisc.edu>,
Eric B Munson <emunson@mgebm.net>,
LSM <linux-security-module@vger.kernel.org>,
SE Linux <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 02/12] selinux: tag avc cache alloc as non-critical
Date: Thu, 10 May 2012 07:14:45 -0700 [thread overview]
Message-ID: <4FABCD55.9000504@schaufler-ca.com> (raw)
In-Reply-To: <1336658065-24851-3-git-send-email-mgorman@suse.de>
On 5/10/2012 6:54 AM, Mel Gorman wrote:
> Failing to allocate a cache entry will only harm performance not
> correctness. Do not consume valuable reserve pages for something
> like that.
Copying to the LSM and SELinux lists.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> ---
> security/selinux/avc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/avc.c b/security/selinux/avc.c
> index 8ee42b2..75c2977 100644
> --- a/security/selinux/avc.c
> +++ b/security/selinux/avc.c
> @@ -280,7 +280,7 @@ static struct avc_node *avc_alloc_node(void)
> {
> struct avc_node *node;
>
> - node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC);
> + node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC);
> if (!node)
> goto out;
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-10 14:21 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 13:54 [PATCH 00/12] Swap-over-NFS without deadlocking V4 Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 01/12] netvm: Prevent a stream-specific deadlock Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-11 5:10 ` David Miller
2012-05-11 5:10 ` David Miller
2012-05-14 10:56 ` Mel Gorman
2012-05-14 10:56 ` Mel Gorman
2012-05-14 20:26 ` David Miller
2012-05-14 20:26 ` David Miller
2012-05-15 9:14 ` Mel Gorman
2012-05-15 9:14 ` Mel Gorman
2012-05-15 9:14 ` Mel Gorman
2012-05-15 9:47 ` Peter Zijlstra
2012-05-15 9:47 ` Peter Zijlstra
2012-05-15 10:08 ` Mel Gorman
2012-05-15 10:08 ` Mel Gorman
2012-05-15 10:08 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 02/12] selinux: tag avc cache alloc as non-critical Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 14:14 ` Casey Schaufler [this message]
2012-05-10 14:14 ` Casey Schaufler
2012-05-10 14:14 ` Casey Schaufler
2012-05-10 14:25 ` Eric Paris
2012-05-10 14:25 ` Eric Paris
2012-05-10 13:54 ` [PATCH 03/12] mm: Methods for teaching filesystems about PG_swapcache pages Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 04/12] mm: Add support for a filesystem to activate swap files and use direct_IO for writing swap pages Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 05/12] mm: swap: Implement generic handler for swap_activate Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 06/12] mm: Add get_kernel_page[s] for pinning of kernel addresses for I/O Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 07/12] mm: Add support for direct_IO to highmem pages Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 08/12] nfs: teach the NFS client how to treat PG_swapcache pages Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 09/12] nfs: disable data cache revalidation for swapfiles Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 10/12] nfs: enable swap on NFS Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 11/12] nfs: Prevent page allocator recursions with swap over NFS Mel Gorman
2012-05-10 13:54 ` Mel Gorman
2012-05-10 13:54 ` [PATCH 12/12] Avoid dereferencing bd_disk during swap_entry_free for network storage Mel Gorman
2012-05-10 13:54 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2012-05-17 14:51 [PATCH 00/12] Swap-over-NFS without deadlocking V5 Mel Gorman
2012-05-17 14:51 ` [PATCH 02/12] selinux: tag avc cache alloc as non-critical Mel Gorman
2012-05-17 14:51 ` Mel Gorman
2012-06-20 9:37 [PATCH 00/12] Swap-over-NFS without deadlocking V6 Mel Gorman
2012-06-20 9:37 ` [PATCH 02/12] selinux: tag avc cache alloc as non-critical Mel Gorman
2012-06-20 9:37 ` Mel Gorman
2012-06-20 15:33 ` Rik van Riel
2012-06-20 15:33 ` Rik van Riel
2012-06-22 14:30 [PATCH 00/12] Swap-over-NFS without deadlocking V7 Mel Gorman
2012-06-22 14:30 ` [PATCH 02/12] selinux: tag avc cache alloc as non-critical Mel Gorman
2012-06-22 14:30 ` Mel Gorman
2012-06-29 13:33 [PATCH 00/12] Swap-over-NFS without deadlocking V8 Mel Gorman
2012-06-29 13:33 ` [PATCH 02/12] selinux: tag avc cache alloc as non-critical Mel Gorman
2012-06-29 13:33 ` Mel Gorman
2012-07-12 6:40 [PATCH 00/12] Swap-over-NFS without deadlocking V9 Mel Gorman
2012-07-12 6:40 ` [PATCH 02/12] selinux: tag avc cache alloc as non-critical Mel Gorman
2012-07-12 6:40 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FABCD55.9000504@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=Trond.Myklebust@netapp.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=emunson@mgebm.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=michaelc@cs.wisc.edu \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.