From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: potential NULL dereference on error
Date: Tue, 15 May 2012 06:13:51 +0000 [thread overview]
Message-ID: <20120515061351.GI16984@mwanda> (raw)
In-Reply-To: <20120514222535.GW5353@quack.suse.cz>
On Tue, May 15, 2012 at 12:25:35AM +0200, Jan Kara wrote:
> On Sun 13-05-12 17:41:04, Dan Carpenter wrote:
> > @@ -508,7 +509,8 @@ fallback_retry:
> > for (i = 0; i < ngroups; i++) {
> > grp = (parent_group + i) % ngroups;
> > desc = ext4_get_group_desc(sb, grp, NULL);
> > - grp_free = ext4_free_inodes_count(sb, desc);
> > + if (desc)
> > + grp_free = ext4_free_inodes_count(sb, desc);
> > if (desc && grp_free && grp_free >= avefreei) {
> So you it would be more logical to do:
> if (desc) {
> grp_free = ext4_free_inodes_count(sb, desc);
> if (grp_free && grpfree >= avefreei) {
> *group = grp;
> return 0;
> }
> }
>
> Wouldn't it?
Yeah. You're obviously right. I'll resend.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: potential NULL dereference on error
Date: Tue, 15 May 2012 09:13:51 +0300 [thread overview]
Message-ID: <20120515061351.GI16984@mwanda> (raw)
In-Reply-To: <20120514222535.GW5353@quack.suse.cz>
On Tue, May 15, 2012 at 12:25:35AM +0200, Jan Kara wrote:
> On Sun 13-05-12 17:41:04, Dan Carpenter wrote:
> > @@ -508,7 +509,8 @@ fallback_retry:
> > for (i = 0; i < ngroups; i++) {
> > grp = (parent_group + i) % ngroups;
> > desc = ext4_get_group_desc(sb, grp, NULL);
> > - grp_free = ext4_free_inodes_count(sb, desc);
> > + if (desc)
> > + grp_free = ext4_free_inodes_count(sb, desc);
> > if (desc && grp_free && grp_free >= avefreei) {
> So you it would be more logical to do:
> if (desc) {
> grp_free = ext4_free_inodes_count(sb, desc);
> if (grp_free && grpfree >= avefreei) {
> *group = grp;
> return 0;
> }
> }
>
> Wouldn't it?
Yeah. You're obviously right. I'll resend.
regards,
dan carpenter
next prev parent reply other threads:[~2012-05-15 6:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 14:41 [patch] ext4: potential NULL dereference on error Dan Carpenter
2012-05-13 14:41 ` Dan Carpenter
2012-05-14 22:25 ` Jan Kara
2012-05-14 22:25 ` Jan Kara
2012-05-15 6:13 ` Dan Carpenter [this message]
2012-05-15 6:13 ` Dan Carpenter
2012-05-15 8:46 ` [patch v2] " Dan Carpenter
2012-05-15 8:46 ` Dan Carpenter
2012-05-15 10:01 ` Jan Kara
2012-05-15 10:01 ` Jan Kara
2012-05-28 15:01 ` Ted Ts'o
2012-05-28 15:01 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515061351.GI16984@mwanda \
--to=dan.carpenter@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.