All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] ext4: potential NULL dereference on error
Date: Mon, 28 May 2012 15:01:43 +0000	[thread overview]
Message-ID: <20120528150143.GG19152@thunk.org> (raw)
In-Reply-To: <20120515084640.GB30265@elgon.mountain>

On Tue, May 15, 2012 at 11:46:40AM +0300, Dan Carpenter wrote:
> The ext4_get_group_desc() function returns NULL on error, and
> ext4_free_inodes_count() function dereferences it without checking.
> There is a check on the next line, but it's too late.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.

					- Ted

WARNING: multiple messages have this Message-ID (diff)
From: Ted Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] ext4: potential NULL dereference on error
Date: Mon, 28 May 2012 11:01:43 -0400	[thread overview]
Message-ID: <20120528150143.GG19152@thunk.org> (raw)
In-Reply-To: <20120515084640.GB30265@elgon.mountain>

On Tue, May 15, 2012 at 11:46:40AM +0300, Dan Carpenter wrote:
> The ext4_get_group_desc() function returns NULL on error, and
> ext4_free_inodes_count() function dereferences it without checking.
> There is a check on the next line, but it's too late.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.

					- Ted

  parent reply	other threads:[~2012-05-28 15:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-13 14:41 [patch] ext4: potential NULL dereference on error Dan Carpenter
2012-05-13 14:41 ` Dan Carpenter
2012-05-14 22:25 ` Jan Kara
2012-05-14 22:25   ` Jan Kara
2012-05-15  6:13   ` Dan Carpenter
2012-05-15  6:13     ` Dan Carpenter
2012-05-15  8:46   ` [patch v2] " Dan Carpenter
2012-05-15  8:46     ` Dan Carpenter
2012-05-15 10:01     ` Jan Kara
2012-05-15 10:01       ` Jan Kara
2012-05-28 15:01     ` Ted Ts'o [this message]
2012-05-28 15:01       ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120528150143.GG19152@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=dan.carpenter@oracle.com \
    --cc=jack@suse.cz \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.