[PATCH] Trivial sched: Pass domain_attr to build_sched_domains()

[PATCH] Trivial sched: Pass domain_attr to build_sched_domains()

[Kamalesh Babulal]

sched: Pass domain_attr to build_sched_domains()

build_sched_domains() is called from init_sched_domains()
by explicitly passing NULL as second argument, which is
of type sched_domain_attr. This patch calls build_sched_domains()
with dattr_cur instead of NULL, as dattr_cur is also NULL.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 22a19ae..32ccf13 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6735,7 +6735,7 @@ static int init_sched_domains(const struct cpumask *cpu_map)
 		doms_cur = &fallback_doms;
 	cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);
 	dattr_cur = NULL;
-	err = build_sched_domains(doms_cur[0], NULL);
+	err = build_sched_domains(doms_cur[0], dattr_cur);
 	register_sched_domain_sysctl();

 	return err;

Re: [PATCH] Trivial sched: Pass domain_attr to build_sched_domains()

[Peter Zijlstra]

On Wed, 2012-05-23 at 12:11 +0530, Kamalesh Babulal wrote:
> sched: Pass domain_attr to build_sched_domains()
> 
> build_sched_domains() is called from init_sched_domains()
> by explicitly passing NULL as second argument, which is
> of type sched_domain_attr. This patch calls build_sched_domains()
> with dattr_cur instead of NULL, as dattr_cur is also NULL.

So what's the point? Rather clean up the dattr crap, no?

> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 22a19ae..32ccf13 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6735,7 +6735,7 @@ static int init_sched_domains(const struct cpumask *cpu_map)
>  		doms_cur = &fallback_doms;
>  	cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);
>  	dattr_cur = NULL;
> -	err = build_sched_domains(doms_cur[0], NULL);
> +	err = build_sched_domains(doms_cur[0], dattr_cur);
>  	register_sched_domain_sysctl();
> 
>  	return err;
> 

Re: [PATCH] Trivial sched: Pass domain_attr to build_sched_domains()

[Kamalesh Babulal]

* Peter Zijlstra <peterz@infradead.org> [2012-05-23 09:48:58]:

> On Wed, 2012-05-23 at 12:11 +0530, Kamalesh Babulal wrote:
> > sched: Pass domain_attr to build_sched_domains()
> > 
> > build_sched_domains() is called from init_sched_domains()
> > by explicitly passing NULL as second argument, which is
> > of type sched_domain_attr. This patch calls build_sched_domains()
> > with dattr_cur instead of NULL, as dattr_cur is also NULL.
> 
> So what's the point? Rather clean up the dattr crap, no?

Thanks for the review.

As suggested, this version of patch drops dattr_cur from
init_sched_domains().

sched: Remove NULL assignment to dattr_cur

Remove explicit NULL assignment of static pointer
dattr_cur from init_sched_domains().

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---
 kernel/sched/core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 22a19ae..964bf9d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6734,7 +6734,6 @@ static int init_sched_domains(const struct cpumask *cpu_map)
 	if (!doms_cur)
 		doms_cur = &fallback_doms;
 	cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);
-	dattr_cur = NULL;
 	err = build_sched_domains(doms_cur[0], NULL);
 	register_sched_domain_sysctl();

[tip:sched/urgent] sched: Remove NULL assignment of dattr_cur

[tip-bot for Kamalesh Babulal]

Commit-ID:  6a4c96eef42f835734a82c6b512abf9881b7c55d
Gitweb:     http://git.kernel.org/tip/6a4c96eef42f835734a82c6b512abf9881b7c55d
Author:     Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
AuthorDate: Wed, 23 May 2012 14:44:11 +0530
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 30 May 2012 14:02:27 +0200

sched: Remove NULL assignment of dattr_cur

Remove explicit NULL assignment of static pointer
dattr_cur from init_sched_domains().

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20120523091411.GG5005@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 94d598a..c46958e 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6726,7 +6726,6 @@ static int init_sched_domains(const struct cpumask *cpu_map)
 	if (!doms_cur)
 		doms_cur = &fallback_doms;
 	cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);
-	dattr_cur = NULL;
 	err = build_sched_domains(doms_cur[0], NULL);
 	register_sched_domain_sysctl();