From: Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>
To: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Cc: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>,
James Bottomley
<James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>,
David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Pekka Enberg <penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org>
Subject: Re: [PATCH] slab+slob: dup name string
Date: Thu, 24 May 2012 10:18:31 +1000 [thread overview]
Message-ID: <20120524001831.GQ25351@dastard> (raw)
In-Reply-To: <4FBCF951.3040105-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
On Wed, May 23, 2012 at 06:50:57PM +0400, Glauber Costa wrote:
> On 05/23/2012 06:48 PM, Christoph Lameter wrote:
> >On Wed, 23 May 2012, James Bottomley wrote:
> >
> >>>>So, why not simply patch slab to rely on the string lifetime being the
> >>>>cache lifetime (or beyond) and therefore not having it take a copy?
> >
> >Well thats they way it was for a long time. There must be some reason that
> >someone started to add this copying business.... Pekka?
> >
> The question is less why we added, but rather why we're keeping.
>
> Of course reasoning about why it was added helps (so let's try to
> determine that), but so far the only reasonably strong argument in
> favor of keeping it was robustness.
I'm pretty sure it was added because there are slab names
constructed by snprintf on a stack buffer, so the name doesn't exist
beyond the slab initialisation function call...
Cheers,
Dave.
--
Dave Chinner
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Christoph Lameter <cl@linux.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] slab+slob: dup name string
Date: Thu, 24 May 2012 10:18:31 +1000 [thread overview]
Message-ID: <20120524001831.GQ25351@dastard> (raw)
In-Reply-To: <4FBCF951.3040105@parallels.com>
On Wed, May 23, 2012 at 06:50:57PM +0400, Glauber Costa wrote:
> On 05/23/2012 06:48 PM, Christoph Lameter wrote:
> >On Wed, 23 May 2012, James Bottomley wrote:
> >
> >>>>So, why not simply patch slab to rely on the string lifetime being the
> >>>>cache lifetime (or beyond) and therefore not having it take a copy?
> >
> >Well thats they way it was for a long time. There must be some reason that
> >someone started to add this copying business.... Pekka?
> >
> The question is less why we added, but rather why we're keeping.
>
> Of course reasoning about why it was added helps (so let's try to
> determine that), but so far the only reasonably strong argument in
> favor of keeping it was robustness.
I'm pretty sure it was added because there are slab names
constructed by snprintf on a stack buffer, so the name doesn't exist
beyond the slab initialisation function call...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Christoph Lameter <cl@linux.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] slab+slob: dup name string
Date: Thu, 24 May 2012 10:18:31 +1000 [thread overview]
Message-ID: <20120524001831.GQ25351@dastard> (raw)
In-Reply-To: <4FBCF951.3040105@parallels.com>
On Wed, May 23, 2012 at 06:50:57PM +0400, Glauber Costa wrote:
> On 05/23/2012 06:48 PM, Christoph Lameter wrote:
> >On Wed, 23 May 2012, James Bottomley wrote:
> >
> >>>>So, why not simply patch slab to rely on the string lifetime being the
> >>>>cache lifetime (or beyond) and therefore not having it take a copy?
> >
> >Well thats they way it was for a long time. There must be some reason that
> >someone started to add this copying business.... Pekka?
> >
> The question is less why we added, but rather why we're keeping.
>
> Of course reasoning about why it was added helps (so let's try to
> determine that), but so far the only reasonably strong argument in
> favor of keeping it was robustness.
I'm pretty sure it was added because there are slab names
constructed by snprintf on a stack buffer, so the name doesn't exist
beyond the slab initialisation function call...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2012-05-24 0:18 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 15:18 [PATCH] slab+slob: dup name string Glauber Costa
2012-05-21 15:18 ` Glauber Costa
[not found] ` <1337613539-29108-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-05-21 15:35 ` Christoph Lameter
2012-05-21 15:35 ` Christoph Lameter
2012-05-21 15:35 ` Christoph Lameter
2012-05-22 3:22 ` David Rientjes
2012-05-22 3:22 ` David Rientjes
2012-05-22 7:23 ` Glauber Costa
2012-05-22 7:23 ` Glauber Costa
2012-05-22 9:45 ` Glauber Costa
2012-05-22 9:45 ` Glauber Costa
2012-05-22 13:56 ` Christoph Lameter
2012-05-22 13:56 ` Christoph Lameter
2012-05-22 15:19 ` Glauber Costa
2012-05-22 15:19 ` Glauber Costa
[not found] ` <4FBBAE95.6080608-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-05-22 17:16 ` Christoph Lameter
2012-05-22 17:16 ` Christoph Lameter
2012-05-22 17:16 ` Christoph Lameter
2012-05-22 22:31 ` David Rientjes
2012-05-22 22:31 ` David Rientjes
2012-05-23 11:46 ` James Bottomley
2012-05-23 11:46 ` James Bottomley
2012-05-23 12:08 ` Glauber Costa
2012-05-23 12:08 ` Glauber Costa
[not found] ` <4FBCD328.6060406-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-05-23 12:24 ` James Bottomley
2012-05-23 12:24 ` James Bottomley
2012-05-23 12:24 ` James Bottomley
2012-05-23 14:48 ` Christoph Lameter
2012-05-23 14:48 ` Christoph Lameter
[not found] ` <alpine.DEB.2.00.1205230947490.30940-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
2012-05-23 14:50 ` Glauber Costa
2012-05-23 14:50 ` Glauber Costa
2012-05-23 14:50 ` Glauber Costa
[not found] ` <4FBCF951.3040105-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-05-24 0:18 ` Dave Chinner [this message]
2012-05-24 0:18 ` Dave Chinner
2012-05-24 0:18 ` Dave Chinner
2012-05-24 12:06 ` Glauber Costa
2012-05-24 12:06 ` Glauber Costa
2012-05-23 15:01 ` Glauber Costa
2012-05-23 15:01 ` Glauber Costa
[not found] ` <4FBCFBE0.2080803-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-05-23 15:17 ` Christoph Lameter
2012-05-23 15:17 ` Christoph Lameter
2012-05-23 15:17 ` Christoph Lameter
[not found] ` <alpine.DEB.2.00.1205231012330.30940-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
2012-05-23 15:15 ` Glauber Costa
2012-05-23 15:15 ` Glauber Costa
2012-05-23 15:15 ` Glauber Costa
2012-05-23 13:48 ` Christoph Lameter
2012-05-23 13:48 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524001831.GQ25351@dastard \
--to=david-fqsqvqoi3ljby3ivrkzq2a@public.gmane.org \
--cc=James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org \
--cc=rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.