From: Glauber Costa <glommer@parallels.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Lameter <cl@linux.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] slab+slob: dup name string
Date: Thu, 24 May 2012 16:06:23 +0400 [thread overview]
Message-ID: <4FBE243F.3080002@parallels.com> (raw)
In-Reply-To: <20120524001831.GQ25351@dastard>
On 05/24/2012 04:18 AM, Dave Chinner wrote:
>> Of course reasoning about why it was added helps (so let's try to
>> > determine that), but so far the only reasonably strong argument in
>> > favor of keeping it was robustness.
> I'm pretty sure it was added because there are slab names
> constructed by snprintf on a stack buffer, so the name doesn't exist
> beyond the slab initialisation function call...
>
> Cheers,
>
> Dave.
If that was the reason, we'd be seeing slab failing miserably where slub
succeeds, since slab keeps no copy.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Lameter <cl@linux.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
David Rientjes <rientjes@google.com>,
<linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
<linux-mm@kvack.org>, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] slab+slob: dup name string
Date: Thu, 24 May 2012 16:06:23 +0400 [thread overview]
Message-ID: <4FBE243F.3080002@parallels.com> (raw)
In-Reply-To: <20120524001831.GQ25351@dastard>
On 05/24/2012 04:18 AM, Dave Chinner wrote:
>> Of course reasoning about why it was added helps (so let's try to
>> > determine that), but so far the only reasonably strong argument in
>> > favor of keeping it was robustness.
> I'm pretty sure it was added because there are slab names
> constructed by snprintf on a stack buffer, so the name doesn't exist
> beyond the slab initialisation function call...
>
> Cheers,
>
> Dave.
If that was the reason, we'd be seeing slab failing miserably where slub
succeeds, since slab keeps no copy.
next prev parent reply other threads:[~2012-05-24 12:06 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 15:18 [PATCH] slab+slob: dup name string Glauber Costa
2012-05-21 15:18 ` Glauber Costa
[not found] ` <1337613539-29108-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-05-21 15:35 ` Christoph Lameter
2012-05-21 15:35 ` Christoph Lameter
2012-05-21 15:35 ` Christoph Lameter
2012-05-22 3:22 ` David Rientjes
2012-05-22 3:22 ` David Rientjes
2012-05-22 7:23 ` Glauber Costa
2012-05-22 7:23 ` Glauber Costa
2012-05-22 9:45 ` Glauber Costa
2012-05-22 9:45 ` Glauber Costa
2012-05-22 13:56 ` Christoph Lameter
2012-05-22 13:56 ` Christoph Lameter
2012-05-22 15:19 ` Glauber Costa
2012-05-22 15:19 ` Glauber Costa
[not found] ` <4FBBAE95.6080608-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-05-22 17:16 ` Christoph Lameter
2012-05-22 17:16 ` Christoph Lameter
2012-05-22 17:16 ` Christoph Lameter
2012-05-22 22:31 ` David Rientjes
2012-05-22 22:31 ` David Rientjes
2012-05-23 11:46 ` James Bottomley
2012-05-23 11:46 ` James Bottomley
2012-05-23 12:08 ` Glauber Costa
2012-05-23 12:08 ` Glauber Costa
[not found] ` <4FBCD328.6060406-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-05-23 12:24 ` James Bottomley
2012-05-23 12:24 ` James Bottomley
2012-05-23 12:24 ` James Bottomley
2012-05-23 14:48 ` Christoph Lameter
2012-05-23 14:48 ` Christoph Lameter
[not found] ` <alpine.DEB.2.00.1205230947490.30940-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
2012-05-23 14:50 ` Glauber Costa
2012-05-23 14:50 ` Glauber Costa
2012-05-23 14:50 ` Glauber Costa
[not found] ` <4FBCF951.3040105-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-05-24 0:18 ` Dave Chinner
2012-05-24 0:18 ` Dave Chinner
2012-05-24 0:18 ` Dave Chinner
2012-05-24 12:06 ` Glauber Costa [this message]
2012-05-24 12:06 ` Glauber Costa
2012-05-23 15:01 ` Glauber Costa
2012-05-23 15:01 ` Glauber Costa
[not found] ` <4FBCFBE0.2080803-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-05-23 15:17 ` Christoph Lameter
2012-05-23 15:17 ` Christoph Lameter
2012-05-23 15:17 ` Christoph Lameter
[not found] ` <alpine.DEB.2.00.1205231012330.30940-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
2012-05-23 15:15 ` Glauber Costa
2012-05-23 15:15 ` Glauber Costa
2012-05-23 15:15 ` Glauber Costa
2012-05-23 13:48 ` Christoph Lameter
2012-05-23 13:48 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE243F.3080002@parallels.com \
--to=glommer@parallels.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.