From: Andi Kleen <andi@firstfloor.org>
To: Christoph Lameter <cl@linux.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
kosaki.motohiro@gmail.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andrew Morton <akpm@google.com>,
Dave Jones <davej@redhat.com>, Mel Gorman <mgorman@suse.de>,
stable@vger.kernel.org, hughd@google.com, sivanich@sgi.com,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 0/6] mempolicy memory corruption fixlet
Date: Wed, 30 May 2012 21:52:44 +0200 [thread overview]
Message-ID: <20120530195244.GX27374@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1205301441350.31768@router.home>
On Wed, May 30, 2012 at 02:42:42PM -0500, Christoph Lameter wrote:
> On Wed, 30 May 2012, Andi Kleen wrote:
>
> > On Wed, May 30, 2012 at 01:50:02PM -0500, Christoph Lameter wrote:
> > > On Wed, 30 May 2012, Andi Kleen wrote:
> > >
> > > > I always regretted that cpusets were no done with custom node lists.
> > > > That would have been much cleaner and also likely faster than what we have.
> > >
> > > Could shared memory policies ignore cpuset constraints?
> >
> > Only if noone uses cpusets as a "security" mechanism, just for a "soft policy"
> > Even with soft policy you could well break someone's setup.
>
> Well at least lets exempt shared memory from memory migration and memory
> policy updates. That seems to be causing many of these issues.
Migration on the page level is needed for the memory error handling.
Updates: you mean not allowing to set the policy when there are already
multiple mappers? I could see that causing some unexpected behaviour. Presumably
a standard database will only set it at the beginning, but I don't know
if that would work for all users.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Christoph Lameter <cl@linux.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
kosaki.motohiro@gmail.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andrew Morton <akpm@google.com>,
Dave Jones <davej@redhat.com>, Mel Gorman <mgorman@suse.de>,
stable@vger.kernel.org, hughd@google.com, sivanich@sgi.com,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 0/6] mempolicy memory corruption fixlet
Date: Wed, 30 May 2012 21:52:44 +0200 [thread overview]
Message-ID: <20120530195244.GX27374@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1205301441350.31768@router.home>
On Wed, May 30, 2012 at 02:42:42PM -0500, Christoph Lameter wrote:
> On Wed, 30 May 2012, Andi Kleen wrote:
>
> > On Wed, May 30, 2012 at 01:50:02PM -0500, Christoph Lameter wrote:
> > > On Wed, 30 May 2012, Andi Kleen wrote:
> > >
> > > > I always regretted that cpusets were no done with custom node lists.
> > > > That would have been much cleaner and also likely faster than what we have.
> > >
> > > Could shared memory policies ignore cpuset constraints?
> >
> > Only if noone uses cpusets as a "security" mechanism, just for a "soft policy"
> > Even with soft policy you could well break someone's setup.
>
> Well at least lets exempt shared memory from memory migration and memory
> policy updates. That seems to be causing many of these issues.
Migration on the page level is needed for the memory error handling.
Updates: you mean not allowing to set the policy when there are already
multiple mappers? I could see that causing some unexpected behaviour. Presumably
a standard database will only set it at the beginning, but I don't know
if that would work for all users.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2012-05-30 19:52 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 9:02 [PATCH 0/6] mempolicy memory corruption fixlet kosaki.motohiro
2012-05-30 9:02 ` kosaki.motohiro
2012-05-30 9:02 ` [PATCH 1/6] Revert "mm: mempolicy: Let vma_merge and vma_split handle vma->vm_policy linkages" kosaki.motohiro
2012-05-30 9:02 ` kosaki.motohiro
2012-05-30 19:17 ` Christoph Lameter
2012-05-30 19:17 ` Christoph Lameter
2012-05-30 19:39 ` KOSAKI Motohiro
2012-05-30 19:39 ` KOSAKI Motohiro
2012-05-30 19:39 ` KOSAKI Motohiro
2012-05-30 19:44 ` Christoph Lameter
2012-05-30 19:44 ` Christoph Lameter
2012-05-31 6:49 ` KOSAKI Motohiro
2012-05-31 6:49 ` KOSAKI Motohiro
2012-05-30 9:02 ` [PATCH 2/6] mempolicy: Kill all mempolicy sharing kosaki.motohiro
2012-05-30 9:02 ` kosaki.motohiro
2012-05-30 19:41 ` Christoph Lameter
2012-05-30 19:41 ` Christoph Lameter
2012-05-30 19:46 ` KOSAKI Motohiro
2012-05-30 19:46 ` KOSAKI Motohiro
2012-05-30 19:48 ` Andi Kleen
2012-05-30 19:48 ` Andi Kleen
2012-05-30 20:31 ` Andi Kleen
2012-05-30 20:31 ` Andi Kleen
2012-05-30 20:58 ` KOSAKI Motohiro
2012-05-30 20:58 ` KOSAKI Motohiro
2012-05-30 9:02 ` [PATCH 3/6] mempolicy: fix a race in shared_policy_replace() kosaki.motohiro
2012-05-30 9:02 ` kosaki.motohiro
2012-05-30 9:02 ` [PATCH 4/6] mempolicy: fix refcount leak in mpol_set_shared_policy() kosaki.motohiro
2012-05-30 9:02 ` kosaki.motohiro
2012-05-30 9:02 ` [PATCH 5/6] mempolicy: fix a memory corruption by refcount imbalance in alloc_pages_vma() kosaki.motohiro
2012-05-30 9:02 ` kosaki.motohiro
2012-05-30 20:37 ` Andi Kleen
2012-05-30 20:37 ` Andi Kleen
2012-05-30 9:02 ` [PATCH 6/6] MAINTAINERS: Added MEMPOLICY entry kosaki.motohiro
2012-05-30 9:02 ` kosaki.motohiro
2012-05-30 19:27 ` Christoph Lameter
2012-05-30 19:27 ` Christoph Lameter
2012-05-30 18:26 ` [PATCH 0/6] mempolicy memory corruption fixlet Linus Torvalds
2012-05-30 18:26 ` Linus Torvalds
2012-05-30 18:34 ` Christoph Lameter
2012-05-30 18:34 ` Christoph Lameter
2012-05-30 18:46 ` Andi Kleen
2012-05-30 18:46 ` Andi Kleen
2012-05-30 18:50 ` Christoph Lameter
2012-05-30 18:50 ` Christoph Lameter
2012-05-30 19:32 ` Andi Kleen
2012-05-30 19:32 ` Andi Kleen
2012-05-30 19:42 ` Christoph Lameter
2012-05-30 19:42 ` Christoph Lameter
2012-05-30 19:52 ` Andi Kleen [this message]
2012-05-30 19:52 ` Andi Kleen
2012-05-30 20:00 ` KOSAKI Motohiro
2012-05-30 20:00 ` KOSAKI Motohiro
2012-05-30 21:22 ` Ben Hutchings
2012-05-30 21:22 ` Ben Hutchings
2012-05-30 21:25 ` KOSAKI Motohiro
2012-05-30 21:25 ` KOSAKI Motohiro
2012-05-30 19:54 ` KOSAKI Motohiro
2012-05-30 19:54 ` KOSAKI Motohiro
2012-05-30 20:10 ` Andi Kleen
2012-05-30 20:10 ` Andi Kleen
2012-05-30 20:16 ` KOSAKI Motohiro
2012-05-30 20:16 ` KOSAKI Motohiro
2012-06-01 0:45 ` david
2012-06-01 0:45 ` david
2012-06-01 13:51 ` Christoph Lameter
2012-06-01 13:51 ` Christoph Lameter
2012-06-01 19:31 ` david
2012-06-01 19:31 ` david
2012-06-01 19:37 ` KOSAKI Motohiro
2012-06-01 19:37 ` KOSAKI Motohiro
2012-06-05 19:02 ` Linus Torvalds
2012-06-05 19:02 ` Linus Torvalds
2012-06-05 19:17 ` Andrew Morton
2012-06-05 19:17 ` Andrew Morton
2012-06-06 19:10 ` KOSAKI Motohiro
2012-06-06 19:10 ` KOSAKI Motohiro
2012-05-30 19:03 ` Linus Torvalds
2012-05-30 19:03 ` Linus Torvalds
2012-05-30 20:10 ` KOSAKI Motohiro
2012-05-30 20:10 ` KOSAKI Motohiro
2012-05-30 20:10 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530195244.GX27374@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@google.com \
--cc=cl@linux.com \
--cc=davej@redhat.com \
--cc=hughd@google.com \
--cc=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=sivanich@sgi.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.