All of lore.kernel.org
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@google.com>, Dave Jones <davej@redhat.com>,
	Mel Gorman <mgorman@suse.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	stable@vger.kernel.org, hughd@google.com,
	Andrew Morton <akpm@linux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 1/6] Revert "mm: mempolicy: Let vma_merge and vma_split handle vma->vm_policy linkages"
Date: Thu, 31 May 2012 02:49:58 -0400	[thread overview]
Message-ID: <4FC71496.8050707@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205301414020.31768@router.home>

(5/30/12 3:17 PM), Christoph Lameter wrote:
> On Wed, 30 May 2012, kosaki.motohiro@gmail.com wrote:
>
>> From: KOSAKI Motohiro<kosaki.motohiro@gmail.com>
>>
>> commit 05f144a0d5 removed vma->vm_policy updates code and it is a purpose of
>> mbind_range(). Now, mbind_range() is virtually no-op. no-op function don't
>> makes any bugs, I agree. but maybe it is not right fix.
>
> I dont really understand the changelog. But to restore the policy_vma() is
> the right thing to do since there are potential multiple use cases where
> we want to apply a policy to a vma.
>
> Proposed new changelog:
>
> Commit 05f144a0d5 folded policy_vma() into mbind_range(). There are
> other use cases of policy_vma(*) though and so revert a piece of
> that commit in order to have a policy_vma() function again.

sorry, I overlooked this. Commit 05f144a0d5 don't work neither regular vma
nor shmem vma. thus I can't take this proposal. sorry.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@google.com>, Dave Jones <davej@redhat.com>,
	Mel Gorman <mgorman@suse.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	stable@vger.kernel.org, hughd@google.com,
	Andrew Morton <akpm@linux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 1/6] Revert "mm: mempolicy: Let vma_merge and vma_split handle vma->vm_policy linkages"
Date: Thu, 31 May 2012 02:49:58 -0400	[thread overview]
Message-ID: <4FC71496.8050707@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205301414020.31768@router.home>

(5/30/12 3:17 PM), Christoph Lameter wrote:
> On Wed, 30 May 2012, kosaki.motohiro@gmail.com wrote:
>
>> From: KOSAKI Motohiro<kosaki.motohiro@gmail.com>
>>
>> commit 05f144a0d5 removed vma->vm_policy updates code and it is a purpose of
>> mbind_range(). Now, mbind_range() is virtually no-op. no-op function don't
>> makes any bugs, I agree. but maybe it is not right fix.
>
> I dont really understand the changelog. But to restore the policy_vma() is
> the right thing to do since there are potential multiple use cases where
> we want to apply a policy to a vma.
>
> Proposed new changelog:
>
> Commit 05f144a0d5 folded policy_vma() into mbind_range(). There are
> other use cases of policy_vma(*) though and so revert a piece of
> that commit in order to have a policy_vma() function again.

sorry, I overlooked this. Commit 05f144a0d5 don't work neither regular vma
nor shmem vma. thus I can't take this proposal. sorry.

  parent reply	other threads:[~2012-05-31  6:50 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30  9:02 [PATCH 0/6] mempolicy memory corruption fixlet kosaki.motohiro
2012-05-30  9:02 ` kosaki.motohiro
2012-05-30  9:02 ` [PATCH 1/6] Revert "mm: mempolicy: Let vma_merge and vma_split handle vma->vm_policy linkages" kosaki.motohiro
2012-05-30  9:02   ` kosaki.motohiro
2012-05-30 19:17   ` Christoph Lameter
2012-05-30 19:17     ` Christoph Lameter
2012-05-30 19:39     ` KOSAKI Motohiro
2012-05-30 19:39       ` KOSAKI Motohiro
2012-05-30 19:39       ` KOSAKI Motohiro
2012-05-30 19:44       ` Christoph Lameter
2012-05-30 19:44         ` Christoph Lameter
2012-05-31  6:49     ` KOSAKI Motohiro [this message]
2012-05-31  6:49       ` KOSAKI Motohiro
2012-05-30  9:02 ` [PATCH 2/6] mempolicy: Kill all mempolicy sharing kosaki.motohiro
2012-05-30  9:02   ` kosaki.motohiro
2012-05-30 19:41   ` Christoph Lameter
2012-05-30 19:41     ` Christoph Lameter
2012-05-30 19:46     ` KOSAKI Motohiro
2012-05-30 19:46       ` KOSAKI Motohiro
2012-05-30 19:48     ` Andi Kleen
2012-05-30 19:48       ` Andi Kleen
2012-05-30 20:31   ` Andi Kleen
2012-05-30 20:31     ` Andi Kleen
2012-05-30 20:58     ` KOSAKI Motohiro
2012-05-30 20:58       ` KOSAKI Motohiro
2012-05-30  9:02 ` [PATCH 3/6] mempolicy: fix a race in shared_policy_replace() kosaki.motohiro
2012-05-30  9:02   ` kosaki.motohiro
2012-05-30  9:02 ` [PATCH 4/6] mempolicy: fix refcount leak in mpol_set_shared_policy() kosaki.motohiro
2012-05-30  9:02   ` kosaki.motohiro
2012-05-30  9:02 ` [PATCH 5/6] mempolicy: fix a memory corruption by refcount imbalance in alloc_pages_vma() kosaki.motohiro
2012-05-30  9:02   ` kosaki.motohiro
2012-05-30 20:37   ` Andi Kleen
2012-05-30 20:37     ` Andi Kleen
2012-05-30  9:02 ` [PATCH 6/6] MAINTAINERS: Added MEMPOLICY entry kosaki.motohiro
2012-05-30  9:02   ` kosaki.motohiro
2012-05-30 19:27   ` Christoph Lameter
2012-05-30 19:27     ` Christoph Lameter
2012-05-30 18:26 ` [PATCH 0/6] mempolicy memory corruption fixlet Linus Torvalds
2012-05-30 18:26   ` Linus Torvalds
2012-05-30 18:34   ` Christoph Lameter
2012-05-30 18:34     ` Christoph Lameter
2012-05-30 18:46     ` Andi Kleen
2012-05-30 18:46       ` Andi Kleen
2012-05-30 18:50       ` Christoph Lameter
2012-05-30 18:50         ` Christoph Lameter
2012-05-30 19:32         ` Andi Kleen
2012-05-30 19:32           ` Andi Kleen
2012-05-30 19:42           ` Christoph Lameter
2012-05-30 19:42             ` Christoph Lameter
2012-05-30 19:52             ` Andi Kleen
2012-05-30 19:52               ` Andi Kleen
2012-05-30 20:00               ` KOSAKI Motohiro
2012-05-30 20:00                 ` KOSAKI Motohiro
2012-05-30 21:22                 ` Ben Hutchings
2012-05-30 21:22                   ` Ben Hutchings
2012-05-30 21:25                   ` KOSAKI Motohiro
2012-05-30 21:25                     ` KOSAKI Motohiro
2012-05-30 19:54             ` KOSAKI Motohiro
2012-05-30 19:54               ` KOSAKI Motohiro
2012-05-30 20:10               ` Andi Kleen
2012-05-30 20:10                 ` Andi Kleen
2012-05-30 20:16                 ` KOSAKI Motohiro
2012-05-30 20:16                   ` KOSAKI Motohiro
2012-06-01  0:45                   ` david
2012-06-01  0:45                     ` david
2012-06-01 13:51                     ` Christoph Lameter
2012-06-01 13:51                       ` Christoph Lameter
2012-06-01 19:31                       ` david
2012-06-01 19:31                         ` david
2012-06-01 19:37                         ` KOSAKI Motohiro
2012-06-01 19:37                           ` KOSAKI Motohiro
2012-06-05 19:02                           ` Linus Torvalds
2012-06-05 19:02                             ` Linus Torvalds
2012-06-05 19:17                             ` Andrew Morton
2012-06-05 19:17                               ` Andrew Morton
2012-06-06 19:10                               ` KOSAKI Motohiro
2012-06-06 19:10                                 ` KOSAKI Motohiro
2012-05-30 19:03     ` Linus Torvalds
2012-05-30 19:03       ` Linus Torvalds
2012-05-30 20:10   ` KOSAKI Motohiro
2012-05-30 20:10     ` KOSAKI Motohiro
2012-05-30 20:10     ` KOSAKI Motohiro
  -- strict thread matches above, loose matches on Subject: below --
2012-06-11  9:17 [PATCH 0/6][resend] " kosaki.motohiro
2012-06-11  9:17 ` [PATCH 1/6] Revert "mm: mempolicy: Let vma_merge and vma_split handle vma->vm_policy linkages" kosaki.motohiro
2012-06-11  9:17   ` kosaki.motohiro
2012-06-11 14:43   ` Christoph Lameter
2012-06-11 14:43     ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC71496.8050707@gmail.com \
    --to=kosaki.motohiro@gmail.com \
    --cc=akpm@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=davej@redhat.com \
    --cc=hughd@google.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.