All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "ABRAHAM, KISHON VIJAY" <kishon@ti.com>
Cc: paul@pwsan.com, tony@atomide.com, linux@arm.linux.org.uk,
	b-cousson@ti.com, gregkh@linuxfoundation.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, balbi@ti.com
Subject: Re: [RFC PATCH 0/5] omap: add ocp2scp as a misc driver
Date: Thu, 31 May 2012 09:22:18 +0000	[thread overview]
Message-ID: <201205310922.18550.arnd@arndb.de> (raw)
In-Reply-To: <CAAe_U6LFFstds=iQ7cy7gM9vWbfRgf5z0gaRp_-bu0Qjx6eA1Q@mail.gmail.com>

On Thursday 31 May 2012, ABRAHAM, KISHON VIJAY wrote:
> >
> > Just put the devices you actually want into the device tree instead and
> > have them automatically created.
> 
> But shouldn't device tree support and non-device tree support co-exist
> till the non-device tree is completely knocked out of the kernel? Even

Well, it's a new driver, so there is no regression in supporting it only
on DT-enabled boards. OMAP5 is DT-only anyway and OMAP4 only supports two
boards that should both be working with the generic DT code already.

> then shouldn't there be a separate driver to extract the child nodes
> of ocp2scp and create a device (using of_platform_populate)?
> As far as I've seen, the devices are automatically created (by virtue
> of of_platform_populate() in  mach-omap2/board-generic.c in omap case)
> only for the devices that is connected to the system bus. For other
> cases, the parent should be responsible for creating the child
> devices.

I would mark the multiplexed device compatible with "simple-bus", which
results in the child devices automatically getting added.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/5] omap: add ocp2scp as a misc driver
Date: Thu, 31 May 2012 09:22:18 +0000	[thread overview]
Message-ID: <201205310922.18550.arnd@arndb.de> (raw)
In-Reply-To: <CAAe_U6LFFstds=iQ7cy7gM9vWbfRgf5z0gaRp_-bu0Qjx6eA1Q@mail.gmail.com>

On Thursday 31 May 2012, ABRAHAM, KISHON VIJAY wrote:
> >
> > Just put the devices you actually want into the device tree instead and
> > have them automatically created.
> 
> But shouldn't device tree support and non-device tree support co-exist
> till the non-device tree is completely knocked out of the kernel? Even

Well, it's a new driver, so there is no regression in supporting it only
on DT-enabled boards. OMAP5 is DT-only anyway and OMAP4 only supports two
boards that should both be working with the generic DT code already.

> then shouldn't there be a separate driver to extract the child nodes
> of ocp2scp and create a device (using of_platform_populate)?
> As far as I've seen, the devices are automatically created (by virtue
> of of_platform_populate() in  mach-omap2/board-generic.c in omap case)
> only for the devices that is connected to the system bus. For other
> cases, the parent should be responsible for creating the child
> devices.

I would mark the multiplexed device compatible with "simple-bus", which
results in the child devices automatically getting added.

	Arnd

  reply	other threads:[~2012-05-31  9:22 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30 10:56 [RFC PATCH 0/5] omap: add ocp2scp as a misc driver Kishon Vijay Abraham I
2012-05-30 10:56 ` Kishon Vijay Abraham I
2012-05-30 10:56 ` Kishon Vijay Abraham I
2012-05-30 10:56 ` [RFC PATCH 1/5] arm: omap: hwmod: make *phy_48m* as the main_clk of ocp2scp Kishon Vijay Abraham I
2012-05-30 10:56   ` Kishon Vijay Abraham I
2012-05-30 10:56   ` Kishon Vijay Abraham I
2012-05-30 14:48   ` Shilimkar, Santosh
2012-05-30 14:48     ` Shilimkar, Santosh
2012-05-30 14:48     ` Shilimkar, Santosh
2012-05-30 10:56 ` [RFC PATCH 2/5] arm: omap: remove ocp2scp_usb_phy_ick clock node Kishon Vijay Abraham I
2012-05-30 10:56   ` Kishon Vijay Abraham I
2012-05-30 10:56   ` Kishon Vijay Abraham I
2012-05-30 14:51   ` Shilimkar, Santosh
2012-05-30 14:51     ` Shilimkar, Santosh
2012-05-30 14:51     ` Shilimkar, Santosh
2012-05-30 15:23     ` Cousson, Benoit
2012-05-30 15:23       ` Cousson, Benoit
2012-05-30 15:23       ` Cousson, Benoit
2012-06-01 12:52       ` ABRAHAM, KISHON VIJAY
2012-06-01 12:52         ` ABRAHAM, KISHON VIJAY
2012-06-01 12:52         ` ABRAHAM, KISHON VIJAY
2012-06-01 13:24         ` Cousson, Benoit
2012-06-01 13:24           ` Cousson, Benoit
2012-06-01 13:24           ` Cousson, Benoit
2012-06-01 15:54           ` ABRAHAM, KISHON VIJAY
2012-06-01 15:54             ` ABRAHAM, KISHON VIJAY
2012-06-01 15:54             ` ABRAHAM, KISHON VIJAY
2012-09-06 15:02   ` ABRAHAM, KISHON VIJAY
2012-09-06 15:02     ` ABRAHAM, KISHON VIJAY
2012-05-30 10:56 ` [RFC PATCH 3/5] drivers: misc: omap: add a new driver for ocp2scp Kishon Vijay Abraham I
2012-05-30 10:56   ` Kishon Vijay Abraham I
2012-05-30 10:56   ` Kishon Vijay Abraham I
2012-05-30 14:55   ` Shilimkar, Santosh
2012-05-30 14:55     ` Shilimkar, Santosh
2012-05-30 10:56 ` [RFC PATCH 4/5] ARM: OMAP4: add _dev_attr_ to ocp2scp for representing usb_phy Kishon Vijay Abraham I
2012-05-30 10:56   ` Kishon Vijay Abraham I
2012-05-30 10:56   ` Kishon Vijay Abraham I
2012-05-30 10:56 ` [RFC PATCH 5/5] arm: omap: ocp2scp: create omap device for ocp2scp Kishon Vijay Abraham I
2012-05-30 10:56   ` Kishon Vijay Abraham I
2012-05-30 10:56   ` Kishon Vijay Abraham I
2012-05-30 18:43 ` [RFC PATCH 0/5] omap: add ocp2scp as a misc driver Arnd Bergmann
2012-05-30 18:43   ` Arnd Bergmann
2012-05-31  8:14   ` ABRAHAM, KISHON VIJAY
2012-05-31  8:14     ` ABRAHAM, KISHON VIJAY
2012-05-31  9:22     ` Arnd Bergmann [this message]
2012-05-31  9:22       ` Arnd Bergmann
2012-05-31 11:18       ` ABRAHAM, KISHON VIJAY
2012-05-31 11:18         ` ABRAHAM, KISHON VIJAY
2012-05-31 11:18         ` ABRAHAM, KISHON VIJAY
2012-05-31 20:46         ` Arnd Bergmann
2012-05-31 20:46           ` Arnd Bergmann
2012-06-06 15:10           ` ABRAHAM, KISHON VIJAY
2012-06-06 15:10             ` ABRAHAM, KISHON VIJAY
2012-06-12 17:07             ` Kevin Hilman
2012-06-12 17:07               ` Kevin Hilman
2012-06-12 17:07               ` Kevin Hilman
2012-06-18  9:34               ` ABRAHAM, KISHON VIJAY
2012-06-18  9:34                 ` ABRAHAM, KISHON VIJAY
2012-06-01 10:58       ` Tony Lindgren
2012-06-01 10:58         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205310922.18550.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.