From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, alsa-devel@alsa-project.org,
Kay Sievers <kay@vrfy.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/8] Rework KERN_<LEVEL>
Date: Tue, 5 Jun 2012 17:46:38 -0700 [thread overview]
Message-ID: <20120605174638.69bcfa31.akpm@linux-foundation.org> (raw)
In-Reply-To: <1338943205.11962.28.camel@joe2Laptop>
On Tue, 05 Jun 2012 17:40:05 -0700 Joe Perches <joe@perches.com> wrote:
> On Tue, 2012-06-05 at 17:37 -0700, Andrew Morton wrote:
> > On Tue, 05 Jun 2012 17:07:27 -0700 Joe Perches <joe@perches.com> wrote:
> >
> > > On Tue, 2012-06-05 at 16:58 -0700, Andrew Morton wrote:
> > > > echo "\0014Hello Joe" > /dev/kmsg
> > >
> > > # echo -e "\x014Hello Me" > /dev/kmsg
> > > gives:
> > > 12,778,4057982669;Hello Me
> >
> > That's changed behavior.
>
> Which is an improvement too.
No it isn't. It exposes internal kernel implementation details in
random weird inexplicable ways. It doesn't seem at all important
though.
> I very much doubt a single app will change
> because of this.
I doubt it as well.
> > printk_emit() does parse the leading \0014, and then skips over it,
> > removing it from the output stream. printk_emit() then throws away the
> > resulting level because devkmsg_writev() did not pass in level==-1.
>
> I'm glad you know how it works now.
It's nice to see you learning about it as well.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Kay Sievers <kay@vrfy.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 0/8] Rework KERN_<LEVEL>
Date: Tue, 5 Jun 2012 17:46:38 -0700 [thread overview]
Message-ID: <20120605174638.69bcfa31.akpm@linux-foundation.org> (raw)
In-Reply-To: <1338943205.11962.28.camel@joe2Laptop>
On Tue, 05 Jun 2012 17:40:05 -0700 Joe Perches <joe@perches.com> wrote:
> On Tue, 2012-06-05 at 17:37 -0700, Andrew Morton wrote:
> > On Tue, 05 Jun 2012 17:07:27 -0700 Joe Perches <joe@perches.com> wrote:
> >
> > > On Tue, 2012-06-05 at 16:58 -0700, Andrew Morton wrote:
> > > > echo "\0014Hello Joe" > /dev/kmsg
> > >
> > > # echo -e "\x014Hello Me" > /dev/kmsg
> > > gives:
> > > 12,778,4057982669;Hello Me
> >
> > That's changed behavior.
>
> Which is an improvement too.
No it isn't. It exposes internal kernel implementation details in
random weird inexplicable ways. It doesn't seem at all important
though.
> I very much doubt a single app will change
> because of this.
I doubt it as well.
> > printk_emit() does parse the leading \0014, and then skips over it,
> > removing it from the output stream. printk_emit() then throws away the
> > resulting level because devkmsg_writev() did not pass in level==-1.
>
> I'm glad you know how it works now.
It's nice to see you learning about it as well.
WARNING: multiple messages have this Message-ID (diff)
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/8] Rework KERN_<LEVEL>
Date: Tue, 5 Jun 2012 17:46:38 -0700 [thread overview]
Message-ID: <20120605174638.69bcfa31.akpm@linux-foundation.org> (raw)
In-Reply-To: <1338943205.11962.28.camel@joe2Laptop>
On Tue, 05 Jun 2012 17:40:05 -0700 Joe Perches <joe@perches.com> wrote:
> On Tue, 2012-06-05 at 17:37 -0700, Andrew Morton wrote:
> > On Tue, 05 Jun 2012 17:07:27 -0700 Joe Perches <joe@perches.com> wrote:
> >
> > > On Tue, 2012-06-05 at 16:58 -0700, Andrew Morton wrote:
> > > > echo "\0014Hello Joe" > /dev/kmsg
> > >
> > > # echo -e "\x014Hello Me" > /dev/kmsg
> > > gives:
> > > 12,778,4057982669;Hello Me
> >
> > That's changed behavior.
>
> Which is an improvement too.
No it isn't. It exposes internal kernel implementation details in
random weird inexplicable ways. It doesn't seem at all important
though.
> I very much doubt a single app will change
> because of this.
I doubt it as well.
> > printk_emit() does parse the leading \0014, and then skips over it,
> > removing it from the output stream. printk_emit() then throws away the
> > resulting level because devkmsg_writev() did not pass in level==-1.
>
> I'm glad you know how it works now.
It's nice to see you learning about it as well.
next prev parent reply other threads:[~2012-06-06 0:46 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 9:46 [PATCH 0/8] Rework KERN_<LEVEL> Joe Perches
2012-06-05 9:46 ` Joe Perches
2012-06-05 9:46 ` Joe Perches
2012-06-05 9:46 ` [PATCH 1/8] printk: Add generic functions to find KERN_<LEVEL> headers Joe Perches
2012-06-05 9:46 ` [PATCH 2/8] printk: Add kern_levels.h to make KERN_<LEVEL> available for asm use Joe Perches
2012-06-05 9:46 ` [PATCH 3/8] arch: Remove direct definitions of KERN_<LEVEL> uses Joe Perches
2012-06-05 9:46 ` Joe Perches
2012-06-05 9:46 ` [PATCH 4/8] btrfs: Use printk_get_level and printk_skip_level, add __printf, fix fallout Joe Perches
2012-06-05 9:46 ` [PATCH 5/8] sound: Use printk_get_level and printk_skip_level Joe Perches
2012-06-05 9:46 ` Joe Perches
2012-06-05 9:46 ` [PATCH 6/8] staging: wlags49_h2: Remove direct declarations of KERN_<LEVEL> prefixes Joe Perches
2012-06-05 9:46 ` [PATCH 7/8] printk: Convert the format for KERN_<LEVEL> to a 2 byte pattern Joe Perches
2012-06-05 9:46 ` [PATCH 8/8] printk: Remove the now unnecessary "C" annotation for KERN_CONT Joe Perches
2012-06-05 21:28 ` [PATCH 0/8] Rework KERN_<LEVEL> Andrew Morton
2012-06-05 21:28 ` Andrew Morton
2012-06-05 21:53 ` Kay Sievers
2012-06-05 21:53 ` Kay Sievers
2012-06-05 21:53 ` Kay Sievers
2012-06-05 22:11 ` Joe Perches
2012-06-05 22:11 ` Joe Perches
2012-06-05 22:17 ` Andrew Morton
2012-06-05 22:17 ` Andrew Morton
2012-06-05 22:17 ` Andrew Morton
2012-06-05 22:49 ` Joe Perches
2012-06-05 22:49 ` Joe Perches
2012-06-05 22:49 ` Joe Perches
2012-06-05 23:29 ` Andrew Morton
2012-06-05 23:29 ` Andrew Morton
2012-06-05 23:29 ` Andrew Morton
2012-06-05 23:35 ` Joe Perches
2012-06-05 23:35 ` Joe Perches
2012-06-05 23:35 ` Joe Perches
2012-06-05 23:39 ` Kay Sievers
2012-06-05 23:39 ` Kay Sievers
2012-06-05 23:43 ` Joe Perches
2012-06-05 23:43 ` Joe Perches
2012-06-05 23:48 ` Kay Sievers
2012-06-05 23:48 ` Kay Sievers
2012-06-05 23:48 ` Kay Sievers
2012-06-05 23:52 ` Joe Perches
2012-06-05 23:52 ` Joe Perches
2012-06-05 23:52 ` Joe Perches
2012-06-05 23:58 ` Andrew Morton
2012-06-05 23:58 ` Andrew Morton
2012-06-05 23:58 ` Andrew Morton
2012-06-06 0:07 ` Joe Perches
2012-06-06 0:07 ` Joe Perches
2012-06-06 0:07 ` Joe Perches
2012-06-06 0:13 ` Kay Sievers
2012-06-06 0:13 ` Kay Sievers
2012-06-06 0:13 ` Kay Sievers
2012-06-06 0:19 ` Joe Perches
2012-06-06 0:19 ` Joe Perches
2012-06-06 0:19 ` Joe Perches
2012-06-06 0:28 ` Kay Sievers
2012-06-06 0:28 ` Kay Sievers
2012-06-06 0:28 ` Kay Sievers
2012-06-06 0:37 ` Joe Perches
2012-06-06 0:37 ` Joe Perches
2012-06-06 0:37 ` Joe Perches
2012-06-06 0:37 ` Andrew Morton
2012-06-06 0:37 ` Andrew Morton
2012-06-06 0:40 ` Joe Perches
2012-06-06 0:40 ` Joe Perches
2012-06-06 0:40 ` Joe Perches
2012-06-06 0:46 ` Andrew Morton [this message]
2012-06-06 0:46 ` Andrew Morton
2012-06-06 0:46 ` Andrew Morton
2012-06-06 1:10 ` Kay Sievers
2012-06-06 1:10 ` Kay Sievers
2012-06-06 2:06 ` Joe Perches
2012-06-06 2:06 ` Joe Perches
2012-06-06 2:06 ` Joe Perches
2012-06-06 3:04 ` [PATCH 9/8] printk: Only look for prefix levels in kernel messages Joe Perches
2012-06-06 3:04 ` Joe Perches
2012-06-06 3:04 ` Joe Perches
2012-06-05 23:48 ` [PATCH 0/8] Rework KERN_<LEVEL> Joe Perches
2012-06-05 23:48 ` Joe Perches
2012-06-05 23:48 ` Joe Perches
2012-06-05 22:55 ` Kay Sievers
2012-06-05 22:55 ` Kay Sievers
2012-06-05 22:55 ` Kay Sievers
2012-06-05 23:09 ` Andrew Morton
2012-06-05 23:09 ` Andrew Morton
2012-06-05 23:09 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605174638.69bcfa31.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=kay@vrfy.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.