From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, alsa-devel@alsa-project.org,
Kay Sievers <kay.sievers@vrfy.org>, Sievers <kay@vrfy.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Kay@alsa-project.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/8] Rework KERN_<LEVEL>
Date: Tue, 5 Jun 2012 16:29:10 -0700 [thread overview]
Message-ID: <20120605162910.caccb0d4.akpm@linux-foundation.org> (raw)
In-Reply-To: <1338936572.5780.29.camel@joe2Laptop>
On Tue, 05 Jun 2012 15:49:32 -0700
Joe Perches <joe@perches.com> wrote:
> On Tue, 2012-06-05 at 15:17 -0700, Andrew Morton wrote:
> > On Tue, 05 Jun 2012 15:11:43 -0700
> > Joe Perches <joe@perches.com> wrote:
> >
> > > On Tue, 2012-06-05 at 14:28 -0700, Andrew Morton wrote:
> > > > Unfortunately the <n> thing is part of the kernel ABI:
> > > >
> > > > echo "<4>foo" > /dev/kmsg
> > >
> > > Which works the same way it did before.
> >
> > I didn't say it didn't.
> >
> > What I did say is that echo "\0014">/dev/kmsg will subvert the intent
> > of the new logging code. Or might. But you just ignored all that,
> > forcing me to repeat myself, irritatedly.
>
> It works the same way before and after the patch.
>
> Any write to /dev/kmsg without a KERN_<LEVEL>
> emits at (1 << 3) + KERN_DEFAULT.
>
> Writes with <n> values >= 8 are emitted at
> that level.
What about writes starting with \001n? AFACIT, that will be stripped
away and the printk level will be altered. This is new behavior.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-btrfs@vger.kernel.org, Kay Sievers <kay@vrfy.org>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
alsa-devel@alsa-project.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH 0/8] Rework KERN_<LEVEL>
Date: Tue, 5 Jun 2012 16:29:10 -0700 [thread overview]
Message-ID: <20120605162910.caccb0d4.akpm@linux-foundation.org> (raw)
In-Reply-To: <1338936572.5780.29.camel@joe2Laptop>
On Tue, 05 Jun 2012 15:49:32 -0700
Joe Perches <joe@perches.com> wrote:
> On Tue, 2012-06-05 at 15:17 -0700, Andrew Morton wrote:
> > On Tue, 05 Jun 2012 15:11:43 -0700
> > Joe Perches <joe@perches.com> wrote:
> >
> > > On Tue, 2012-06-05 at 14:28 -0700, Andrew Morton wrote:
> > > > Unfortunately the <n> thing is part of the kernel ABI:
> > > >
> > > > echo "<4>foo" > /dev/kmsg
> > >
> > > Which works the same way it did before.
> >
> > I didn't say it didn't.
> >
> > What I did say is that echo "\0014">/dev/kmsg will subvert the intent
> > of the new logging code. Or might. But you just ignored all that,
> > forcing me to repeat myself, irritatedly.
>
> It works the same way before and after the patch.
>
> Any write to /dev/kmsg without a KERN_<LEVEL>
> emits at (1 << 3) + KERN_DEFAULT.
>
> Writes with <n> values >= 8 are emitted at
> that level.
What about writes starting with \001n? AFACIT, that will be stripped
away and the printk level will be altered. This is new behavior.
WARNING: multiple messages have this Message-ID (diff)
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/8] Rework KERN_<LEVEL>
Date: Tue, 5 Jun 2012 16:29:10 -0700 [thread overview]
Message-ID: <20120605162910.caccb0d4.akpm@linux-foundation.org> (raw)
In-Reply-To: <1338936572.5780.29.camel@joe2Laptop>
On Tue, 05 Jun 2012 15:49:32 -0700
Joe Perches <joe@perches.com> wrote:
> On Tue, 2012-06-05 at 15:17 -0700, Andrew Morton wrote:
> > On Tue, 05 Jun 2012 15:11:43 -0700
> > Joe Perches <joe@perches.com> wrote:
> >
> > > On Tue, 2012-06-05 at 14:28 -0700, Andrew Morton wrote:
> > > > Unfortunately the <n> thing is part of the kernel ABI:
> > > >
> > > > echo "<4>foo" > /dev/kmsg
> > >
> > > Which works the same way it did before.
> >
> > I didn't say it didn't.
> >
> > What I did say is that echo "\0014">/dev/kmsg will subvert the intent
> > of the new logging code. Or might. But you just ignored all that,
> > forcing me to repeat myself, irritatedly.
>
> It works the same way before and after the patch.
>
> Any write to /dev/kmsg without a KERN_<LEVEL>
> emits at (1 << 3) + KERN_DEFAULT.
>
> Writes with <n> values >= 8 are emitted at
> that level.
What about writes starting with \001n? AFACIT, that will be stripped
away and the printk level will be altered. This is new behavior.
next prev parent reply other threads:[~2012-06-05 23:29 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 9:46 [PATCH 0/8] Rework KERN_<LEVEL> Joe Perches
2012-06-05 9:46 ` Joe Perches
2012-06-05 9:46 ` Joe Perches
2012-06-05 9:46 ` [PATCH 1/8] printk: Add generic functions to find KERN_<LEVEL> headers Joe Perches
2012-06-05 9:46 ` [PATCH 2/8] printk: Add kern_levels.h to make KERN_<LEVEL> available for asm use Joe Perches
2012-06-05 9:46 ` [PATCH 3/8] arch: Remove direct definitions of KERN_<LEVEL> uses Joe Perches
2012-06-05 9:46 ` Joe Perches
2012-06-05 9:46 ` [PATCH 4/8] btrfs: Use printk_get_level and printk_skip_level, add __printf, fix fallout Joe Perches
2012-06-05 9:46 ` [PATCH 5/8] sound: Use printk_get_level and printk_skip_level Joe Perches
2012-06-05 9:46 ` Joe Perches
2012-06-05 9:46 ` [PATCH 6/8] staging: wlags49_h2: Remove direct declarations of KERN_<LEVEL> prefixes Joe Perches
2012-06-05 9:46 ` [PATCH 7/8] printk: Convert the format for KERN_<LEVEL> to a 2 byte pattern Joe Perches
2012-06-05 9:46 ` [PATCH 8/8] printk: Remove the now unnecessary "C" annotation for KERN_CONT Joe Perches
2012-06-05 21:28 ` [PATCH 0/8] Rework KERN_<LEVEL> Andrew Morton
2012-06-05 21:28 ` Andrew Morton
2012-06-05 21:53 ` Kay Sievers
2012-06-05 21:53 ` Kay Sievers
2012-06-05 21:53 ` Kay Sievers
2012-06-05 22:11 ` Joe Perches
2012-06-05 22:11 ` Joe Perches
2012-06-05 22:17 ` Andrew Morton
2012-06-05 22:17 ` Andrew Morton
2012-06-05 22:17 ` Andrew Morton
2012-06-05 22:49 ` Joe Perches
2012-06-05 22:49 ` Joe Perches
2012-06-05 22:49 ` Joe Perches
2012-06-05 23:29 ` Andrew Morton [this message]
2012-06-05 23:29 ` Andrew Morton
2012-06-05 23:29 ` Andrew Morton
2012-06-05 23:35 ` Joe Perches
2012-06-05 23:35 ` Joe Perches
2012-06-05 23:35 ` Joe Perches
2012-06-05 23:39 ` Kay Sievers
2012-06-05 23:39 ` Kay Sievers
2012-06-05 23:43 ` Joe Perches
2012-06-05 23:43 ` Joe Perches
2012-06-05 23:48 ` Kay Sievers
2012-06-05 23:48 ` Kay Sievers
2012-06-05 23:48 ` Kay Sievers
2012-06-05 23:52 ` Joe Perches
2012-06-05 23:52 ` Joe Perches
2012-06-05 23:52 ` Joe Perches
2012-06-05 23:58 ` Andrew Morton
2012-06-05 23:58 ` Andrew Morton
2012-06-05 23:58 ` Andrew Morton
2012-06-06 0:07 ` Joe Perches
2012-06-06 0:07 ` Joe Perches
2012-06-06 0:07 ` Joe Perches
2012-06-06 0:13 ` Kay Sievers
2012-06-06 0:13 ` Kay Sievers
2012-06-06 0:13 ` Kay Sievers
2012-06-06 0:19 ` Joe Perches
2012-06-06 0:19 ` Joe Perches
2012-06-06 0:19 ` Joe Perches
2012-06-06 0:28 ` Kay Sievers
2012-06-06 0:28 ` Kay Sievers
2012-06-06 0:28 ` Kay Sievers
2012-06-06 0:37 ` Joe Perches
2012-06-06 0:37 ` Joe Perches
2012-06-06 0:37 ` Joe Perches
2012-06-06 0:37 ` Andrew Morton
2012-06-06 0:37 ` Andrew Morton
2012-06-06 0:40 ` Joe Perches
2012-06-06 0:40 ` Joe Perches
2012-06-06 0:40 ` Joe Perches
2012-06-06 0:46 ` Andrew Morton
2012-06-06 0:46 ` Andrew Morton
2012-06-06 0:46 ` Andrew Morton
2012-06-06 1:10 ` Kay Sievers
2012-06-06 1:10 ` Kay Sievers
2012-06-06 2:06 ` Joe Perches
2012-06-06 2:06 ` Joe Perches
2012-06-06 2:06 ` Joe Perches
2012-06-06 3:04 ` [PATCH 9/8] printk: Only look for prefix levels in kernel messages Joe Perches
2012-06-06 3:04 ` Joe Perches
2012-06-06 3:04 ` Joe Perches
2012-06-05 23:48 ` [PATCH 0/8] Rework KERN_<LEVEL> Joe Perches
2012-06-05 23:48 ` Joe Perches
2012-06-05 23:48 ` Joe Perches
2012-06-05 22:55 ` Kay Sievers
2012-06-05 22:55 ` Kay Sievers
2012-06-05 22:55 ` Kay Sievers
2012-06-05 23:09 ` Andrew Morton
2012-06-05 23:09 ` Andrew Morton
2012-06-05 23:09 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605162910.caccb0d4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Kay@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=kay.sievers@vrfy.org \
--cc=kay@vrfy.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.