From: Dave Chinner <david@fromorbit.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 0/2] Add FALLOC_FL_ZERO_RANGE to fallocate
Date: Wed, 13 Jun 2012 13:30:52 +1000 [thread overview]
Message-ID: <20120613033052.GT22848@dastard> (raw)
In-Reply-To: <20120613013549.GO22848@dastard>
On Wed, Jun 13, 2012 at 11:35:49AM +1000, Dave Chinner wrote:
> On Tue, Jun 12, 2012 at 05:36:02PM +0200, Paolo Bonzini wrote:
> > This patch adds the FALLOC_FL_ZERO_RANGE operation mode to fallocate,
> > resembling the similar XFS ioctl. The new mode can be used with
> > or without FALLOC_FL_KEEP_SIZE, but of course not together with
> > FALLOC_FL_PUNCH_HOLE.
>
> !FALLOC_FL_KEEP_SIZE makes no sense for this operation. It is for
> zeroing an existing section of a file while retaining the allocated
> space, not for extending or truncating the file. It's the same
> reason that FALLOC_FL_PUNCH_HOLE must have FALLOC_FL_KEEP_SIZE set.
>
> Also, a minor nit, but you should credit where this code has
> originated from in the commit messages, and describe the use case
> for requiring it. i.e. based on:
>
> http://permalink.gmane.org/gmane.linux.file-systems/62449
Oh, and you'll need to provide a new xfstests test based on 242 that
uses the new fallocate interface, and to do that you'll also need to
add support for the new fallocate function in xfs_io.
Adding generic filesystem functionality is not as simple as writing a
kernel patch anymore... :/
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
xfs@oss.sgi.com
Subject: Re: [PATCH 0/2] Add FALLOC_FL_ZERO_RANGE to fallocate
Date: Wed, 13 Jun 2012 13:30:52 +1000 [thread overview]
Message-ID: <20120613033052.GT22848@dastard> (raw)
In-Reply-To: <20120613013549.GO22848@dastard>
On Wed, Jun 13, 2012 at 11:35:49AM +1000, Dave Chinner wrote:
> On Tue, Jun 12, 2012 at 05:36:02PM +0200, Paolo Bonzini wrote:
> > This patch adds the FALLOC_FL_ZERO_RANGE operation mode to fallocate,
> > resembling the similar XFS ioctl. The new mode can be used with
> > or without FALLOC_FL_KEEP_SIZE, but of course not together with
> > FALLOC_FL_PUNCH_HOLE.
>
> !FALLOC_FL_KEEP_SIZE makes no sense for this operation. It is for
> zeroing an existing section of a file while retaining the allocated
> space, not for extending or truncating the file. It's the same
> reason that FALLOC_FL_PUNCH_HOLE must have FALLOC_FL_KEEP_SIZE set.
>
> Also, a minor nit, but you should credit where this code has
> originated from in the commit messages, and describe the use case
> for requiring it. i.e. based on:
>
> http://permalink.gmane.org/gmane.linux.file-systems/62449
Oh, and you'll need to provide a new xfstests test based on 242 that
uses the new fallocate interface, and to do that you'll also need to
add support for the new fallocate function in xfs_io.
Adding generic filesystem functionality is not as simple as writing a
kernel patch anymore... :/
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2012-06-13 3:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 15:36 [PATCH 0/2] Add FALLOC_FL_ZERO_RANGE to fallocate Paolo Bonzini
2012-06-12 15:36 ` Paolo Bonzini
2012-06-12 15:36 ` [PATCH 1/2] vfs: add " Paolo Bonzini
2012-06-12 15:36 ` Paolo Bonzini
2012-06-13 1:55 ` Dave Chinner
2012-06-13 1:55 ` Dave Chinner
2012-06-12 15:36 ` [PATCH 2/2] xfs: " Paolo Bonzini
2012-06-12 15:36 ` Paolo Bonzini
2012-06-13 2:16 ` Dave Chinner
2012-06-13 2:16 ` Dave Chinner
2012-06-13 6:24 ` Paolo Bonzini
2012-06-13 6:24 ` Paolo Bonzini
2012-06-13 23:52 ` Dave Chinner
2012-06-13 23:52 ` Dave Chinner
2012-06-13 1:35 ` [PATCH 0/2] Add " Dave Chinner
2012-06-13 1:35 ` Dave Chinner
2012-06-13 3:30 ` Dave Chinner [this message]
2012-06-13 3:30 ` Dave Chinner
2012-06-13 6:13 ` Paolo Bonzini
2012-06-13 6:13 ` Paolo Bonzini
2012-06-13 23:51 ` Dave Chinner
2012-06-13 23:51 ` Dave Chinner
2013-11-05 10:34 ` Christoph Hellwig
2013-11-05 10:34 ` Christoph Hellwig
2013-11-05 10:36 ` Paolo Bonzini
2013-11-05 10:36 ` Paolo Bonzini
2013-11-05 16:36 ` Christoph Hellwig
2013-11-05 16:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613033052.GT22848@dastard \
--to=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.