All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
	linux-kernel@vger.kernel.org, Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH 2/2] xfs: add FALLOC_FL_ZERO_RANGE to fallocate
Date: Wed, 13 Jun 2012 08:24:12 +0200	[thread overview]
Message-ID: <4FD8320C.1060308@redhat.com> (raw)
In-Reply-To: <20120613021610.GQ22848@dastard>

Il 13/06/2012 04:16, Dave Chinner ha scritto:
>> > +	BUG_ON((mode & FALLOC_FL_PUNCH_HOLE) && (mode & FALLOC_FL_ZERO_RANGE));
> Never put BUG_ON() or BUG() in XFS code that can return an error.
> Return EINVAL if we chose not to support it, and if it's really
> something we consider bad, emit a warning to syslog (i.e.
> xfs_warn()) and potentially add a ASSERT() case so that debug
> kernels will trip over it. Nobody should be panicing a production
> system just because a user supplied a set of incorrect syscall
> paramters....

I know, the BUG_ON() is because it is ruled out in VFS code.  Of course
if I remove that code, this will not be a BUG_ON() anymore.

Paolo

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Dave Chinner <dchinner@redhat.com>,
	xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: add FALLOC_FL_ZERO_RANGE to fallocate
Date: Wed, 13 Jun 2012 08:24:12 +0200	[thread overview]
Message-ID: <4FD8320C.1060308@redhat.com> (raw)
In-Reply-To: <20120613021610.GQ22848@dastard>

Il 13/06/2012 04:16, Dave Chinner ha scritto:
>> > +	BUG_ON((mode & FALLOC_FL_PUNCH_HOLE) && (mode & FALLOC_FL_ZERO_RANGE));
> Never put BUG_ON() or BUG() in XFS code that can return an error.
> Return EINVAL if we chose not to support it, and if it's really
> something we consider bad, emit a warning to syslog (i.e.
> xfs_warn()) and potentially add a ASSERT() case so that debug
> kernels will trip over it. Nobody should be panicing a production
> system just because a user supplied a set of incorrect syscall
> paramters....

I know, the BUG_ON() is because it is ruled out in VFS code.  Of course
if I remove that code, this will not be a BUG_ON() anymore.

Paolo

  reply	other threads:[~2012-06-13  6:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12 15:36 [PATCH 0/2] Add FALLOC_FL_ZERO_RANGE to fallocate Paolo Bonzini
2012-06-12 15:36 ` Paolo Bonzini
2012-06-12 15:36 ` [PATCH 1/2] vfs: add " Paolo Bonzini
2012-06-12 15:36   ` Paolo Bonzini
2012-06-13  1:55   ` Dave Chinner
2012-06-13  1:55     ` Dave Chinner
2012-06-12 15:36 ` [PATCH 2/2] xfs: " Paolo Bonzini
2012-06-12 15:36   ` Paolo Bonzini
2012-06-13  2:16   ` Dave Chinner
2012-06-13  2:16     ` Dave Chinner
2012-06-13  6:24     ` Paolo Bonzini [this message]
2012-06-13  6:24       ` Paolo Bonzini
2012-06-13 23:52       ` Dave Chinner
2012-06-13 23:52         ` Dave Chinner
2012-06-13  1:35 ` [PATCH 0/2] Add " Dave Chinner
2012-06-13  1:35   ` Dave Chinner
2012-06-13  3:30   ` Dave Chinner
2012-06-13  3:30     ` Dave Chinner
2012-06-13  6:13     ` Paolo Bonzini
2012-06-13  6:13       ` Paolo Bonzini
2012-06-13 23:51       ` Dave Chinner
2012-06-13 23:51         ` Dave Chinner
2013-11-05 10:34       ` Christoph Hellwig
2013-11-05 10:34         ` Christoph Hellwig
2013-11-05 10:36         ` Paolo Bonzini
2013-11-05 10:36           ` Paolo Bonzini
2013-11-05 16:36           ` Christoph Hellwig
2013-11-05 16:36             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD8320C.1060308@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=david@fromorbit.com \
    --cc=dchinner@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.