From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
Date: Sun, 17 Jun 2012 15:30:17 +0200 [thread overview]
Message-ID: <201206171530.17935.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5C4T4LmoGJnt7GieFK07CiMyVvUBBCnjJseYZtd=Mv9mw@mail.gmail.com>
Dear Fabio Estevam,
> On Sun, Jun 17, 2012 at 10:09 AM, Otavio Salvador
>
> <otavio@ossystems.com.br> wrote:
> > On Sun, Jun 17, 2012 at 10:05 AM, Fabio Estevam <festevam@gmail.com> wrote:
> >>> default:
> >>> - return "unknown";
> >>> + return "<unidentified>";
> >>
> >> I really don't see any improvement here.
> >
> > It is just to avoid a i.MXunkown return; besides this is how I am
> > doing in the mx23 code too.
>
> This is OK. If you read "i.MXunkown" things are too broken already
> because the chip version could not be read.
>
> Reading "i.MX<unidentified>" will make things no better.
This was from my head actually ... and I think this is better. The text is at
least not mangled so badly. So let's keep it.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-06-17 13:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 12:58 [U-Boot] [PATCH 0/3] i.MX refactoring patchset Otavio Salvador
2012-06-17 12:58 ` [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type Otavio Salvador
2012-06-17 13:05 ` Fabio Estevam
2012-06-17 13:09 ` Otavio Salvador
2012-06-17 13:13 ` Fabio Estevam
2012-06-17 13:21 ` Otavio Salvador
2012-06-17 13:30 ` Marek Vasut [this message]
2012-06-17 15:43 ` Stefano Babic
2012-06-17 15:48 ` Otavio Salvador
2012-06-17 16:03 ` Marek Vasut
2012-06-17 17:50 ` Otavio Salvador
2012-06-17 18:04 ` Stefano Babic
2012-06-17 18:40 ` Marek Vasut
2012-06-17 18:04 ` Marek Vasut
2012-06-17 12:58 ` [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo() Otavio Salvador
2012-06-17 13:10 ` Fabio Estevam
2012-06-17 13:25 ` Fabio Estevam
2012-06-17 13:35 ` Marek Vasut
2012-06-17 14:14 ` Fabio Estevam
2012-06-17 14:35 ` Otavio Salvador
2012-06-17 15:10 ` Marek Vasut
2012-06-17 15:17 ` Otavio Salvador
2012-06-17 13:28 ` Marek Vasut
2012-06-17 15:49 ` Stefano Babic
2012-06-17 16:02 ` Marek Vasut
2012-06-17 17:56 ` Stefano Babic
2012-06-17 18:03 ` Otavio Salvador
2012-06-17 18:41 ` Marek Vasut
2012-06-17 18:04 ` Marek Vasut
2012-06-17 17:49 ` Otavio Salvador
2012-06-17 12:58 ` [U-Boot] [PATCH 3/3] mx28evk: extend default environment Otavio Salvador
2012-06-17 21:54 ` [U-Boot] [PATCH 0/3] i.MX refactoring patchset Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206171530.17935.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.