All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters
Date: Mon, 18 Jun 2012 19:10:25 +0200	[thread overview]
Message-ID: <201206181910.25985.marex@denx.de> (raw)
In-Reply-To: <4FDF582A.7020706@denx.de>

Dear Stefano Babic,

> On 18/06/2012 17:43, Marek Vasut wrote:
> >> So ... what do you expect me to do? The register is called HW_DRAM_CTL29
> >> (very descriptive) ... do you want me to create a file full of
> >> HW_DRAM_CTLnn ?
> > 
> > Would adding such comment be enough to satisfy you? (In slightly more
> > polite manner I mean ... damn I'm loosing it, 2 days until exam :'-( ).
> > Sorry for being rough, Stefano.
> 
> Do not worry, it is normal before exam ;-)

This ... is not exam. This ... is HELL!!!

> Yes, of course comments will help !

Wait ... it isn't my fault, I didn't publish any code that uses the function 
yet, that encodes stuff in hexadecimal. So this patch can be applied as is. It's 
Fabio's patch that's at fault here (and I hereby dump all responsibility on 
Fabio, keh keh :-) ).

But anyway ... we're gonna have this used a lot and I'm not quite sure how to 
handle it. So if comment is enough (aka. I'm hereby adjusting HW_DRAM_CTL29 in 
order to set enabled rows and cols differently, refer to "14.8.27 in mx28 TRM"), 
let's go with it.

Later, I think we should rework the mem init part. It's there from bootlets and 
I think it's all shitty because of that. Well ... the whole SPL is shitty 
because it's from bootlets, but that's a longer run, out of scope of this 
discussion.

> Best regards,
> Stefano

Best regards,
Marek Vasut

  reply	other threads:[~2012-06-18 17:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30  5:43 [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters Marek Vasut
2012-05-31 18:04 ` Fabio Estevam
2012-05-31 18:45   ` Marek Vasut
2012-06-18 14:17     ` Fabio Estevam
2012-06-18 14:23       ` Marek Vasut
2012-06-18 15:16         ` Stefano Babic
2012-06-18 15:36           ` Marek Vasut
2012-06-18 15:43             ` Marek Vasut
2012-06-18 16:32               ` Stefano Babic
2012-06-18 17:10                 ` Marek Vasut [this message]
2012-06-19  7:29 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206181910.25985.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.