From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Prchal Jiří" <jiri.prchal@aksignal.cz>
Cc: vbarinov@embeddedalley.com, alsa-devel@alsa-project.org,
sudhakar.raj@ti.com, nsekhar@ti.com, peter.ujfalusi@ti.com,
mr.swami.reddy@ti.com, lrg@ti.com
Subject: Re: [PATCH] ASoC: tlv320aic3x: add missing registers and bits
Date: Tue, 26 Jun 2012 14:21:18 +0100 [thread overview]
Message-ID: <20120626132117.GV30406@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FE9AD5F.7080302@aksignal.cz>
[-- Attachment #1.1: Type: text/plain, Size: 506 bytes --]
On Tue, Jun 26, 2012 at 02:38:55PM +0200, Prchal Jiří wrote:
> This patch adds missing registers and bits for TLV320AIC3106.
> static const u8 aic3x_reg[AIC3X_CACHEREGNUM] = {
> - 0x00, 0x00, 0x00, 0x10, /* 0 */
> + 0x00, 0x00, 0x00, 0x10, 0x04, 0x00, 0x00, 0x00, /* 0 */
This is essentially impossible to review as you've not said what's being
fixed and have completely reformatted the table so the diff doesn't
highlight the changes at all. What's wrong and what is the change
fixing?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-06-26 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 12:38 [PATCH] ASoC: tlv320aic3x: add missing registers and bits Prchal Jiří
2012-06-26 13:21 ` Mark Brown [this message]
2012-06-26 14:56 ` Roberto Nibali
2012-06-26 16:33 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-06-27 6:06 [PATCH v2] " Prchal Jiří
2012-06-27 12:01 ` Mark Brown
2012-07-03 9:41 ` [PATCH] " Prchal Jiří
2012-07-03 18:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626132117.GV30406@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jiri.prchal@aksignal.cz \
--cc=lrg@ti.com \
--cc=mr.swami.reddy@ti.com \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=sudhakar.raj@ti.com \
--cc=vbarinov@embeddedalley.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.