From: Tony Lindgren <tony@atomide.com>
To: Andy Green <andy.green@linaro.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
nicolas.pitre@linaro.org, s-jan@ti.com, arnd@arndb.de,
patches@linaro.org, rostedt@goodmis.org
Subject: Re: [PATCH 3/3] OMAP4 PANDA register ethernet and wlan for automatic mac allocation
Date: Fri, 29 Jun 2012 04:55:11 -0700 [thread overview]
Message-ID: <20120629115511.GC4202@atomide.com> (raw)
In-Reply-To: <20120629055524.11091.57217.stgit@build.warmcat.com>
* Andy Green <andy.green@linaro.org> [120628 23:00]:
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -486,6 +486,15 @@ static void omap4_panda_init_rev(void)
> }
> }
>
> +/*
> + * These device paths represent onboard network devices which have
> + * no MAC address set at boot, and need synthetic ones assigning
> + */
> +static const char * const panda_fixup_mac_device_paths[] = {
> + "usb1/1-1/1-1.1/1-1.1:1.0", /* smsc USB <-> Ethernet bridge */
> + "wl12xx", /* wlan0 module */
> +};
I suspect the "usb1/1-1/1-1.1/1-1.1:1.0" naming is not valid
if you change the order of loading of musb_hdrc and ehci modules?
Might be worth checking..
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] OMAP4 PANDA register ethernet and wlan for automatic mac allocation
Date: Fri, 29 Jun 2012 04:55:11 -0700 [thread overview]
Message-ID: <20120629115511.GC4202@atomide.com> (raw)
In-Reply-To: <20120629055524.11091.57217.stgit@build.warmcat.com>
* Andy Green <andy.green@linaro.org> [120628 23:00]:
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -486,6 +486,15 @@ static void omap4_panda_init_rev(void)
> }
> }
>
> +/*
> + * These device paths represent onboard network devices which have
> + * no MAC address set at boot, and need synthetic ones assigning
> + */
> +static const char * const panda_fixup_mac_device_paths[] = {
> + "usb1/1-1/1-1.1/1-1.1:1.0", /* smsc USB <-> Ethernet bridge */
> + "wl12xx", /* wlan0 module */
> +};
I suspect the "usb1/1-1/1-1.1/1-1.1:1.0" naming is not valid
if you change the order of loading of musb_hdrc and ehci modules?
Might be worth checking..
Tony
next prev parent reply other threads:[~2012-06-29 11:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 5:55 [PATCH 0/3] Add ability to set defaultless network device MAC addresses to deterministic computed locally administered values Andy Green
2012-06-29 5:55 ` Andy Green
2012-06-29 5:55 ` [PATCH 1/3] OMAP2+: add cpu id register to MAC address helper Andy Green
2012-06-29 5:55 ` Andy Green
2012-06-29 9:05 ` Tony Lindgren
2012-06-29 9:05 ` Tony Lindgren
2012-06-29 9:13 ` Andy Green
2012-06-29 9:13 ` Andy Green
2012-06-29 5:55 ` [PATCH 2/3] OMAP2+ devices add mac address allocation register api Andy Green
2012-06-29 5:55 ` Andy Green
2012-06-29 8:51 ` Arnd Bergmann
2012-06-29 8:51 ` Arnd Bergmann
2012-06-29 9:03 ` Andy Green
2012-06-29 9:03 ` Andy Green
2012-06-29 9:40 ` Tony Lindgren
2012-06-29 9:40 ` Tony Lindgren
2012-06-29 10:07 ` Andy Green
2012-06-29 10:07 ` Andy Green
2012-06-29 12:03 ` Tony Lindgren
2012-06-29 12:03 ` Tony Lindgren
2012-06-29 13:45 ` Arnd Bergmann
2012-06-29 13:45 ` Arnd Bergmann
2012-06-29 13:55 ` Tony Lindgren
2012-06-29 13:55 ` Tony Lindgren
2012-06-29 13:59 ` Andy Green
2012-06-29 13:59 ` Andy Green
2012-06-29 14:33 ` Arnd Bergmann
2012-06-29 14:33 ` Arnd Bergmann
2012-06-29 14:52 ` Tony Lindgren
2012-06-29 14:52 ` Tony Lindgren
2012-06-29 15:05 ` Arnd Bergmann
2012-06-29 15:05 ` Arnd Bergmann
2012-07-01 8:58 ` Tony Lindgren
2012-07-01 8:58 ` Tony Lindgren
2012-07-02 7:15 ` Arnd Bergmann
2012-07-02 7:15 ` Arnd Bergmann
2012-07-02 10:51 ` Tony Lindgren
2012-07-02 10:51 ` Tony Lindgren
2012-06-29 14:03 ` Andy Green
2012-06-29 14:03 ` Andy Green
2012-06-29 14:38 ` Arnd Bergmann
2012-06-29 14:38 ` Arnd Bergmann
2012-06-29 5:55 ` [PATCH 3/3] OMAP4 PANDA register ethernet and wlan for automatic mac allocation Andy Green
2012-06-29 5:55 ` Andy Green
2012-06-29 11:55 ` Tony Lindgren [this message]
2012-06-29 11:55 ` Tony Lindgren
2012-06-29 8:50 ` [PATCH 0/3] Add ability to set defaultless network device MAC addresses to deterministic computed locally administered values Arnd Bergmann
2012-06-29 8:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120629115511.GC4202@atomide.com \
--to=tony@atomide.com \
--cc=andy.green@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=patches@linaro.org \
--cc=rostedt@goodmis.org \
--cc=s-jan@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.