All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andy Green <andy.green@linaro.org>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	nicolas.pitre@linaro.org, s-jan@ti.com, patches@linaro.org,
	rostedt@goodmis.org
Subject: Re: [PATCH 2/3] OMAP2+ devices add mac address allocation register api
Date: Mon, 2 Jul 2012 03:51:03 -0700	[thread overview]
Message-ID: <20120702105102.GG1122@atomide.com> (raw)
In-Reply-To: <201207020715.46084.arnd@arndb.de>

* Arnd Bergmann <arnd@arndb.de> [120702 03:24]:
> On Sunday 01 July 2012, Tony Lindgren wrote:
> > > > 2. Pass the Panda mac information as platform data to this
> > > >    driver for now with a comment on the usb path naming being
> > > >    potentially wrong in the loadable modules case.
> > > 
> > > IMHO code outside of the platform driver world would be more
> > > appropriate here. It's not actually a platform device because
> > > it's more of an abstract concept to define a mac address than
> > > physical hardware.
> > 
> > Well we still need to also pass the mac address generated by
> > the SoC specific kernel init code. It seems that platform data
> > would be the obvious way to pass that. Or do you have some other
> > way in mind for that?
> 
> My point is that for platform data you need a platform device of
> some sort, but this new piece of infrastructure does not look
> like it should be a device.

OK
 
> I think a reasonable interface would be something as simple as
> 
> void register_eth_mac_fixup(const char *path, const u8 *mac);
> 
> Instead of registering a device from the platform, we just call
> this function, and leave the code built-in.

Sounds good to me.

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] OMAP2+ devices add mac address allocation register api
Date: Mon, 2 Jul 2012 03:51:03 -0700	[thread overview]
Message-ID: <20120702105102.GG1122@atomide.com> (raw)
In-Reply-To: <201207020715.46084.arnd@arndb.de>

* Arnd Bergmann <arnd@arndb.de> [120702 03:24]:
> On Sunday 01 July 2012, Tony Lindgren wrote:
> > > > 2. Pass the Panda mac information as platform data to this
> > > >    driver for now with a comment on the usb path naming being
> > > >    potentially wrong in the loadable modules case.
> > > 
> > > IMHO code outside of the platform driver world would be more
> > > appropriate here. It's not actually a platform device because
> > > it's more of an abstract concept to define a mac address than
> > > physical hardware.
> > 
> > Well we still need to also pass the mac address generated by
> > the SoC specific kernel init code. It seems that platform data
> > would be the obvious way to pass that. Or do you have some other
> > way in mind for that?
> 
> My point is that for platform data you need a platform device of
> some sort, but this new piece of infrastructure does not look
> like it should be a device.

OK
 
> I think a reasonable interface would be something as simple as
> 
> void register_eth_mac_fixup(const char *path, const u8 *mac);
> 
> Instead of registering a device from the platform, we just call
> this function, and leave the code built-in.

Sounds good to me.

Tony

  reply	other threads:[~2012-07-02 10:51 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29  5:55 [PATCH 0/3] Add ability to set defaultless network device MAC addresses to deterministic computed locally administered values Andy Green
2012-06-29  5:55 ` Andy Green
2012-06-29  5:55 ` [PATCH 1/3] OMAP2+: add cpu id register to MAC address helper Andy Green
2012-06-29  5:55   ` Andy Green
2012-06-29  9:05   ` Tony Lindgren
2012-06-29  9:05     ` Tony Lindgren
2012-06-29  9:13     ` Andy Green
2012-06-29  9:13       ` Andy Green
2012-06-29  5:55 ` [PATCH 2/3] OMAP2+ devices add mac address allocation register api Andy Green
2012-06-29  5:55   ` Andy Green
2012-06-29  8:51   ` Arnd Bergmann
2012-06-29  8:51     ` Arnd Bergmann
2012-06-29  9:03     ` Andy Green
2012-06-29  9:03       ` Andy Green
2012-06-29  9:40   ` Tony Lindgren
2012-06-29  9:40     ` Tony Lindgren
2012-06-29 10:07     ` Andy Green
2012-06-29 10:07       ` Andy Green
2012-06-29 12:03       ` Tony Lindgren
2012-06-29 12:03         ` Tony Lindgren
2012-06-29 13:45         ` Arnd Bergmann
2012-06-29 13:45           ` Arnd Bergmann
2012-06-29 13:55           ` Tony Lindgren
2012-06-29 13:55             ` Tony Lindgren
2012-06-29 13:59             ` Andy Green
2012-06-29 13:59               ` Andy Green
2012-06-29 14:33             ` Arnd Bergmann
2012-06-29 14:33               ` Arnd Bergmann
2012-06-29 14:52               ` Tony Lindgren
2012-06-29 14:52                 ` Tony Lindgren
2012-06-29 15:05                 ` Arnd Bergmann
2012-06-29 15:05                   ` Arnd Bergmann
2012-07-01  8:58                   ` Tony Lindgren
2012-07-01  8:58                     ` Tony Lindgren
2012-07-02  7:15                     ` Arnd Bergmann
2012-07-02  7:15                       ` Arnd Bergmann
2012-07-02 10:51                       ` Tony Lindgren [this message]
2012-07-02 10:51                         ` Tony Lindgren
2012-06-29 14:03           ` Andy Green
2012-06-29 14:03             ` Andy Green
2012-06-29 14:38             ` Arnd Bergmann
2012-06-29 14:38               ` Arnd Bergmann
2012-06-29  5:55 ` [PATCH 3/3] OMAP4 PANDA register ethernet and wlan for automatic mac allocation Andy Green
2012-06-29  5:55   ` Andy Green
2012-06-29 11:55   ` Tony Lindgren
2012-06-29 11:55     ` Tony Lindgren
2012-06-29  8:50 ` [PATCH 0/3] Add ability to set defaultless network device MAC addresses to deterministic computed locally administered values Arnd Bergmann
2012-06-29  8:50   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120702105102.GG1122@atomide.com \
    --to=tony@atomide.com \
    --cc=andy.green@linaro.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=patches@linaro.org \
    --cc=rostedt@goodmis.org \
    --cc=s-jan@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.