All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Dave Jones <davej@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: rcu: BUG: spinlock recursion on CPU#3, trinity-child19/5970
Date: Mon, 2 Jul 2012 07:59:27 -0700	[thread overview]
Message-ID: <20120702145927.GD2508@linux.vnet.ibm.com> (raw)
In-Reply-To: <1341239813.2958.7.camel@lappy>

On Mon, Jul 02, 2012 at 04:36:53PM +0200, Sasha Levin wrote:
> On Mon, 2012-07-02 at 07:22 -0700, Paul E. McKenney wrote:
> > > OK, so it looks like the context-switch-time call into preemptible RCU
> > > needs to be outside of the runqueue-lock critical section.  One way
> > > to do this is be reverting 616c310e (Move PREEMPT_RCU preemption to
> > > switch_to() invocation).  Sasha, could you please try this out?
> > 
> > Hmmmm...  Here is a patch for this reversion on top of -rcu with
> > conflicts resolved. 
> 
> It looks like how I've resolved it.

Good show!!!

> Just for clarity, the only rcu related patch I have on top of -next is
> this reversal one. I've dropped anything we tested before.
> 
> Looks like its running fine for a bit now (~10 min). I'll ping if
> anything changes, but on the other tests it has usually failed at this
> point.

If testing goes well (both yours and mine), I will be submitting this
as urgent, since it is a 3.5 regression.  If they don't take it, I will
queue it for 3.6.

							Thanx, Paul


  reply	other threads:[~2012-07-02 15:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 10:09 rcu: BUG: spinlock recursion on CPU#3, trinity-child19/5970 Sasha Levin
2012-06-29 17:23 ` Paul E. McKenney
2012-06-29 21:40   ` Sasha Levin
2012-06-29 22:27     ` Paul E. McKenney
2012-06-29 22:40       ` Sasha Levin
2012-06-29 23:01         ` Paul E. McKenney
2012-07-02 10:32     ` Peter Zijlstra
2012-07-02 11:35       ` Paul E. McKenney
2012-07-02 11:59         ` Peter Zijlstra
2012-07-02 13:12           ` Sasha Levin
2012-07-02 13:33             ` Paul E. McKenney
2012-07-02 14:22               ` Paul E. McKenney
2012-07-02 14:36                 ` Sasha Levin
2012-07-02 14:59                   ` Paul E. McKenney [this message]
2012-07-04 14:54                     ` Sasha Levin
2012-07-04 19:07                       ` Paul E. McKenney
2012-06-30 11:36   ` Sasha Levin
2012-06-30 13:14     ` Paul E. McKenney
2012-06-30 13:28       ` Sasha Levin
2012-06-30 13:58         ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120702145927.GD2508@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=davej@redhat.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.