From: Arnd Bergmann <arnd@arndb.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Alessandro Rubini <rubini@gnudd.com>,
linux-kernel@vger.kernel.org, giancarlo.asnaghi@st.com,
alan@linux.intel.com, linux@arm.linux.org.uk, x86@kernel.org,
gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11
Date: Mon, 2 Jul 2012 16:58:27 +0000 [thread overview]
Message-ID: <201207021658.27755.arnd@arndb.de> (raw)
In-Reply-To: <2b797c83-6a3c-4051-841a-a4cfa9d1cae1@email.android.com>
On Sunday 01 July 2012, H. Peter Anvin wrote:
>
> There is no problem with adding ARM or !X86 dependencies to drivers
> now and fixing them later or as required.
Right, but if the fix is trivial (e.g. missing #include statement), it's
usually better to just fix the code.
Also, in many cases it's possible to say specifically what some code depends
on. E.g. if a driver uses clk_get/clk_put, it should depend on CLKDEV_LOOKUP,
not on !X86.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11
Date: Mon, 2 Jul 2012 16:58:27 +0000 [thread overview]
Message-ID: <201207021658.27755.arnd@arndb.de> (raw)
In-Reply-To: <2b797c83-6a3c-4051-841a-a4cfa9d1cae1@email.android.com>
On Sunday 01 July 2012, H. Peter Anvin wrote:
>
> There is no problem with adding ARM or !X86 dependencies to drivers
> now and fixing them later or as required.
Right, but if the fix is trivial (e.g. missing #include statement), it's
usually better to just fix the code.
Also, in many cases it's possible to say specifically what some code depends
on. E.g. if a driver uses clk_get/clk_put, it should depend on CLKDEV_LOOKUP,
not on !X86.
Arnd
next prev parent reply other threads:[~2012-07-02 17:59 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1338222460.git.rubini@gnudd.com>
2012-05-28 16:37 ` [PATCH V2 1/6] sizes.h: move from asm-generic to <linux/sizes.h> Alessandro Rubini
2012-05-28 16:37 ` Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 2/6] amba: use the new linux/sizes.h Alessandro Rubini
2012-05-28 16:37 ` Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 3/6] ARM: " Alessandro Rubini
2012-05-28 16:37 ` Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 4/6] serial: " Alessandro Rubini
2012-05-28 16:37 ` Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11 Alessandro Rubini
2012-05-28 16:37 ` Alessandro Rubini
2012-06-28 20:06 ` H. Peter Anvin
2012-06-28 20:06 ` H. Peter Anvin
2012-07-01 10:44 ` Alessandro Rubini
2012-07-01 10:44 ` Alessandro Rubini
2012-07-01 10:59 ` Russell King - ARM Linux
2012-07-01 10:59 ` Russell King - ARM Linux
2012-07-01 11:04 ` Alessandro Rubini
2012-07-01 11:04 ` Alessandro Rubini
2012-07-01 11:11 ` Russell King - ARM Linux
2012-07-01 11:11 ` Russell King - ARM Linux
2012-07-01 11:58 ` Jassi Brar
2012-07-01 11:58 ` Jassi Brar
2012-07-01 12:10 ` Russell King - ARM Linux
2012-07-01 12:10 ` Russell King - ARM Linux
2012-07-01 13:11 ` Jassi Brar
2012-07-01 13:11 ` Jassi Brar
2012-07-01 14:13 ` H. Peter Anvin
2012-07-01 14:13 ` H. Peter Anvin
2012-07-02 16:58 ` Arnd Bergmann [this message]
2012-07-02 16:58 ` Arnd Bergmann
2012-07-02 18:05 ` Mark Brown
2012-07-02 18:05 ` Mark Brown
2012-07-02 18:07 ` H. Peter Anvin
2012-07-02 18:07 ` H. Peter Anvin
2012-07-02 18:33 ` Mark Brown
2012-07-02 18:33 ` Mark Brown
2012-07-02 19:41 ` H. Peter Anvin
2012-07-02 19:41 ` H. Peter Anvin
2012-07-03 11:05 ` Mark Brown
2012-07-03 11:05 ` Mark Brown
2012-07-03 13:00 ` Alessandro Rubini
2012-07-03 13:00 ` Alessandro Rubini
2012-07-03 13:19 ` Arnd Bergmann
2012-07-03 13:19 ` Arnd Bergmann
2012-07-03 13:26 ` Alessandro Rubini
2012-07-03 13:26 ` Alessandro Rubini
2012-07-03 19:46 ` Russell King - ARM Linux
2012-07-03 19:46 ` Russell King - ARM Linux
2012-07-03 19:34 ` Russell King - ARM Linux
2012-07-03 19:34 ` Russell King - ARM Linux
2012-08-05 20:28 ` Linus Walleij
2012-08-05 20:28 ` Linus Walleij
2012-08-07 10:06 ` Kukjin Kim
2012-08-07 10:06 ` Kukjin Kim
2012-05-28 16:38 ` [PATCH V2 6/6] drivers/amba: add support for a PCI bridge Alessandro Rubini
2012-05-28 16:38 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207021658.27755.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@linux.intel.com \
--cc=giancarlo.asnaghi@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rubini@gnudd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.