From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alex Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Thierry Reding
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] pwm-backlight: add regulator and GPIO support
Date: Wed, 04 Jul 2012 20:26:44 +0000 [thread overview]
Message-ID: <20120704202644.GG30009@pengutronix.de> (raw)
In-Reply-To: <4FF45DDF.9000306-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Thu, Jul 05, 2012 at 12:14:39AM +0900, Alex Courbot wrote:
> On Wed 04 Jul 2012 10:00:56 PM JST, Sascha Hauer wrote:
> >>That's very bad indeed. I assumed that the kernel would free
> >>devm-allocated resources after probe returned -EPROBE_DEFER,
> >
> >It indeed does free devm allocated resources, but neither the gpio nor
> >the pwm are devm allocated.
>
> As far as I can tell the gpio is allocated through devm as well:
>
> > + ret = devm_gpio_request_one(&pdev->dev, data->enable_gpio,
> > + GPIOF_OUT_INIT_HIGH, "backlight_enable");
You're right. For the GPIO it's ok the way it is.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Alex Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Thierry Reding
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] pwm-backlight: add regulator and GPIO support
Date: Wed, 4 Jul 2012 22:26:44 +0200 [thread overview]
Message-ID: <20120704202644.GG30009@pengutronix.de> (raw)
In-Reply-To: <4FF45DDF.9000306-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Thu, Jul 05, 2012 at 12:14:39AM +0900, Alex Courbot wrote:
> On Wed 04 Jul 2012 10:00:56 PM JST, Sascha Hauer wrote:
> >>That's very bad indeed. I assumed that the kernel would free
> >>devm-allocated resources after probe returned -EPROBE_DEFER,
> >
> >It indeed does free devm allocated resources, but neither the gpio nor
> >the pwm are devm allocated.
>
> As far as I can tell the gpio is allocated through devm as well:
>
> > + ret = devm_gpio_request_one(&pdev->dev, data->enable_gpio,
> > + GPIOF_OUT_INIT_HIGH, "backlight_enable");
You're right. For the GPIO it's ok the way it is.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alex Courbot <acourbot@nvidia.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] pwm-backlight: add regulator and GPIO support
Date: Wed, 4 Jul 2012 22:26:44 +0200 [thread overview]
Message-ID: <20120704202644.GG30009@pengutronix.de> (raw)
In-Reply-To: <4FF45DDF.9000306@nvidia.com>
On Thu, Jul 05, 2012 at 12:14:39AM +0900, Alex Courbot wrote:
> On Wed 04 Jul 2012 10:00:56 PM JST, Sascha Hauer wrote:
> >>That's very bad indeed. I assumed that the kernel would free
> >>devm-allocated resources after probe returned -EPROBE_DEFER,
> >
> >It indeed does free devm allocated resources, but neither the gpio nor
> >the pwm are devm allocated.
>
> As far as I can tell the gpio is allocated through devm as well:
>
> > + ret = devm_gpio_request_one(&pdev->dev, data->enable_gpio,
> > + GPIOF_OUT_INIT_HIGH, "backlight_enable");
You're right. For the GPIO it's ok the way it is.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-07-04 20:26 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 13:22 [PATCH] pwm-backlight: add regulator and GPIO support Alexandre Courbot
2012-06-29 13:22 ` Alexandre Courbot
2012-06-29 13:22 ` Alexandre Courbot
[not found] ` <1340976167-27298-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-06-29 16:04 ` Stephen Warren
2012-06-29 16:04 ` Stephen Warren
2012-06-29 16:04 ` Stephen Warren
[not found] ` <4FEDD222.7050905-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-30 3:54 ` Alex Courbot
2012-06-30 3:54 ` Alex Courbot
2012-06-30 3:54 ` Alex Courbot
2012-06-30 18:37 ` Thierry Reding
2012-06-30 18:37 ` Thierry Reding
2012-06-30 18:37 ` Thierry Reding
[not found] ` <20120630183742.GE23990-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-07-02 3:35 ` Alexandre Courbot
2012-07-02 3:35 ` Alexandre Courbot
2012-07-02 3:35 ` Alexandre Courbot
[not found] ` <4FF116F0.5070602-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-02 6:46 ` Thierry Reding
2012-07-02 6:46 ` Thierry Reding
2012-07-02 6:46 ` Thierry Reding
[not found] ` <20120702064624.GA8683-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-07-02 7:18 ` Alexandre Courbot
2012-07-02 7:18 ` Alexandre Courbot
2012-07-02 7:18 ` Alexandre Courbot
2012-07-04 10:48 ` Sascha Hauer
2012-07-04 10:48 ` Sascha Hauer
2012-07-04 10:48 ` Sascha Hauer
[not found] ` <20120704104840.GJ24458-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-04 12:26 ` Alex Courbot
2012-07-04 12:26 ` Alex Courbot
2012-07-04 12:26 ` Alex Courbot
[not found] ` <4FF43692.2040805-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-04 12:27 ` Mark Brown
2012-07-04 12:27 ` Mark Brown
2012-07-04 12:27 ` Mark Brown
2012-07-04 13:00 ` Sascha Hauer
2012-07-04 13:00 ` Sascha Hauer
2012-07-04 13:00 ` Sascha Hauer
[not found] ` <20120704130056.GC30009-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-04 15:14 ` Alex Courbot
2012-07-04 15:14 ` Alex Courbot
2012-07-04 15:14 ` Alex Courbot
[not found] ` <4FF45DDF.9000306-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-04 15:24 ` Mark Brown
2012-07-04 15:24 ` Mark Brown
2012-07-04 15:24 ` Mark Brown
[not found] ` <20120704152451.GA7333-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-07-05 2:36 ` Alex Courbot
2012-07-05 2:36 ` Alex Courbot
2012-07-05 2:36 ` Alex Courbot
[not found] ` <4FF4FDC0.8020405-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-05 6:20 ` Sascha Hauer
2012-07-05 6:20 ` Sascha Hauer
2012-07-05 6:20 ` Sascha Hauer
[not found] ` <20120705062011.GI30009-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-05 6:25 ` Alex Courbot
2012-07-05 6:25 ` Alex Courbot
2012-07-05 6:25 ` Alex Courbot
[not found] ` <4FF53368.6090805-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-05 6:47 ` Sascha Hauer
2012-07-05 6:47 ` Sascha Hauer
2012-07-05 6:47 ` Sascha Hauer
[not found] ` <20120705064742.GL30009-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-05 7:43 ` Alex Courbot
2012-07-05 7:43 ` Alex Courbot
2012-07-05 7:43 ` Alex Courbot
[not found] ` <4FF5459F.5090201-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-05 7:57 ` Thierry Reding
2012-07-05 7:57 ` Thierry Reding
2012-07-05 7:57 ` Thierry Reding
2012-07-05 8:12 ` Alex Courbot
2012-07-05 8:12 ` Alex Courbot
2012-07-05 16:03 ` Stephen Warren
2012-07-05 16:03 ` Stephen Warren
2012-07-09 5:19 ` Jingoo Han
2012-07-09 5:19 ` Jingoo Han
[not found] ` <00ae01cd5d92$70d1f9f0$5275edd0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-07-09 6:12 ` Alex Courbot
2012-07-09 6:12 ` Alex Courbot
2012-07-09 6:12 ` Alex Courbot
2012-07-05 8:02 ` Sascha Hauer
2012-07-05 8:02 ` Sascha Hauer
2012-07-05 8:02 ` Sascha Hauer
2012-07-05 10:41 ` Mark Brown
2012-07-05 10:41 ` Mark Brown
2012-07-05 10:39 ` Mark Brown
2012-07-05 10:39 ` Mark Brown
2012-07-05 10:39 ` Mark Brown
2012-07-05 10:37 ` Mark Brown
2012-07-05 10:37 ` Mark Brown
2012-07-04 20:26 ` Sascha Hauer [this message]
2012-07-04 20:26 ` Sascha Hauer
2012-07-04 20:26 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704202644.GG30009@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.