From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Alex Courbot <acourbot@nvidia.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Thierry Reding <thierry.reding@avionic-design.de>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] pwm-backlight: add regulator and GPIO support
Date: Thu, 05 Jul 2012 10:37:02 +0000 [thread overview]
Message-ID: <20120705103702.GN4111@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FF53368.6090805@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Thu, Jul 05, 2012 at 03:25:44PM +0900, Alex Courbot wrote:
> On 07/05/2012 03:20 PM, Sascha Hauer wrote:
> >I think the only way doing this is to add a flag to platform_data. I
> >don't know if that's accepted though.
> I thought about just checking if devm_get_regulator returned -ENODEV
> and happily continue if that was the case, assuming no regulator was
> declared.
No, that's really not a good idea - as I keep saying if we really want
to go down that line we should remove all error checking instead, it's
the end result.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Alex Courbot <acourbot@nvidia.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Thierry Reding <thierry.reding@avionic-design.de>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] pwm-backlight: add regulator and GPIO support
Date: Thu, 5 Jul 2012 11:37:02 +0100 [thread overview]
Message-ID: <20120705103702.GN4111@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FF53368.6090805@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Thu, Jul 05, 2012 at 03:25:44PM +0900, Alex Courbot wrote:
> On 07/05/2012 03:20 PM, Sascha Hauer wrote:
> >I think the only way doing this is to add a flag to platform_data. I
> >don't know if that's accepted though.
> I thought about just checking if devm_get_regulator returned -ENODEV
> and happily continue if that was the case, assuming no regulator was
> declared.
No, that's really not a good idea - as I keep saying if we really want
to go down that line we should remove all error checking instead, it's
the end result.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-05 10:37 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 13:22 [PATCH] pwm-backlight: add regulator and GPIO support Alexandre Courbot
2012-06-29 13:22 ` Alexandre Courbot
2012-06-29 13:22 ` Alexandre Courbot
[not found] ` <1340976167-27298-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-06-29 16:04 ` Stephen Warren
2012-06-29 16:04 ` Stephen Warren
2012-06-29 16:04 ` Stephen Warren
[not found] ` <4FEDD222.7050905-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-30 3:54 ` Alex Courbot
2012-06-30 3:54 ` Alex Courbot
2012-06-30 3:54 ` Alex Courbot
2012-06-30 18:37 ` Thierry Reding
2012-06-30 18:37 ` Thierry Reding
2012-06-30 18:37 ` Thierry Reding
[not found] ` <20120630183742.GE23990-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-07-02 3:35 ` Alexandre Courbot
2012-07-02 3:35 ` Alexandre Courbot
2012-07-02 3:35 ` Alexandre Courbot
[not found] ` <4FF116F0.5070602-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-02 6:46 ` Thierry Reding
2012-07-02 6:46 ` Thierry Reding
2012-07-02 6:46 ` Thierry Reding
[not found] ` <20120702064624.GA8683-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-07-02 7:18 ` Alexandre Courbot
2012-07-02 7:18 ` Alexandre Courbot
2012-07-02 7:18 ` Alexandre Courbot
2012-07-04 10:48 ` Sascha Hauer
2012-07-04 10:48 ` Sascha Hauer
2012-07-04 10:48 ` Sascha Hauer
[not found] ` <20120704104840.GJ24458-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-04 12:26 ` Alex Courbot
2012-07-04 12:26 ` Alex Courbot
2012-07-04 12:26 ` Alex Courbot
[not found] ` <4FF43692.2040805-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-04 12:27 ` Mark Brown
2012-07-04 12:27 ` Mark Brown
2012-07-04 12:27 ` Mark Brown
2012-07-04 13:00 ` Sascha Hauer
2012-07-04 13:00 ` Sascha Hauer
2012-07-04 13:00 ` Sascha Hauer
[not found] ` <20120704130056.GC30009-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-04 15:14 ` Alex Courbot
2012-07-04 15:14 ` Alex Courbot
2012-07-04 15:14 ` Alex Courbot
[not found] ` <4FF45DDF.9000306-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-04 15:24 ` Mark Brown
2012-07-04 15:24 ` Mark Brown
2012-07-04 15:24 ` Mark Brown
[not found] ` <20120704152451.GA7333-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-07-05 2:36 ` Alex Courbot
2012-07-05 2:36 ` Alex Courbot
2012-07-05 2:36 ` Alex Courbot
[not found] ` <4FF4FDC0.8020405-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-05 6:20 ` Sascha Hauer
2012-07-05 6:20 ` Sascha Hauer
2012-07-05 6:20 ` Sascha Hauer
[not found] ` <20120705062011.GI30009-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-05 6:25 ` Alex Courbot
2012-07-05 6:25 ` Alex Courbot
2012-07-05 6:25 ` Alex Courbot
[not found] ` <4FF53368.6090805-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-05 6:47 ` Sascha Hauer
2012-07-05 6:47 ` Sascha Hauer
2012-07-05 6:47 ` Sascha Hauer
[not found] ` <20120705064742.GL30009-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-05 7:43 ` Alex Courbot
2012-07-05 7:43 ` Alex Courbot
2012-07-05 7:43 ` Alex Courbot
[not found] ` <4FF5459F.5090201-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-05 7:57 ` Thierry Reding
2012-07-05 7:57 ` Thierry Reding
2012-07-05 7:57 ` Thierry Reding
2012-07-05 8:12 ` Alex Courbot
2012-07-05 8:12 ` Alex Courbot
2012-07-05 16:03 ` Stephen Warren
2012-07-05 16:03 ` Stephen Warren
2012-07-09 5:19 ` Jingoo Han
2012-07-09 5:19 ` Jingoo Han
[not found] ` <00ae01cd5d92$70d1f9f0$5275edd0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-07-09 6:12 ` Alex Courbot
2012-07-09 6:12 ` Alex Courbot
2012-07-09 6:12 ` Alex Courbot
2012-07-05 8:02 ` Sascha Hauer
2012-07-05 8:02 ` Sascha Hauer
2012-07-05 8:02 ` Sascha Hauer
2012-07-05 10:41 ` Mark Brown
2012-07-05 10:41 ` Mark Brown
2012-07-05 10:39 ` Mark Brown
2012-07-05 10:39 ` Mark Brown
2012-07-05 10:39 ` Mark Brown
2012-07-05 10:37 ` Mark Brown [this message]
2012-07-05 10:37 ` Mark Brown
2012-07-04 20:26 ` Sascha Hauer
2012-07-04 20:26 ` Sascha Hauer
2012-07-04 20:26 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705103702.GN4111@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=acourbot@nvidia.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.