All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	joshhunt00@gmail.com, axboe@kernel.dk, rni@google.com,
	vgoyal@redhat.com, vwadekar@nvidia.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	linux-crypto@vger.kernel.org, swhiteho@redhat.com, bpm@sgi.com,
	elder@kernel.org, xfs@oss.sgi.com, marcel@holtmann.org,
	gustavo@padovan.org, johan.hedberg@gmail.com,
	linux-bluetooth@vger.kernel.org, martin.petersen@oracle.com
Subject: Re: [PATCH 2/6] workqueue: factor out worker_pool from global_cwq
Date: Thu, 12 Jul 2012 10:07:52 -0700	[thread overview]
Message-ID: <20120712170752.GC20167@google.com> (raw)
In-Reply-To: <87ehok8bmb.fsf@sejong.aot.lge.com>

Hello, Namhyung.

Sorry about the delay.

On Tue, Jul 10, 2012 at 01:48:44PM +0900, Namhyung Kim wrote:
> > +	struct list_head	idle_list;	/* X: list of idle workers */
> > +	struct timer_list	idle_timer;	/* L: worker idle timeout */
> > +	struct timer_list	mayday_timer;	/* L: SOS timer for dworkers */
> 
> What is 'dworkers'?

My stupid finger pressing 'd' when I never meant to. :)

> > -	/* workers are chained either in the idle_list or busy_hash */
> > -	struct list_head	idle_list;	/* X: list of idle workers */
> > +	/* workers are chained either in busy_head or pool idle_list */
> 
> s/busy_head/busy_hash/ ?

Will fix.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: axboe@kernel.dk, elder@kernel.org, rni@google.com,
	martin.petersen@oracle.com, linux-bluetooth@vger.kernel.org,
	torvalds@linux-foundation.org, marcel@holtmann.org,
	linux-kernel@vger.kernel.org, vwadekar@nvidia.com,
	swhiteho@redhat.com, herbert@gondor.hengli.com.au, bpm@sgi.com,
	linux-crypto@vger.kernel.org, gustavo@padovan.org,
	xfs@oss.sgi.com, joshhunt00@gmail.com, davem@davemloft.net,
	vgoyal@redhat.com, johan.hedberg@gmail.com
Subject: Re: [PATCH 2/6] workqueue: factor out worker_pool from global_cwq
Date: Thu, 12 Jul 2012 10:07:52 -0700	[thread overview]
Message-ID: <20120712170752.GC20167@google.com> (raw)
In-Reply-To: <87ehok8bmb.fsf@sejong.aot.lge.com>

Hello, Namhyung.

Sorry about the delay.

On Tue, Jul 10, 2012 at 01:48:44PM +0900, Namhyung Kim wrote:
> > +	struct list_head	idle_list;	/* X: list of idle workers */
> > +	struct timer_list	idle_timer;	/* L: worker idle timeout */
> > +	struct timer_list	mayday_timer;	/* L: SOS timer for dworkers */
> 
> What is 'dworkers'?

My stupid finger pressing 'd' when I never meant to. :)

> > -	/* workers are chained either in the idle_list or busy_hash */
> > -	struct list_head	idle_list;	/* X: list of idle workers */
> > +	/* workers are chained either in busy_head or pool idle_list */
> 
> s/busy_head/busy_hash/ ?

Will fix.

Thanks.

-- 
tejun

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	joshhunt00@gmail.com, axboe@kernel.dk, rni@google.com,
	vgoyal@redhat.com, vwadekar@nvidia.com,
	herbert@gondor.hengli.com.au, davem@davemloft.net,
	linux-crypto@vger.kernel.org, swhiteho@redhat.com, bpm@sgi.com,
	elder@kernel.org, xfs@oss.sgi.com, marcel@holtmann.org,
	gustavo@padovan.org, johan.hedberg@gmail.com,
	linux-bluetooth@vger.kernel.org, martin.petersen@oracle.com
Subject: Re: [PATCH 2/6] workqueue: factor out worker_pool from global_cwq
Date: Thu, 12 Jul 2012 10:07:52 -0700	[thread overview]
Message-ID: <20120712170752.GC20167@google.com> (raw)
In-Reply-To: <87ehok8bmb.fsf@sejong.aot.lge.com>

Hello, Namhyung.

Sorry about the delay.

On Tue, Jul 10, 2012 at 01:48:44PM +0900, Namhyung Kim wrote:
> > +	struct list_head	idle_list;	/* X: list of idle workers */
> > +	struct timer_list	idle_timer;	/* L: worker idle timeout */
> > +	struct timer_list	mayday_timer;	/* L: SOS timer for dworkers */
> 
> What is 'dworkers'?

My stupid finger pressing 'd' when I never meant to. :)

> > -	/* workers are chained either in the idle_list or busy_hash */
> > -	struct list_head	idle_list;	/* X: list of idle workers */
> > +	/* workers are chained either in busy_head or pool idle_list */
> 
> s/busy_head/busy_hash/ ?

Will fix.

Thanks.

-- 
tejun

  reply	other threads:[~2012-07-12 17:07 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 18:41 [PATCHSET] workqueue: reimplement high priority using a separate worker pool Tejun Heo
2012-07-09 18:41 ` Tejun Heo
     [not found] ` <1341859315-17759-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-07-09 18:41   ` [PATCH 1/6] workqueue: don't use WQ_HIGHPRI for unbound workqueues Tejun Heo
2012-07-09 18:41     ` Tejun Heo
2012-07-09 18:41     ` Tejun Heo
2012-07-09 18:41 ` [PATCH 2/6] workqueue: factor out worker_pool from global_cwq Tejun Heo
2012-07-09 18:41   ` Tejun Heo
2012-07-09 18:41   ` Tejun Heo
2012-07-10  4:48   ` Namhyung Kim
2012-07-10  4:48     ` Namhyung Kim
2012-07-10  4:48     ` Namhyung Kim
2012-07-12 17:07     ` Tejun Heo [this message]
2012-07-12 17:07       ` Tejun Heo
2012-07-12 17:07       ` Tejun Heo
     [not found]   ` <1341859315-17759-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-07-12 21:49     ` [PATCH UPDATED " Tejun Heo
2012-07-12 21:49       ` Tejun Heo
2012-07-12 21:49       ` Tejun Heo
2012-07-09 18:41 ` [PATCH 3/6] workqueue: use @pool instead of @gcwq or @cpu where applicable Tejun Heo
2012-07-09 18:41   ` Tejun Heo
2012-07-09 18:41   ` Tejun Heo
     [not found]   ` <1341859315-17759-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-07-10 23:30     ` Tony Luck
2012-07-10 23:30       ` Tony Luck
2012-07-10 23:30       ` Tony Luck
2012-07-12 17:06       ` Tejun Heo
2012-07-12 17:06         ` Tejun Heo
2012-07-12 17:06         ` Tejun Heo
2012-07-09 18:41 ` [PATCH 4/6] workqueue: separate out worker_pool flags Tejun Heo
2012-07-09 18:41   ` Tejun Heo
2012-07-09 18:41   ` Tejun Heo
2012-07-09 18:41 ` [PATCH 5/6] workqueue: introduce NR_WORKER_POOLS and for_each_worker_pool() Tejun Heo
2012-07-09 18:41   ` Tejun Heo
2012-07-09 18:41   ` Tejun Heo
2012-07-14  3:55   ` Tejun Heo
2012-07-14  3:55     ` Tejun Heo
2012-07-14  3:55     ` Tejun Heo
2012-07-14  4:27     ` Linus Torvalds
2012-07-14  4:27       ` Linus Torvalds
2012-07-14  4:27       ` Linus Torvalds
     [not found]       ` <CA+55aFyeauqCqrWsx4U2TB2ENrugZXYj+4vw3Fd0kGaeWBP3RA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-14  4:44         ` Tejun Heo
2012-07-14  4:44           ` Tejun Heo
2012-07-14  4:44           ` Tejun Heo
2012-07-14  5:00           ` Linus Torvalds
2012-07-14  5:00             ` Linus Torvalds
2012-07-14  5:00             ` Linus Torvalds
2012-07-14  5:07             ` Tejun Heo
2012-07-14  5:07               ` Tejun Heo
2012-07-14  5:07               ` Tejun Heo
2012-07-16 19:31             ` Peter Seebach
     [not found]   ` <1341859315-17759-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-07-14  5:21     ` [PATCH UPDATED " Tejun Heo
2012-07-14  5:21       ` Tejun Heo
2012-07-14  5:21       ` Tejun Heo
2012-07-09 18:41 ` [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool Tejun Heo
2012-07-09 18:41   ` Tejun Heo
2012-07-09 18:41   ` Tejun Heo
     [not found]   ` <1341859315-17759-7-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-07-12 13:06     ` Fengguang Wu
2012-07-12 13:06       ` Fengguang Wu
2012-07-12 13:06       ` Fengguang Wu
2012-07-12 17:05       ` Tejun Heo
2012-07-12 17:05         ` Tejun Heo
2012-07-12 17:05         ` Tejun Heo
2012-07-12 21:45         ` Tejun Heo
2012-07-12 21:45           ` Tejun Heo
2012-07-12 21:45           ` Tejun Heo
2012-07-12 22:16           ` Tony Luck
2012-07-12 22:16             ` Tony Luck
2012-07-12 22:16             ` Tony Luck
2012-07-12 22:32             ` Tejun Heo
2012-07-12 22:32               ` Tejun Heo
2012-07-12 22:32               ` Tejun Heo
2012-07-12 23:24               ` Tony Luck
2012-07-12 23:24                 ` Tony Luck
2012-07-12 23:24                 ` Tony Luck
2012-07-12 23:36                 ` Tejun Heo
2012-07-12 23:36                   ` Tejun Heo
2012-07-12 23:36                   ` Tejun Heo
2012-07-12 23:46                   ` Tony Luck
2012-07-12 23:46                     ` Tony Luck
2012-07-12 23:46                     ` Tony Luck
2012-07-13 17:51                     ` Tony Luck
2012-07-13 17:51                       ` Tony Luck
2012-07-13 17:51                       ` Tony Luck
2012-07-13  2:08           ` Fengguang Wu
2012-07-13  2:08             ` Fengguang Wu
2012-07-13  2:08             ` Fengguang Wu
2012-07-14  3:41             ` Tejun Heo
2012-07-14  3:41               ` Tejun Heo
2012-07-14  3:41               ` Tejun Heo
2012-07-14  3:56   ` [PATCH UPDATED " Tejun Heo
2012-07-14  3:56     ` Tejun Heo
2012-07-14  3:56     ` Tejun Heo
2012-07-14  8:18     ` Fengguang Wu
2012-07-14  8:18       ` Fengguang Wu
2012-07-14  8:18       ` Fengguang Wu
2012-07-14  5:24   ` [PATCH UPDATED v3 " Tejun Heo
2012-07-14  5:24     ` Tejun Heo
2012-07-14  5:24     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120712170752.GC20167@google.com \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bpm@sgi.com \
    --cc=davem@davemloft.net \
    --cc=elder@kernel.org \
    --cc=gustavo@padovan.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=johan.hedberg@gmail.com \
    --cc=joshhunt00@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=martin.petersen@oracle.com \
    --cc=namhyung@kernel.org \
    --cc=rni@google.com \
    --cc=swhiteho@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vgoyal@redhat.com \
    --cc=vwadekar@nvidia.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.