Re: [PATCH] mtd: add a new macro about the subpage write

[Marek Vasut <marex@denx.de>]

Dear Huang Shijie,

> Hi Brian:
> > Wood [1]; I don't see a good reason not to just kill the
> > NAND_CHIPOPTIONS_MSK instead of adding more flags. As long as we
> > perform a few sanity tests, I think it'd be safe.
> 
> I think it's more clear in logic to add this new macro:
>     The NAND_NO_SUBPAGE_WRITE can be used only by the MLC nands which do
> no support the subpage write;
>     The NAND_CONTROLLER_NO_SUBPAGE_WRITE only used by the nand
> controller such as gpmi nand.

It's not clearer at all. It's just more error-prone.

> But I will be happy if you submit a patch to fix this issue by removing
> the NAND_CHIPOPTIONS_MSK.

I'd be happy if the GPMI NAND driver was properly fixed, 6 months after 
reporting this bug, which is quite critical as UBI doesn't work because of that 
and it's being silently ignored.

> thanks
> Huang Shijie

Best regards,
Marek Vasut