From: Marek Vasut <marex@denx.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: dedekind1@gmail.com, Jan Weitzel <j.weitzel@phytec.de>,
Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org,
Scott Wood <scottwood@freescale.com>,
Huang Shijie <shijie8@gmail.com>
Subject: Re: [PATCH] mtd: add a new macro about the subpage write
Date: Fri, 13 Jul 2012 19:10:35 +0200 [thread overview]
Message-ID: <201207131910.35337.marex@denx.de> (raw)
In-Reply-To: <CAN8TOE_XF=ou5Nb9ErNhVM4TRHkAitAjGbien5xZTGz_sZZFUA@mail.gmail.com>
Dear Brian Norris,
> On Fri, Jul 13, 2012 at 9:53 AM, Marek Vasut <marex@denx.de> wrote:
> >> On 07/13/2012 11:08 AM, Huang Shijie wrote:
> >> > On Fri, Jul 13, 2012 at 11:40 AM, Marek Vasut <marex@denx.de> wrote:
> >> >> Why not remove the mask?
> >> >
> >> > I do not understand why this line was added here, was it added on
> >> > purpose? so I am not sure whether we can just remove this line.
> >>
> >> If whoever wanted that line to be there cared enough, they could have
> >> justified it with a comment (in the code, in the changelog, or in one of
> >> these threads). We can't just let cruft sit there (or worse, produce
> >> more cruft to work around existing cruft) just because we don't know
> >> exactly what the original author was thinking. It appears to just have
> >> been a misguided attempt at enforcing any given option to come from only
> >> one place.
> >
> > I think it was there to allow having two different chips on the same NAND
> > bus ... or something. But this is just a guess. Anyway, it proved
> > irrelevant, so let's drop it.
>
> I agree. Then review/test/ack my patch that I just sent :)
It's in the queue, as I'm really interested to see this finally fixed.
> Brian
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-13 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 5:32 [PATCH] mtd: add a new macro about the subpage write Huang Shijie
2012-07-11 6:07 ` Brian Norris
2012-07-11 7:13 ` Huang Shijie
2012-07-13 10:35 ` Marek Vasut
2012-07-13 14:00 ` Huang Shijie
2012-07-13 15:40 ` Marek Vasut
2012-07-13 16:08 ` Huang Shijie
2012-07-13 16:28 ` Marek Vasut
2012-07-13 16:29 ` Scott Wood
2012-07-13 16:53 ` Marek Vasut
2012-07-13 17:02 ` Brian Norris
2012-07-13 17:10 ` Marek Vasut [this message]
2012-07-13 17:35 ` [PATCH] mtd: add a new macro about the subpage write (REPORT SPAM) William F.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207131910.35337.marex@denx.de \
--to=marex@denx.de \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=j.weitzel@phytec.de \
--cc=linux-mtd@lists.infradead.org \
--cc=scottwood@freescale.com \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.