All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: marex@denx.de, dedekind1@gmail.com,
	"Jan Weitzel" <j.weitzel@phytec.de>,
	"Marek Vašut" <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org,
	"Scott Wood" <scottwood@freescale.com>,
	"Huang Shijie" <shijie8@gmail.com>
Subject: Re: [PATCH] mtd: add a new macro about the subpage write
Date: Wed, 11 Jul 2012 15:13:37 +0800	[thread overview]
Message-ID: <4FFD27A1.9000008@freescale.com> (raw)
In-Reply-To: <CAN8TOE-59M6UCW91QS0_ZKzBO-HUyXrUXcmW3avOd8=4CmE4Fg@mail.gmail.com>

Hi Brian:
> Wood [1]; I don't see a good reason not to just kill the
> NAND_CHIPOPTIONS_MSK instead of adding more flags. As long as we
> perform a few sanity tests, I think it'd be safe.
>
I think it's more clear in logic to add this new macro:
    The NAND_NO_SUBPAGE_WRITE can be used only by the MLC nands which do 
no support the subpage write;
    The NAND_CONTROLLER_NO_SUBPAGE_WRITE only used by the nand 
controller such as gpmi nand.

But I will be happy if you submit a patch to fix this issue by removing 
the NAND_CHIPOPTIONS_MSK.

thanks
Huang Shijie

  reply	other threads:[~2012-07-11  7:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03  5:32 [PATCH] mtd: add a new macro about the subpage write Huang Shijie
2012-07-11  6:07 ` Brian Norris
2012-07-11  7:13   ` Huang Shijie [this message]
2012-07-13 10:35     ` Marek Vasut
2012-07-13 14:00       ` Huang Shijie
2012-07-13 15:40         ` Marek Vasut
2012-07-13 16:08           ` Huang Shijie
2012-07-13 16:28             ` Marek Vasut
2012-07-13 16:29             ` Scott Wood
2012-07-13 16:53               ` Marek Vasut
2012-07-13 17:02                 ` Brian Norris
2012-07-13 17:10                   ` Marek Vasut
2012-07-13 17:35                     ` [PATCH] mtd: add a new macro about the subpage write (REPORT SPAM) William F.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFD27A1.9000008@freescale.com \
    --to=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=j.weitzel@phytec.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=marex@denx.de \
    --cc=scottwood@freescale.com \
    --cc=shijie8@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.