From: Fengguang Wu <fengguang.wu@intel.com>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Axel Lin <axel.lin@gmail.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests
Date: Sat, 28 Jul 2012 12:34:41 +0000 [thread overview]
Message-ID: <20120728123441.GB11202@localhost> (raw)
Hi Venu,
Is this coccinelle warning a trivial one, or indicates some copy&paste
error? It's introduced by commit 3c33be06 ("mfd: Add support for
TPS65090").
drivers/mfd/tps65090.c:239:5-30: duplicated argument to && or ||
vim +239 drivers/mfd/tps65090.c
236
237 static bool is_volatile_reg(struct device *dev, unsigned int reg)
238 {
> 239 if ((reg = TPS65090_INT_STS) || (reg = TPS65090_INT_STS))
240 return true;
241 else
242 return false;
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com> Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Axel Lin <axel.lin@gmail.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests
Date: Sat, 28 Jul 2012 20:34:41 +0800 [thread overview]
Message-ID: <20120728123441.GB11202@localhost> (raw)
Hi Venu,
Is this coccinelle warning a trivial one, or indicates some copy&paste
error? It's introduced by commit 3c33be06 ("mfd: Add support for
TPS65090").
drivers/mfd/tps65090.c:239:5-30: duplicated argument to && or ||
vim +239 drivers/mfd/tps65090.c
236
237 static bool is_volatile_reg(struct device *dev, unsigned int reg)
238 {
> 239 if ((reg == TPS65090_INT_STS) || (reg == TPS65090_INT_STS))
240 return true;
241 else
242 return false;
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com> Intel Corporation
next reply other threads:[~2012-07-28 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 12:34 Fengguang Wu [this message]
2012-07-28 12:34 ` drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests Fengguang Wu
2012-07-30 6:01 ` Venu Byravarasu
2012-07-30 6:13 ` Venu Byravarasu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120728123441.GB11202@localhost \
--to=fengguang.wu@intel.com \
--cc=axel.lin@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.