* drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests
@ 2012-07-28 12:34 ` Fengguang Wu
0 siblings, 0 replies; 4+ messages in thread
From: Fengguang Wu @ 2012-07-28 12:34 UTC (permalink / raw)
To: Venu Byravarasu; +Cc: Samuel Ortiz, Axel Lin, kernel-janitors, LKML
Hi Venu,
Is this coccinelle warning a trivial one, or indicates some copy&paste
error? It's introduced by commit 3c33be06 ("mfd: Add support for
TPS65090").
drivers/mfd/tps65090.c:239:5-30: duplicated argument to && or ||
vim +239 drivers/mfd/tps65090.c
236
237 static bool is_volatile_reg(struct device *dev, unsigned int reg)
238 {
> 239 if ((reg = TPS65090_INT_STS) || (reg = TPS65090_INT_STS))
240 return true;
241 else
242 return false;
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com> Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread* drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests
@ 2012-07-28 12:34 ` Fengguang Wu
0 siblings, 0 replies; 4+ messages in thread
From: Fengguang Wu @ 2012-07-28 12:34 UTC (permalink / raw)
To: Venu Byravarasu; +Cc: Samuel Ortiz, Axel Lin, kernel-janitors, LKML
Hi Venu,
Is this coccinelle warning a trivial one, or indicates some copy&paste
error? It's introduced by commit 3c33be06 ("mfd: Add support for
TPS65090").
drivers/mfd/tps65090.c:239:5-30: duplicated argument to && or ||
vim +239 drivers/mfd/tps65090.c
236
237 static bool is_volatile_reg(struct device *dev, unsigned int reg)
238 {
> 239 if ((reg == TPS65090_INT_STS) || (reg == TPS65090_INT_STS))
240 return true;
241 else
242 return false;
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com> Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests
2012-07-28 12:34 ` Fengguang Wu
@ 2012-07-30 6:13 ` Venu Byravarasu
-1 siblings, 0 replies; 4+ messages in thread
From: Venu Byravarasu @ 2012-07-30 6:01 UTC (permalink / raw)
To: Fengguang Wu
Cc: Samuel Ortiz, Axel Lin, kernel-janitors@vger.kernel.org, LKML
Thanks for catching typo.
Plz push a patch with fix.
Thanks,
Venu
> -----Original Message-----
> From: Fengguang Wu [mailto:fengguang.wu@intel.com]
> Sent: Saturday, July 28, 2012 6:05 PM
> To: Venu Byravarasu
> Cc: Samuel Ortiz; Axel Lin; kernel-janitors@vger.kernel.org; LKML
> Subject: drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests
>
> Hi Venu,
>
> Is this coccinelle warning a trivial one, or indicates some copy&paste
> error? It's introduced by commit 3c33be06 ("mfd: Add support for
> TPS65090").
>
> drivers/mfd/tps65090.c:239:5-30: duplicated argument to && or ||
>
> vim +239 drivers/mfd/tps65090.c
> 236
> 237 static bool is_volatile_reg(struct device *dev, unsigned int reg)
> 238 {
> > 239 if ((reg == TPS65090_INT_STS) || (reg == TPS65090_INT_STS))
> 240 return true;
> 241 else
> 242 return false;
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Centre
> Fengguang Wu <wfg@linux.intel.com> Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests
@ 2012-07-30 6:13 ` Venu Byravarasu
0 siblings, 0 replies; 4+ messages in thread
From: Venu Byravarasu @ 2012-07-30 6:13 UTC (permalink / raw)
To: Fengguang Wu
Cc: Samuel Ortiz, Axel Lin, kernel-janitors@vger.kernel.org, LKML
Thanks for catching typo.
Plz push a patch with fix.
Thanks,
Venu
> -----Original Message-----
> From: Fengguang Wu [mailto:fengguang.wu@intel.com]
> Sent: Saturday, July 28, 2012 6:05 PM
> To: Venu Byravarasu
> Cc: Samuel Ortiz; Axel Lin; kernel-janitors@vger.kernel.org; LKML
> Subject: drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests
>
> Hi Venu,
>
> Is this coccinelle warning a trivial one, or indicates some copy&paste
> error? It's introduced by commit 3c33be06 ("mfd: Add support for
> TPS65090").
>
> drivers/mfd/tps65090.c:239:5-30: duplicated argument to && or ||
>
> vim +239 drivers/mfd/tps65090.c
> 236
> 237 static bool is_volatile_reg(struct device *dev, unsigned int reg)
> 238 {
> > 239 if ((reg = TPS65090_INT_STS) || (reg = TPS65090_INT_STS))
> 240 return true;
> 241 else
> 242 return false;
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Centre
> Fengguang Wu <wfg@linux.intel.com> Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-30 6:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-28 12:34 drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests Fengguang Wu
2012-07-28 12:34 ` Fengguang Wu
2012-07-30 6:01 ` Venu Byravarasu
2012-07-30 6:13 ` Venu Byravarasu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.