* [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
@ 2012-07-27 11:18 ` Dong Aisheng
0 siblings, 0 replies; 10+ messages in thread
From: Dong Aisheng @ 2012-07-27 11:18 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: alsa-devel, broonie, lrg
From: Dong Aisheng <dong.aisheng@linaro.org>
LINE_IN also needs VAG_POWER on or we may hear noise when directly
route LINE_IN to Headphone Mux.
Tested on imx28evk.
Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
---
sound/soc/codecs/sgtl5000.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 5c54b6f..df2f99d 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -239,6 +239,7 @@ static const struct snd_soc_dapm_route sgtl5000_dapm_routes[] = {
{"Headphone Mux", "DAC", "DAC"}, /* dac --> hp_mux */
{"LO", NULL, "DAC"}, /* dac --> line_out */
+ {"LINE_IN", NULL, "VAG_POWER"},
{"Headphone Mux", "LINE_IN", "LINE_IN"},/* line_in --> hp_mux */
{"HP", NULL, "Headphone Mux"}, /* hp_mux --> hp */
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
@ 2012-07-27 11:18 ` Dong Aisheng
0 siblings, 0 replies; 10+ messages in thread
From: Dong Aisheng @ 2012-07-27 11:18 UTC (permalink / raw)
To: linux-arm-kernel
From: Dong Aisheng <dong.aisheng@linaro.org>
LINE_IN also needs VAG_POWER on or we may hear noise when directly
route LINE_IN to Headphone Mux.
Tested on imx28evk.
Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
---
sound/soc/codecs/sgtl5000.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 5c54b6f..df2f99d 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -239,6 +239,7 @@ static const struct snd_soc_dapm_route sgtl5000_dapm_routes[] = {
{"Headphone Mux", "DAC", "DAC"}, /* dac --> hp_mux */
{"LO", NULL, "DAC"}, /* dac --> line_out */
+ {"LINE_IN", NULL, "VAG_POWER"},
{"Headphone Mux", "LINE_IN", "LINE_IN"},/* line_in --> hp_mux */
{"HP", NULL, "Headphone Mux"}, /* hp_mux --> hp */
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
2012-07-27 11:18 ` Dong Aisheng
@ 2012-07-28 14:39 ` Shawn Guo
-1 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2012-07-28 14:39 UTC (permalink / raw)
To: Dong Aisheng; +Cc: alsa-devel, broonie, lrg, linux-arm-kernel
On Fri, Jul 27, 2012 at 07:18:42PM +0800, Dong Aisheng wrote:
> From: Dong Aisheng <dong.aisheng@linaro.org>
>
> LINE_IN also needs VAG_POWER on or we may hear noise when directly
> route LINE_IN to Headphone Mux.
The following is what I see from sgtl5000 data sheet about VAG_POWER.
VAG is the internal voltage reference for the ADC and DAC.
Are you seeing any info that requires VAG_POWER in route of LINE_IN to
Headphone Mux? Or it's only a result from your testing?
Does it also fix the noise issue you mentioned with normal recording
(LINE_IN to ADC) before?
Regards,
Shawn
> Tested on imx28evk.
>
> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
> ---
> sound/soc/codecs/sgtl5000.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
> index 5c54b6f..df2f99d 100644
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -239,6 +239,7 @@ static const struct snd_soc_dapm_route sgtl5000_dapm_routes[] = {
> {"Headphone Mux", "DAC", "DAC"}, /* dac --> hp_mux */
> {"LO", NULL, "DAC"}, /* dac --> line_out */
>
> + {"LINE_IN", NULL, "VAG_POWER"},
> {"Headphone Mux", "LINE_IN", "LINE_IN"},/* line_in --> hp_mux */
> {"HP", NULL, "Headphone Mux"}, /* hp_mux --> hp */
>
> --
> 1.7.0.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [alsa-devel] [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
@ 2012-07-28 14:39 ` Shawn Guo
0 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2012-07-28 14:39 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 27, 2012 at 07:18:42PM +0800, Dong Aisheng wrote:
> From: Dong Aisheng <dong.aisheng@linaro.org>
>
> LINE_IN also needs VAG_POWER on or we may hear noise when directly
> route LINE_IN to Headphone Mux.
The following is what I see from sgtl5000 data sheet about VAG_POWER.
VAG is the internal voltage reference for the ADC and DAC.
Are you seeing any info that requires VAG_POWER in route of LINE_IN to
Headphone Mux? Or it's only a result from your testing?
Does it also fix the noise issue you mentioned with normal recording
(LINE_IN to ADC) before?
Regards,
Shawn
> Tested on imx28evk.
>
> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
> ---
> sound/soc/codecs/sgtl5000.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
> index 5c54b6f..df2f99d 100644
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -239,6 +239,7 @@ static const struct snd_soc_dapm_route sgtl5000_dapm_routes[] = {
> {"Headphone Mux", "DAC", "DAC"}, /* dac --> hp_mux */
> {"LO", NULL, "DAC"}, /* dac --> line_out */
>
> + {"LINE_IN", NULL, "VAG_POWER"},
> {"Headphone Mux", "LINE_IN", "LINE_IN"},/* line_in --> hp_mux */
> {"HP", NULL, "Headphone Mux"}, /* hp_mux --> hp */
>
> --
> 1.7.0.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
2012-07-28 14:39 ` [alsa-devel] " Shawn Guo
@ 2012-07-31 15:46 ` Mark Brown
-1 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2012-07-31 15:46 UTC (permalink / raw)
To: Shawn Guo; +Cc: alsa-devel, Dong Aisheng, lrg, linux-arm-kernel
On Sat, Jul 28, 2012 at 10:39:59PM +0800, Shawn Guo wrote:
> On Fri, Jul 27, 2012 at 07:18:42PM +0800, Dong Aisheng wrote:
> > LINE_IN also needs VAG_POWER on or we may hear noise when directly
> > route LINE_IN to Headphone Mux.
> The following is what I see from sgtl5000 data sheet about VAG_POWER.
> VAG is the internal voltage reference for the ADC and DAC.
> Are you seeing any info that requires VAG_POWER in route of LINE_IN to
> Headphone Mux? Or it's only a result from your testing?
Given the name I rather suspect that's a datasheet error and the same
reference is used by other bits of the chip. Just guessing, though.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [alsa-devel] [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
@ 2012-07-31 15:46 ` Mark Brown
0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2012-07-31 15:46 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Jul 28, 2012 at 10:39:59PM +0800, Shawn Guo wrote:
> On Fri, Jul 27, 2012 at 07:18:42PM +0800, Dong Aisheng wrote:
> > LINE_IN also needs VAG_POWER on or we may hear noise when directly
> > route LINE_IN to Headphone Mux.
> The following is what I see from sgtl5000 data sheet about VAG_POWER.
> VAG is the internal voltage reference for the ADC and DAC.
> Are you seeing any info that requires VAG_POWER in route of LINE_IN to
> Headphone Mux? Or it's only a result from your testing?
Given the name I rather suspect that's a datasheet error and the same
reference is used by other bits of the chip. Just guessing, though.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [alsa-devel] [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
2012-07-28 14:39 ` [alsa-devel] " Shawn Guo
@ 2012-08-01 2:46 ` Dong Aisheng
-1 siblings, 0 replies; 10+ messages in thread
From: Dong Aisheng @ 2012-08-01 2:46 UTC (permalink / raw)
To: Shawn Guo
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
lrg@ti.com, linux-arm-kernel@lists.infradead.org
On Sat, Jul 28, 2012 at 10:39:59PM +0800, Shawn Guo wrote:
> On Fri, Jul 27, 2012 at 07:18:42PM +0800, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng@linaro.org>
> >
> > LINE_IN also needs VAG_POWER on or we may hear noise when directly
> > route LINE_IN to Headphone Mux.
>
> The following is what I see from sgtl5000 data sheet about VAG_POWER.
>
> VAG is the internal voltage reference for the ADC and DAC.
>
> Are you seeing any info that requires VAG_POWER in route of LINE_IN to
> Headphone Mux? Or it's only a result from your testing?
>
No, it's from the test result.
Maybe i should have added a FIXME for this.
> Does it also fix the noise issue you mentioned with normal recording
> (LINE_IN to ADC) before?
>
ADC also needs VAG power which already fixed by:
commit f0cdcf3 (ASoC: sgtl5000: Enable VAG when DAC/ADC up)
This patch is only for direct LINE_IN to Headphone Mux.
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 10+ messages in thread
* [alsa-devel] [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
@ 2012-08-01 2:46 ` Dong Aisheng
0 siblings, 0 replies; 10+ messages in thread
From: Dong Aisheng @ 2012-08-01 2:46 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Jul 28, 2012 at 10:39:59PM +0800, Shawn Guo wrote:
> On Fri, Jul 27, 2012 at 07:18:42PM +0800, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng@linaro.org>
> >
> > LINE_IN also needs VAG_POWER on or we may hear noise when directly
> > route LINE_IN to Headphone Mux.
>
> The following is what I see from sgtl5000 data sheet about VAG_POWER.
>
> VAG is the internal voltage reference for the ADC and DAC.
>
> Are you seeing any info that requires VAG_POWER in route of LINE_IN to
> Headphone Mux? Or it's only a result from your testing?
>
No, it's from the test result.
Maybe i should have added a FIXME for this.
> Does it also fix the noise issue you mentioned with normal recording
> (LINE_IN to ADC) before?
>
ADC also needs VAG power which already fixed by:
commit f0cdcf3 (ASoC: sgtl5000: Enable VAG when DAC/ADC up)
This patch is only for direct LINE_IN to Headphone Mux.
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN
2012-07-27 11:18 ` Dong Aisheng
@ 2012-07-31 15:40 ` Mark Brown
-1 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2012-07-31 15:40 UTC (permalink / raw)
To: Dong Aisheng; +Cc: alsa-devel, lrg, linux-arm-kernel
On Fri, Jul 27, 2012 at 07:18:42PM +0800, Dong Aisheng wrote:
> From: Dong Aisheng <dong.aisheng@linaro.org>
>
> LINE_IN also needs VAG_POWER on or we may hear noise when directly
> route LINE_IN to Headphone Mux.
> Tested on imx28evk.
Applied, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-08-01 2:46 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-27 11:18 [PATCH 1/1] ASoC: sgtl5000: enable VAG_POWER for LINE_IN Dong Aisheng
2012-07-27 11:18 ` Dong Aisheng
2012-07-28 14:39 ` Shawn Guo
2012-07-28 14:39 ` [alsa-devel] " Shawn Guo
2012-07-31 15:46 ` Mark Brown
2012-07-31 15:46 ` [alsa-devel] " Mark Brown
2012-08-01 2:46 ` Dong Aisheng
2012-08-01 2:46 ` Dong Aisheng
2012-07-31 15:40 ` Mark Brown
2012-07-31 15:40 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.