From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: am33xx: default to status = "disabled"?
Date: Thu, 2 Aug 2012 23:28:16 +0000 [thread overview]
Message-ID: <201208022328.17095.arnd@arndb.de> (raw)
In-Reply-To: <501B061A.6080008@gmail.com>
On Thursday 02 August 2012, Daniel Mack wrote:
> currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by
> default. However, depending on the actual board dts, only some of the
> devices should actually be initialized, given that they only make sense
> if their pins are actually wired on the board.
>
> On other platform, such devices are marked with status = "disabled", and
> the board files re-enable those they really use by overriding that
> status again. That approach seems to make sense - shouldn't the same be
> done in am33xx.dtsi or am I missing something?
I agree, they should be disabled, at least the serial ports, and probably
also the i2c controllers.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Koen Kooi
<koen-QLwJDigV5abLmq1fohREcCpxlwaOVQ5f@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: am33xx: default to status = "disabled"?
Date: Thu, 2 Aug 2012 23:28:16 +0000 [thread overview]
Message-ID: <201208022328.17095.arnd@arndb.de> (raw)
In-Reply-To: <501B061A.6080008-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Thursday 02 August 2012, Daniel Mack wrote:
> currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by
> default. However, depending on the actual board dts, only some of the
> devices should actually be initialized, given that they only make sense
> if their pins are actually wired on the board.
>
> On other platform, such devices are marked with status = "disabled", and
> the board files re-enable those they really use by overriding that
> status again. That approach seems to make sense - shouldn't the same be
> done in am33xx.dtsi or am I missing something?
I agree, they should be disabled, at least the serial ports, and probably
also the i2c controllers.
Arnd
next prev parent reply other threads:[~2012-08-02 23:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 22:58 am33xx: default to status = "disabled"? Daniel Mack
2012-08-02 22:58 ` Daniel Mack
2012-08-02 23:28 ` Arnd Bergmann [this message]
2012-08-02 23:28 ` Arnd Bergmann
2012-08-03 9:31 ` Hiremath, Vaibhav
2012-08-03 9:31 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208022328.17095.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.