From: Minchan Kim <minchan@kernel.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Konrad Wilk <konrad.wilk@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Andrew Morton <akpm@linux-foundation.org>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH 0/4] promote zcache from staging
Date: Tue, 7 Aug 2012 09:44:05 +0900 [thread overview]
Message-ID: <20120807004405.GA19515@bbox> (raw)
In-Reply-To: <be1daa96-d246-46de-a178-b14b3a862eca@default>
Hi Dan,
On Mon, Aug 06, 2012 at 09:21:22AM -0700, Dan Magenheimer wrote:
> > From: Pekka Enberg [mailto:penberg@kernel.org]
> > Subject: Re: [PATCH 0/4] promote zcache from staging
> >
> > On Mon, Aug 6, 2012 at 6:24 PM, Dan Magenheimer
> > <dan.magenheimer@oracle.com> wrote:
> > > IMHO, the fastest way to get the best zcache into the kernel and
> > > to distros and users is to throw away the "demo" version, move forward
> > > to a new solid well-designed zcache code base, and work together to
> > > build on it. There's still a lot to do so I hope we can work together.
> >
> > I'm not convinced it's the _fastest way_.
>
> <grin> I guess I meant "optimal", combining "fast" and "best".
>
> > You're effectively
> > invalidating all the work done under drivers/staging so you might end up
> > in review limbo with your shiny new code...
>
> Fixing the fundamental design flaws will sooner or later invalidate
> most (or all) of the previous testing/work anyway, won't it? Since
> any kernel built with staging is "tainted" already, I feel like now
> is a better time to make a major design transition.
>
> I suppose:
>
> (E) replace "demo" zcache with new code base and keep it
> in staging for another cycle
I go for (E). Please send your refactoring code as formal patch.
Thanks.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Konrad Wilk <konrad.wilk@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Andrew Morton <akpm@linux-foundation.org>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH 0/4] promote zcache from staging
Date: Tue, 7 Aug 2012 09:44:05 +0900 [thread overview]
Message-ID: <20120807004405.GA19515@bbox> (raw)
In-Reply-To: <be1daa96-d246-46de-a178-b14b3a862eca@default>
Hi Dan,
On Mon, Aug 06, 2012 at 09:21:22AM -0700, Dan Magenheimer wrote:
> > From: Pekka Enberg [mailto:penberg@kernel.org]
> > Subject: Re: [PATCH 0/4] promote zcache from staging
> >
> > On Mon, Aug 6, 2012 at 6:24 PM, Dan Magenheimer
> > <dan.magenheimer@oracle.com> wrote:
> > > IMHO, the fastest way to get the best zcache into the kernel and
> > > to distros and users is to throw away the "demo" version, move forward
> > > to a new solid well-designed zcache code base, and work together to
> > > build on it. There's still a lot to do so I hope we can work together.
> >
> > I'm not convinced it's the _fastest way_.
>
> <grin> I guess I meant "optimal", combining "fast" and "best".
>
> > You're effectively
> > invalidating all the work done under drivers/staging so you might end up
> > in review limbo with your shiny new code...
>
> Fixing the fundamental design flaws will sooner or later invalidate
> most (or all) of the previous testing/work anyway, won't it? Since
> any kernel built with staging is "tainted" already, I feel like now
> is a better time to make a major design transition.
>
> I suppose:
>
> (E) replace "demo" zcache with new code base and keep it
> in staging for another cycle
I go for (E). Please send your refactoring code as formal patch.
Thanks.
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2012-08-07 0:42 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<1343413117-1989-1-git-send-email-sjenning@linux.vnet.ibm.com>
2012-07-27 19:21 ` [PATCH 0/4] promote zcache from staging Dan Magenheimer
2012-07-27 19:21 ` Dan Magenheimer
2012-07-27 20:59 ` Konrad Rzeszutek Wilk
2012-07-27 20:59 ` Konrad Rzeszutek Wilk
2012-07-27 21:42 ` Dan Magenheimer
2012-07-27 21:42 ` Dan Magenheimer
2012-07-29 1:54 ` Minchan Kim
2012-07-29 1:54 ` Minchan Kim
2012-07-31 15:36 ` Konrad Rzeszutek Wilk
2012-07-31 15:36 ` Konrad Rzeszutek Wilk
2012-08-06 4:49 ` Minchan Kim
2012-08-06 4:49 ` Minchan Kim
2012-07-30 19:19 ` Seth Jennings
2012-07-30 19:19 ` Seth Jennings
2012-07-30 20:48 ` Dan Magenheimer
2012-07-30 20:48 ` Dan Magenheimer
2012-07-31 15:58 ` Konrad Rzeszutek Wilk
2012-07-31 15:58 ` Konrad Rzeszutek Wilk
2012-07-31 16:19 ` Greg Kroah-Hartman
2012-07-31 16:19 ` Greg Kroah-Hartman
2012-07-31 17:51 ` Konrad Rzeszutek Wilk
2012-07-31 17:51 ` Konrad Rzeszutek Wilk
2012-07-31 18:19 ` Seth Jennings
2012-07-31 18:19 ` Seth Jennings
2012-08-06 0:38 ` Minchan Kim
2012-08-06 0:38 ` Minchan Kim
2012-08-06 15:24 ` Dan Magenheimer
2012-08-06 15:24 ` Dan Magenheimer
2012-08-06 15:47 ` Pekka Enberg
2012-08-06 15:47 ` Pekka Enberg
2012-08-06 16:21 ` Dan Magenheimer
2012-08-06 16:21 ` Dan Magenheimer
2012-08-06 16:29 ` Greg Kroah-Hartman
2012-08-06 16:29 ` Greg Kroah-Hartman
2012-08-06 16:38 ` Dan Magenheimer
2012-08-06 16:38 ` Dan Magenheimer
2012-08-07 0:44 ` Minchan Kim [this message]
2012-08-07 0:44 ` Minchan Kim
2012-08-07 19:28 ` Konrad Rzeszutek Wilk
2012-07-27 18:18 Seth Jennings
2012-07-27 18:18 ` Seth Jennings
2012-07-27 18:18 ` [PATCH 1/4] zsmalloc: collapse internal .h into .c Seth Jennings
2012-07-27 18:18 ` Seth Jennings
2012-07-27 18:18 ` [PATCH 2/4] zsmalloc: promote to mm/ Seth Jennings
2012-07-27 18:18 ` Seth Jennings
2012-07-27 18:18 ` [PATCH 3/4] drivers: add memory management driver class Seth Jennings
2012-07-27 18:18 ` Seth Jennings
2012-07-31 15:31 ` Konrad Rzeszutek Wilk
2012-07-31 15:31 ` Konrad Rzeszutek Wilk
2012-07-27 18:18 ` [PATCH 4/4] zcache: promote to drivers/mm/ Seth Jennings
2012-07-27 18:18 ` Seth Jennings
2012-07-29 2:20 ` [PATCH 0/4] promote zcache from staging Minchan Kim
2012-07-29 2:20 ` Minchan Kim
2012-08-07 20:23 ` Seth Jennings
2012-08-07 20:23 ` Seth Jennings
2012-08-07 21:47 ` Dan Magenheimer
2012-08-07 21:47 ` Dan Magenheimer
2012-08-08 16:29 ` Seth Jennings
2012-08-08 16:29 ` Seth Jennings
2012-08-08 17:47 ` Dan Magenheimer
2012-08-08 17:47 ` Dan Magenheimer
2012-08-09 18:50 ` Seth Jennings
2012-08-09 18:50 ` Seth Jennings
2012-08-09 20:20 ` Dan Magenheimer
2012-08-09 20:20 ` Dan Magenheimer
2012-08-10 18:14 ` Seth Jennings
2012-08-10 18:14 ` Seth Jennings
2012-08-15 9:38 ` Konrad Rzeszutek Wilk
2012-08-15 9:38 ` Konrad Rzeszutek Wilk
2012-08-15 14:24 ` Seth Jennings
2012-08-15 14:24 ` Seth Jennings
2012-08-17 22:21 ` Dan Magenheimer
2012-08-17 22:21 ` Dan Magenheimer
2012-08-17 23:33 ` Seth Jennings
2012-08-17 23:33 ` Seth Jennings
2012-08-18 19:09 ` Dan Magenheimer
2012-08-18 19:09 ` Dan Magenheimer
2012-08-14 22:18 ` Seth Jennings
2012-08-14 22:18 ` Seth Jennings
2012-08-14 23:29 ` Minchan Kim
2012-08-14 23:29 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807004405.GA19515@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.wilk@oracle.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=penberg@kernel.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.