All of lore.kernel.org
 help / color / mirror / Atom feed
From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org, Kurt Hackel <kurt.hackel@oracle.com>
Subject: Re: [PATCH 0/4] promote zcache from staging
Date: Wed, 15 Aug 2012 09:24:37 -0500	[thread overview]
Message-ID: <502BB125.7030607@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120815093828.GB2865@phenom.dumpdata.com>

On 08/15/2012 04:38 AM, Konrad Rzeszutek Wilk wrote:
> On Fri, Aug 10, 2012 at 01:14:01PM -0500, Seth Jennings wrote:
>> On 08/09/2012 03:20 PM, Dan Magenheimer wrote
>>> I also wonder if you have anything else unusual in your
>>> test setup, such as a fast swap disk (mine is a partition
>>> on the same rotating disk as source and target of the kernel build,
>>> the default install for a RHEL6 system)?
>>
>> I'm using a normal SATA HDD with two partitions, one for
>> swap and the other an ext3 filesystem with the kernel source.
>>
>>> Or have you disabled cleancache?
>>
>> Yes, I _did_ disable cleancache.  I could see where having
>> cleancache enabled could explain the difference in results.
> 
> Why did you disable the cleancache? Having both (cleancache
> to compress fs data) and frontswap (to compress swap data) is the
> goal - while you turned one of its sources off.

I excluded cleancache to reduce interference/noise from the
benchmarking results. For this particular workload,
cleancache doesn't make a lot of sense since it will steal
pages that could otherwise be used for storing frontswap
pages to prevent swapin/swapout I/O.

In a test run with both enabled, I found that it didn't make
much difference under moderate to extreme memory pressure.
Both resulted in about 55% I/O reduction.  However, on light
memory pressure with 8 and 12 threads, it lowered the I/O
reduction ability of zcache to roughly 0 compared to ~20%
I/O reduction without cleancache.

In short, cleancache only had the power to harm in this
case, so I didn't enable it.

Seth

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org, Kurt Hackel <kurt.hackel@oracle.com>
Subject: Re: [PATCH 0/4] promote zcache from staging
Date: Wed, 15 Aug 2012 09:24:37 -0500	[thread overview]
Message-ID: <502BB125.7030607@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120815093828.GB2865@phenom.dumpdata.com>

On 08/15/2012 04:38 AM, Konrad Rzeszutek Wilk wrote:
> On Fri, Aug 10, 2012 at 01:14:01PM -0500, Seth Jennings wrote:
>> On 08/09/2012 03:20 PM, Dan Magenheimer wrote
>>> I also wonder if you have anything else unusual in your
>>> test setup, such as a fast swap disk (mine is a partition
>>> on the same rotating disk as source and target of the kernel build,
>>> the default install for a RHEL6 system)?
>>
>> I'm using a normal SATA HDD with two partitions, one for
>> swap and the other an ext3 filesystem with the kernel source.
>>
>>> Or have you disabled cleancache?
>>
>> Yes, I _did_ disable cleancache.  I could see where having
>> cleancache enabled could explain the difference in results.
> 
> Why did you disable the cleancache? Having both (cleancache
> to compress fs data) and frontswap (to compress swap data) is the
> goal - while you turned one of its sources off.

I excluded cleancache to reduce interference/noise from the
benchmarking results. For this particular workload,
cleancache doesn't make a lot of sense since it will steal
pages that could otherwise be used for storing frontswap
pages to prevent swapin/swapout I/O.

In a test run with both enabled, I found that it didn't make
much difference under moderate to extreme memory pressure.
Both resulted in about 55% I/O reduction.  However, on light
memory pressure with 8 and 12 threads, it lowered the I/O
reduction ability of zcache to roughly 0 compared to ~20%
I/O reduction without cleancache.

In short, cleancache only had the power to harm in this
case, so I didn't enable it.

Seth


  reply	other threads:[~2012-08-15 14:36 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27 18:18 [PATCH 0/4] promote zcache from staging Seth Jennings
2012-07-27 18:18 ` Seth Jennings
2012-07-27 18:18 ` [PATCH 1/4] zsmalloc: collapse internal .h into .c Seth Jennings
2012-07-27 18:18   ` Seth Jennings
2012-07-27 18:18 ` [PATCH 2/4] zsmalloc: promote to mm/ Seth Jennings
2012-07-27 18:18   ` Seth Jennings
2012-07-27 18:18 ` [PATCH 3/4] drivers: add memory management driver class Seth Jennings
2012-07-27 18:18   ` Seth Jennings
2012-07-31 15:31   ` Konrad Rzeszutek Wilk
2012-07-31 15:31     ` Konrad Rzeszutek Wilk
2012-07-27 18:18 ` [PATCH 4/4] zcache: promote to drivers/mm/ Seth Jennings
2012-07-27 18:18   ` Seth Jennings
2012-07-29  2:20 ` [PATCH 0/4] promote zcache from staging Minchan Kim
2012-07-29  2:20   ` Minchan Kim
2012-08-07 20:23 ` Seth Jennings
2012-08-07 20:23   ` Seth Jennings
2012-08-07 21:47   ` Dan Magenheimer
2012-08-07 21:47     ` Dan Magenheimer
2012-08-08 16:29     ` Seth Jennings
2012-08-08 16:29       ` Seth Jennings
2012-08-08 17:47       ` Dan Magenheimer
2012-08-08 17:47         ` Dan Magenheimer
2012-08-09 18:50   ` Seth Jennings
2012-08-09 18:50     ` Seth Jennings
2012-08-09 20:20     ` Dan Magenheimer
2012-08-09 20:20       ` Dan Magenheimer
2012-08-10 18:14       ` Seth Jennings
2012-08-10 18:14         ` Seth Jennings
2012-08-15  9:38         ` Konrad Rzeszutek Wilk
2012-08-15  9:38           ` Konrad Rzeszutek Wilk
2012-08-15 14:24           ` Seth Jennings [this message]
2012-08-15 14:24             ` Seth Jennings
2012-08-17 22:21         ` Dan Magenheimer
2012-08-17 22:21           ` Dan Magenheimer
2012-08-17 23:33           ` Seth Jennings
2012-08-17 23:33             ` Seth Jennings
2012-08-18 19:09             ` Dan Magenheimer
2012-08-18 19:09               ` Dan Magenheimer
2012-08-14 22:18 ` Seth Jennings
2012-08-14 22:18   ` Seth Jennings
2012-08-14 23:29   ` Minchan Kim
2012-08-14 23:29     ` Minchan Kim
     [not found] <<1343413117-1989-1-git-send-email-sjenning@linux.vnet.ibm.com>
2012-07-27 19:21 ` Dan Magenheimer
2012-07-27 19:21   ` Dan Magenheimer
2012-07-27 20:59   ` Konrad Rzeszutek Wilk
2012-07-27 20:59     ` Konrad Rzeszutek Wilk
2012-07-27 21:42     ` Dan Magenheimer
2012-07-27 21:42       ` Dan Magenheimer
2012-07-29  1:54       ` Minchan Kim
2012-07-29  1:54         ` Minchan Kim
2012-07-31 15:36         ` Konrad Rzeszutek Wilk
2012-07-31 15:36           ` Konrad Rzeszutek Wilk
2012-08-06  4:49           ` Minchan Kim
2012-08-06  4:49             ` Minchan Kim
2012-07-30 19:19       ` Seth Jennings
2012-07-30 19:19         ` Seth Jennings
2012-07-30 20:48         ` Dan Magenheimer
2012-07-30 20:48           ` Dan Magenheimer
2012-07-31 15:58           ` Konrad Rzeszutek Wilk
2012-07-31 15:58             ` Konrad Rzeszutek Wilk
2012-07-31 16:19             ` Greg Kroah-Hartman
2012-07-31 16:19               ` Greg Kroah-Hartman
2012-07-31 17:51               ` Konrad Rzeszutek Wilk
2012-07-31 17:51                 ` Konrad Rzeszutek Wilk
2012-07-31 18:19                 ` Seth Jennings
2012-07-31 18:19                   ` Seth Jennings
2012-08-06  0:38                 ` Minchan Kim
2012-08-06  0:38                   ` Minchan Kim
2012-08-06 15:24                   ` Dan Magenheimer
2012-08-06 15:24                     ` Dan Magenheimer
2012-08-06 15:47                     ` Pekka Enberg
2012-08-06 15:47                       ` Pekka Enberg
2012-08-06 16:21                       ` Dan Magenheimer
2012-08-06 16:21                         ` Dan Magenheimer
2012-08-06 16:29                         ` Greg Kroah-Hartman
2012-08-06 16:29                           ` Greg Kroah-Hartman
2012-08-06 16:38                           ` Dan Magenheimer
2012-08-06 16:38                             ` Dan Magenheimer
2012-08-07  0:44                         ` Minchan Kim
2012-08-07  0:44                           ` Minchan Kim
2012-08-07 19:28                   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502BB125.7030607@linux.vnet.ibm.com \
    --to=sjenning@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=rcj@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.